Thread: [Codestriker-commits] CVS update: codestriker/lib/Codestriker/Http Response.pm
Brought to you by:
sits
From: <si...@us...> - 2006-06-11 08:29:13
|
User: sits Date: 06/06/11 01:29:11 Modified: . CHANGELOG lib/Codestriker/Action SubmitNewComment.pm lib/Codestriker/Http Response.pm Log: * Closed topics could still have comments added to them, by hovering over an existing comment in the topic text view, and then clicking the "Add Comment" link in the tooltip window. This link has now been removed if the topic is closed. Contributed by ed....@si.... Index: CHANGELOG =================================================================== RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v retrieving revision 1.190 retrieving revision 1.191 diff -u -r1.190 -r1.191 --- CHANGELOG 10 Jun 2006 02:58:32 -0000 1.190 +++ CHANGELOG 11 Jun 2006 08:29:11 -0000 1.191 @@ -83,6 +83,12 @@ such as Subversion. Contributed by "Vladimir Vysotsky" <vvy...@av...>. +* Closed topics could still have comments added to them, by hovering + over an existing comment in the topic text view, and then clicking + the "Add Comment" link in the tooltip window. This link has now + been removed if the topic is closed. + Contributed by ed....@si.... + Version 1.9.1 * Correct problem introduced in 1.9.0 release where the email address Index: SubmitNewComment.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Action/SubmitNewComment.pm,v retrieving revision 1.11 retrieving revision 1.12 diff -u -r1.11 -r1.12 --- SubmitNewComment.pm 22 May 2006 23:19:05 -0000 1.11 +++ SubmitNewComment.pm 11 Jun 2006 08:29:11 -0000 1.12 @@ -61,6 +61,11 @@ # Retrieve the appropriate topic details. my $topic = Codestriker::Model::Topic->new($topicid); + # Don't accept any new comments if the topic state is read only. + if (Codestriker::topic_readonly($topic->{topic_state})) { + $http_response->error("Topic state is read only"); + } + # Fire the topic listener to indicate that the user has viewed the topic. Codestriker::TopicListeners::Manager::topic_viewed($email, $topic); Index: Response.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Response.pm,v retrieving revision 1.37 retrieving revision 1.38 diff -u -r1.37 -r1.38 --- Response.pm 19 May 2006 00:40:15 -0000 1.37 +++ Response.pm 11 Jun 2006 08:29:11 -0000 1.38 @@ -372,8 +372,10 @@ # Add an add comment link. my $key = $comment_locations[$index]; $key =~ /^(\-?\d+)\|(\-?\d+)\|(\d+)$/o; - $overlib_html .= "<a href=\"javascript:add_comment_tooltip($1,$2,$3)" . - "; void(0);\">Add Comment<\\/a> | "; + if (!Codestriker::topic_readonly($topic->{topic_state})) { + $overlib_html .= "<a href=\"javascript:add_comment_tooltip($1,$2,$3)" . + "; void(0);\">Add Comment<\\/a> | "; + } # Add a close link. $overlib_html .= "<a href=\"javascript:hideElt(getElt(\\'overDiv\\')); void(0);\">Close<\\/a><p>"; |
From: <si...@us...> - 2006-07-17 01:21:37
|
User: sits Date: 06/07/16 18:21:36 Modified: bin codestriker.pl.base lib/Codestriker/Http Response.pm Log: The configuration option $use_compression = 1 now works again. This was broken by the new utf8 code. The binmode of STDOUT is left as binary if this configuration option is set. Index: codestriker.pl.base =================================================================== RCS file: /cvsroot/codestriker/codestriker/bin/codestriker.pl.base,v retrieving revision 1.22 retrieving revision 1.23 diff -u -r1.22 -r1.23 --- codestriker.pl.base 22 May 2006 11:39:39 -0000 1.22 +++ codestriker.pl.base 17 Jul 2006 01:21:35 -0000 1.23 @@ -80,9 +80,6 @@ $ENV{'PATH'} = ''; } -# Make sure the STDOUT encoding is set to UTF8. -binmode STDOUT, ':utf8'; - # Prototypes of subroutines used in this module. sub main(); Index: Response.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Response.pm,v retrieving revision 1.38 retrieving revision 1.39 diff -u -r1.38 -r1.39 --- Response.pm 11 Jun 2006 08:29:11 -0000 1.38 +++ Response.pm 17 Jul 2006 01:21:35 -0000 1.39 @@ -193,6 +193,9 @@ select(GZIP); $output_compressed = 1; } else { + # Make sure the STDOUT encoding is set to UTF8. Not needed + # when the data is being sent as compressed bytes. + binmode STDOUT, ':utf8'; if ($cache) { print $query->header(-cookie=>$cookie_obj, -charset=>"UTF-8"); |
From: <si...@us...> - 2007-05-07 23:52:54
|
User: sits Date: 07/05/07 16:52:45 Modified: lib/Codestriker/Http Response.pm Log: Improve the code for determining where the codestriker css file is. Index: Response.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Response.pm,v retrieving revision 1.39 retrieving revision 1.40 diff -u -r1.39 -r1.40 --- Response.pm 17 Jul 2006 01:21:35 -0000 1.39 +++ Response.pm 7 May 2007 23:52:45 -0000 1.40 @@ -221,7 +221,7 @@ $codestriker_css = $Codestriker::codestriker_css; } else { $codestriker_css = $query->url(); - $codestriker_css =~ s/codestriker\/codestriker\.pl/codestrikerhtml\/codestriker\.css/; + $codestriker_css =~ s/\/[\w\-]+\/codestriker\.pl/\/codestrikerhtml\/codestriker\.css/; } my $overlib_js = $codestriker_css; |
From: <si...@us...> - 2007-05-22 04:07:37
|
User: sits Date: 07/05/21 21:07:35 Modified: . CHANGELOG lib/Codestriker/Http Response.pm Log: Emit javascript warning if can't find external javascript files Index: CHANGELOG =================================================================== RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v retrieving revision 1.200 retrieving revision 1.201 diff -u -r1.200 -r1.201 --- CHANGELOG 7 Mar 2007 03:55:48 -0000 1.200 +++ CHANGELOG 22 May 2007 04:07:35 -0000 1.201 @@ -1,6 +1,11 @@ *** When upgrading, don't forget to: "cd bin ; ./install.pl" *** *** Also, it is _highly_ advisable to backup your data before upgrading *** +Version 1.9.4 + +* Emit a javascript warning if the external javascript files could + not be loaded. This usually occurs due to apache misconfiguration. + Version 1.9.3 * The project list screen now displays for each project, the total Index: Response.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Response.pm,v retrieving revision 1.40 retrieving revision 1.41 diff -u -r1.40 -r1.41 --- Response.pm 7 May 2007 23:52:45 -0000 1.40 +++ Response.pm 22 May 2007 04:07:35 -0000 1.41 @@ -274,6 +274,14 @@ } $i++; } + + # Check that the external javascript files were loaded, and if not + # output an error message. This is usually due to a + # misconfiguration. + print " if ('function' != typeof window.add_comment_html) {\n"; + print " alert('Oh oh... can\\'t find codestriker.js, please check your apache config.');\n"; + print " }\n"; + print "</script>\n"; # Output the comment declarations if the $comments array is defined. |
From: <si...@us...> - 2007-09-24 21:15:10
|
User: sits Date: 07/09/24 14:15:08 Modified: lib/Codestriker/Http Response.pm Log: Fixed a whoops found by ski...@us... Index: Response.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Response.pm,v retrieving revision 1.41 retrieving revision 1.42 diff -u -r1.41 -r1.42 --- Response.pm 22 May 2007 04:07:35 -0000 1.41 +++ Response.pm 24 Sep 2007 21:15:08 -0000 1.42 @@ -474,7 +474,7 @@ "</result></response>\n"; } else { - if (! $self->{generated_header}) { + if (! $self->{header_generated}) { print $query->header, $query->start_html(-title=>'Codestriker error', -bgcolor=>'white'); |
From: <si...@us...> - 2008-06-23 01:26:06
|
User: sits Date: 08/06/22 18:26:02 Modified: lib/Codestriker/Http Response.pm Log: More fixes to make the URL rewriting work correctly when referencing the style-sheets. Index: Response.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Response.pm,v retrieving revision 1.44 retrieving revision 1.45 diff -u -r1.44 -r1.45 --- Response.pm 21 Jun 2008 10:55:56 -0000 1.44 +++ Response.pm 23 Jun 2008 01:26:01 -0000 1.45 @@ -215,7 +215,7 @@ $title = HTML::Entities::encode($title); # Generate the URL to the codestriker CSS file. - my $codestriker_css = $query->url(); + my $codestriker_css; if (defined $Codestriker::codestriker_css && $Codestriker::codestriker_css ne "") { if ($Codestriker::codestriker_css =~ /[\/\\]/o) { @@ -224,11 +224,13 @@ } else { # Assume CSS file is in case html directory, just under # a different name. - $codestriker_css =~ s/\/.+?\/codestriker\.pl/\/codestrikerhtml\/$Codestriker::codestriker_css/; + $codestriker_css = $query->url(); + $codestriker_css =~ s#/[^/]+?/codestriker\.pl#/codestrikerhtml/$Codestriker::codestriker_css#; } } else { # Use the default CSS file. - $codestriker_css =~ s/\/.+?\/codestriker\.pl/\/codestrikerhtml\/codestriker\.css/; + $codestriker_css = $query->url(); + $codestriker_css =~ s#/[^/]+?/codestriker\.pl#/codestrikerhtml/codestriker.css#; } |
From: <si...@us...> - 2008-07-01 10:06:47
|
User: sits Date: 08/07/01 03:06:46 Modified: lib/Codestriker/Http Response.pm Log: Use a DTD which will put IE 6 and above into "standards compliant" mode, so that various CSS attributes like white-space will work. Index: Response.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Response.pm,v retrieving revision 1.46 retrieving revision 1.47 diff -u -r1.46 -r1.47 --- Response.pm 23 Jun 2008 07:12:06 -0000 1.46 +++ Response.pm 1 Jul 2008 10:06:46 -0000 1.47 @@ -244,7 +244,9 @@ # Print the basic HTML header header, with the inclusion of the scripts. - print '<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">'; + # Make sure a DOCTYPE is used which will put IE 6 and above into + # "standards-compliant mode": http://msdn.microsoft.com/en-us/library/ms535242(VS.85).aspx. + print '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN">'; print "\n"; print '<html xmlns="http://www.w3.org/1999/xhtml" lang="en-US" xml:lang="en-US">'; print "\n"; |
From: <si...@us...> - 2008-09-02 06:36:17
|
User: sits Date: 08/09/01 23:36:16 Modified: lib/Codestriker/Http Response.pm Log: Minor tweak to get the nice URL case locating the static files. Index: Response.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Response.pm,v retrieving revision 1.49 retrieving revision 1.50 diff -u -r1.49 -r1.50 --- Response.pm 29 Aug 2008 10:49:02 -0000 1.49 +++ Response.pm 2 Sep 2008 06:36:16 -0000 1.50 @@ -234,7 +234,7 @@ if (defined $Codestriker::cgi_style && $Codestriker::cgi_style) { $codestriker_css =~ s#/[^/]+?/codestriker\.pl#/codestrikerhtml/codestriker.css#; } else { - $codestriker_css = $query->url() . "html/codestriker.css"; + $codestriker_css = $query->url() . "/html/codestriker.css"; } } |
From: <si...@us...> - 2008-09-02 06:44:29
|
User: sits Date: 08/09/01 23:44:28 Modified: lib/Codestriker/Http Response.pm Log: Minor tweak to get the links to the html directory working for classic URLs. Index: Response.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Response.pm,v retrieving revision 1.50 retrieving revision 1.51 diff -u -r1.50 -r1.51 --- Response.pm 2 Sep 2008 06:36:16 -0000 1.50 +++ Response.pm 2 Sep 2008 06:44:28 -0000 1.51 @@ -231,7 +231,7 @@ } else { # Use the default CSS file. $codestriker_css = $query->url(); - if (defined $Codestriker::cgi_style && $Codestriker::cgi_style) { + if (! defined $Codestriker::cgi_style || $Codestriker::cgi_style) { $codestriker_css =~ s#/[^/]+?/codestriker\.pl#/codestrikerhtml/codestriker.css#; } else { $codestriker_css = $query->url() . "/html/codestriker.css"; |