#67 Long File Paths Mess with readable Display

closed-fixed
nobody
None
5
2008-02-26
2008-01-08
rob_webset
No

We noticed that if you have long paths to your files (Like pretty much everything in Java). Then it means that the right hand side of the view code review page (i.e. the more recent file) is moved a long way to the right. This can be really hard to read and normally means a lot of scrolling even with a large widesreen monitor.

This is caused my having the "diff for <filename>" span three columns (there is four in total) so pushing everything accross the screen.

A solution to this (The one I patched our system with) is to put a mini table into the cell that currently does the spanning.

So in file: Render.pm
Function: delta_file_header()

Just before the line that states:

# Generate the text for the link to add a file-level comment.
my $add_file_level_comment_text =

Add the code:

print "<tr><td class=\"file\" colspan=\"4\"><TABLE>";

And then at the end of the function also add:

print "</TABLE></TD></TR>";

There may be a nicer way of doing this, but this is the quick fix we put in for now.

Discussion

  • rob_webset
    rob_webset
    2008-01-08

    Logged In: YES
    user_id=1137102
    Originator: YES

    Correction the first line of code should be:
    print "<tr><td class=\"file\" colspan=\"4\"><TABLE width=100%>";

     
  • David Sitsky
    David Sitsky
    2008-02-26

    Logged In: YES
    user_id=208928
    Originator: NO

    Thanks - this has been fixed now for the 1.9.5 release.

     
  • David Sitsky
    David Sitsky
    2008-02-26

    • status: open --> closed-fixed