From: David E. Y. <de...@mi...> - 2000-04-08 14:29:10
|
Hello. The other day I reported a problem with filename extension handling in defsystem-3.x. A member of this list responded, indicating he'd submitted a patch and that it was likely in the archive (he also sent me the patch, but something in his email'd file irritated metamail and the patch arrived corrupted). In any event, I checked the archive, found it to be newer than the version I had and updated my space. Same problem. So, I've included here a patch to defsystem-3.x that seems to correct the filename extension handling problem. I've tested this version using various DEFSYSTEM configurations -- default extensions, user-specified extensions, and extensions supplied via MK:DEFINE-LANGUAGE. I've also built our software and Loom 4.0 using this patch, for further testing. It's very possible the aforementioned poster's patch didn't make it into the archive before I updated my space, and you folks indeed already have a fix for this problem. If so, please let me know. Otherwise, have a look and see if this fix "covers all the bases", as it were. You folks have probably spent more time in DEFSYSTEM than I have; my simple repair might have overlooked a detail or two. To apply this patch, cd into the CLOCC source tree (the directory containing SRC) and run patch -p 0 < <patch file> or however you like to do such things. Regards, -- David E. Young Fujitsu Network Communications "The fact that ... we still (de...@nc...) live well cannot ease the pain of feeling that we no longer live nobly." -- John Updike "Programming should be fun, programs should be beautiful" -- P. Graham ---------- cut here -------------- --- src/defsystem-3.x/defsystem.lisp Sat Apr 8 08:39:13 2000 +++ /files/devel/defsystem/defsystem.lisp Sat Apr 8 08:49:34 2000 @@ -548,7 +548,13 @@ ;;; Cfr. the definitions of *EXPORTS* and ;;; *SPECIAL-EXPORTS*. ;;; - +;;; 20000408 dey Source file extensions specified in the DEFSYSTEM +;;; were being ignored. Initializing structure +;;; COMPONENT's SOURCE-EXTENSION and BINARY-EXTENSION +;;; slots to NIL (rather than the default defined in +;;; *FILENAME-EXTENSIONS* seems to have cured the +;;; problem. David E. Young (de....@co...) +;;; ;;;--------------------------------------------------------------------------- ;;; ISI Comments ;;; @@ -2049,17 +2055,17 @@ ; with "/"), directory or file ; (ends with "/"). (source-pathname *source-pathname-default*) - (source-extension (car *filename-extensions*) :type string) - ; A string, e.g., "lisp". If - ; NIL, uses default for - ; machine-type. + (source-extension nil :type string) + ; A string, e.g., "lisp". If + ; NIL, uses default for + ; machine-type. (binary-pathname *binary-pathname-default*) binary-root-dir - (binary-extension (cdr *filename-extensions*) :type string) - ; A string, e.g., "fasl". If - ; NIL, uses default for - ; machine-type. - package ; Package for use-package. + (binary-extension nil :type string) + ; A string, e.g., "fasl". If + ; NIL, uses default for + ; machine-type. + package ; Package for use-package. ;; The following three slots are used to provide for alternate compilation ;; and loading functions for the files contained within a component. If |
From: Paolo A. <am...@mc...> - 2000-04-08 18:09:35
|
On Sat, 8 Apr 2000 09:19:49 -0400, David E. Young <de...@mi...> wrote: > MK:DEFINE-LANGUAGE. I've also built our software and Loom 4.0 using > this patch, for further testing. Just out of curiosity: doesn't Loom require a custom version of MK:DEFSYSTEM? Are you able to build Loom with the "stock" MK:DEFSYSTEM? Paolo -- EncyCMUCLopedia * Extensive collection of CMU Common Lisp documentation http://cvs2.cons.org:8000/cmucl/doc/EncyCMUCLopedia/ |
From: David E. Y. <de...@mi...> - 2000-04-09 19:30:11
|
>>>>> "Paolo" == Paolo Amoroso <am...@mc...> writes: Paolo> On Sat, 8 Apr 2000 09:19:49 -0400, David E. Young Paolo> <de...@mi...> wrote: >> MK:DEFINE-LANGUAGE. I've also built our software and Loom 4.0 using >> this patch, for further testing. Paolo> Just out of curiosity: doesn't Loom require a custom version of Paolo> MK:DEFSYSTEM? Are you able to build Loom with the "stock" Paolo> MK:DEFSYSTEM? The "extensions" required by Loom have been incorporated into defsystem-3.x. I successfully built Loom after applying my patch. -- David E. Young Fujitsu Network Communications "The fact that ... we still (de...@nc...) live well cannot ease the pain of feeling that we no longer live nobly." -- John Updike "Programming should be fun, programs should be beautiful" -- P. Graham |