From: Pascal B. <pj...@in...> - 2004-01-23 02:37:22
|
Hello, It seems to me that there is this error in modules/clx/new-clx/demos/qix.lisp (2.32): (defun qix (&key host display dpy (width 400) (height 400) (delay 0.05) (nqixs 3) (nlines 80)) (when dpy ;; instead of unless in original (setf (values host display) (x-host-display))) and in sokoban.lisp: (defvar *level* 1) ;current level (assert (<= 1 *level* 50)) ;; cf. screens/screen.* In find-outers: - (ff *man-x* *man-y*) + (ff (or *man-x* 0) (or *man-y* 0)) (or initialize *man-x* and *man-y* to something else than nil in defvars). And finally: (defun sokoban () + (init-field) (when (or (null *display*) (closed-display-p *display*)) -- __Pascal Bourguignon__ http://www.informatimago.com/ |
From: Sam S. <sd...@gn...> - 2004-01-23 14:23:23
|
> * Pascal Bourguignon <cwo@vasbezngvzntb.pbz> [2004-01-23 03:37:17 +0100]: > > It seems to me that there is this error in > modules/clx/new-clx/demos/qix.lisp (2.32): > > (defun qix (&key host display dpy > (width 400) (height 400) (delay 0.05) (nqixs 3) (nlines 80)) > (when dpy ;; instead of unless in original > (setf (values host display) (x-host-display))) I think UNLESS is correct: we need HOST & DISPLAY only when DPY is _not_ supplied. > and in sokoban.lisp: > > (defvar *level* 1) ;current level > (assert (<= 1 *level* 50)) ;; cf. screens/screen.* WFM. (I think *LEVEL* is increased _before_ the iteration) > In find-outers: > - (ff *man-x* *man-y*) > + (ff (or *man-x* 0) (or *man-y* 0)) > (or initialize *man-x* and *man-y* to something else than nil in > defvars). WFM. (These variables appear to be initialized in INIT-FIELD) > And finally: > (defun sokoban () > + (init-field) > (when (or (null *display*) (closed-display-p *display*)) WFM. this is actually related to the *LEVEL* issue above - the field is initialized as soon as *LEVEL* is increased, which is the first thing done on entry. what errors are you getting? -- Sam Steingold (http://www.podval.org/~sds) running w2k <http://www.camera.org> <http://www.iris.org.il> <http://www.memri.org/> <http://www.mideasttruth.com/> <http://www.honestreporting.com> Winword 6.0 UNinstall: Not enough disk space to uninstall WinWord |