Menu

#462 quote arguments of "test -n"

build problems
closed-fixed
clisp (524)
5
2008-04-02
2008-04-02
No

without the following fix for makemake.in, i get errors like

./makemake: [: argument expected

this happens when building clisp-cvs on mingw, where SPVW_VERSION is empty (see line makemake.in:1613)

--- makemake.in
+++ makemake.in
@@ -2656,7 +2656,7 @@
dependsc=$dependsc' '$g'.c'
done
dependsc=$dependsc''$EVERY_INCLUDES_H
- if [ $f = spvw -a -n ${SPVW_VERSION} ] ; then
+ if [ $f = spvw -a -n "${SPVW_VERSION}" ] ; then
dependsc=$dependsc' '${SPVW_VERSION}
fi
if [ $f = encoding ] ; then

Discussion

  • Sam Steingold

    Sam Steingold - 2008-04-02

    Logged In: YES
    user_id=5735
    Originator: NO

    thank you for your bug report.
    the bug has been fixed in the CVS tree.
    you can either wait for the next release (recommended)
    or check out the current CVS tree (see http://clisp.cons.org\)
    and build CLISP from the sources (be advised that between
    releases the CVS tree is very unstable and may not even build
    on your platform).

     
  • Sam Steingold

    Sam Steingold - 2008-04-02
    • assigned_to: haible --> sds
    • summary: fix for makemake.in --> quote arguments of "test -n"
    • status: open --> closed-fixed
     

Log in to post a comment.