Menu ▾ ▴

#639 STM32 RTC init direct register access

2.6.9
closed
Giovanni Di Sirio
stm32 rtc (2)
Low
2.6.8
True
2015-09-20
2015-08-30
Ignacio García Pérez
No

Possibly pedantic, but once noticed, why not just report it.

The RTC driver initialization code sets RTCD1.id_rtc = RTC, and from there on it is supposed to access the RTC registers always via RTCD1.id_rtc. However, a few lines later it uses the RTC directly:

if (!(RTC->ISR & RTC_ISR_INITS)){

Trivial patch attached.

1 Attachments
stm32_rtc_fix_direct_access.patch

Discussion

  • Giovanni Di Sirio

    Giovanni Di Sirio - 2015-08-31
    • assigned_to: Giovanni Di Sirio
    • Fixed in Repository: False --> True
     

  • Giovanni Di Sirio

    Giovanni Di Sirio - 2015-09-20
    • status: open --> closed
     

Log in to post a comment.