Thread: Re: [Celestia-developers] [Celestia-cvs] SF.net SVN: celestia:[4611] trunk/celestia
Real-time 3D visualization of space
Status: Beta
Brought to you by:
cjlaurel
From: Steve P. <car...@ya...> - 2009-01-30 20:56:13
|
FYI, The last update to celestia.rc changed the file version from 1.6.0.0 to 1.5.0.0. Steve --- On Wed, 1/28/09, vin...@us... <vin...@us...> wrote: From: vin...@us... <vin...@us...> Subject: [Celestia-cvs] SF.net SVN: celestia:[4611] trunk/celestia To: cel...@li... Date: Wednesday, January 28, 2009, 9:42 AM Revision: 4611 http://celestia.svn.sourceforge.net/celestia/?rev=4611&view=rev Author: vincent_gian Date: 2009-01-28 14:42:56 +0000 (Wed, 28 Jan 2009) Log Message: ----------- Updated translations. Modified Paths: -------------- trunk/celestia/po/hu.po trunk/celestia/po/zh_CN.po trunk/celestia/po2/hu.po trunk/celestia/src/celestia/res/celestia.rc Added Paths: ----------- trunk/celestia/locale/COPYING_zh_CN trunk/celestia/locale/controls_zh_CN.txt trunk/celestia/locale/demo_zh_CN.cel trunk/celestia/locale/guide_zh_CN.cel trunk/celestia/locale/start_zh_CN.cel This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Celestia-cvs mailing list Cel...@li... https://lists.sourceforge.net/lists/listinfo/celestia-cvs |
From: Pat S. <pa...@su...> - 2011-03-07 23:29:46
|
The reason I didn't commit this earlier is that I didn't like the way the DEFS line was handled. "@DEFS@" is not appropriate for Makefile.am. I have corrected it. Still, I feel that it would be more correct for it to include config.h when available. This has all of the variable definitions required, and will cause a rebuild as needed when one of them changes, without the need for "make clean". But I can't think of a nice way of doing that so that it works with both QMake (which doesn't generate config.h) and autotools. --Pat On 11-03-07 04:18 PM, ajt...@us... wrote: > Revision: 5142 > http://celestia.svn.sourceforge.net/celestia/?rev=5142&view=rev > Author: ajtribick > Date: 2011-03-07 21:18:22 +0000 (Mon, 07 Mar 2011) > > Log Message: > ----------- > Committed Nils Larsson's patch to enable Qt version to be executed from outside the source directory, added to list of contributors. > > Modified Paths: > -------------- > trunk/celestia/README > trunk/celestia/src/celestia/qt/Makefile.am > trunk/celestia/src/celestia/qt/qtappwin.cpp > > > This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. > > ------------------------------------------------------------------------------ > What You Don't Know About Data Connectivity CAN Hurt You > This paper provides an overview of data connectivity, details > its effect on application quality, and explores various alternative > solutions. http://p.sf.net/sfu/progress-d2d > _______________________________________________ > Celestia-cvs mailing list > Cel...@li... > https://lists.sourceforge.net/lists/listinfo/celestia-cvs |
From: Nils L. <nis...@ho...> - 2011-03-07 23:41:49
|
tisdagen den 8 mars 2011 00.29.39 skrev Pat Suwalski: > The reason I didn't commit this earlier is that I didn't like the way > the DEFS line was handled. "@DEFS@" is not appropriate for Makefile.am. Ah! Be not surprised, I am in no way an autotools expert. |
From: Andrew T. <ajt...@go...> - 2011-03-07 23:43:38
|
It's also used in several of the other Makefile.am files we've got lurking around the trunk. So at least its consistently inappropriate ;-) On 8 March 2011 00:40, Nils Larsson <nis...@ho...> wrote: > tisdagen den 8 mars 2011 00.29.39 skrev Pat Suwalski: >> The reason I didn't commit this earlier is that I didn't like the way >> the DEFS line was handled. "@DEFS@" is not appropriate for Makefile.am. > > Ah! Be not surprised, I am in no way an autotools expert. > > ------------------------------------------------------------------------------ > What You Don't Know About Data Connectivity CAN Hurt You > This paper provides an overview of data connectivity, details > its effect on application quality, and explores various alternative > solutions. http://p.sf.net/sfu/progress-d2d > _______________________________________________ > Celestia-developers mailing list > Cel...@li... > https://lists.sourceforge.net/lists/listinfo/celestia-developers > |
From: Pat S. <pa...@su...> - 2011-03-07 23:48:35
|
On 11-03-07 06:43 PM, Andrew Tribick wrote: > It's also used in several of the other Makefile.am files we've got > lurking around the trunk. So at least its consistently inappropriate > ;-) You're right. I guess it's not the worst thing in the world, it's just that automake puts those into the Makefile.in's that it generates. So, it's stylistically wrong. I'll fix up trunk with these, but I'll leave 1.6.1 as it is. --Pat |
From: Pat S. <pa...@su...> - 2011-03-07 23:50:52
|
On 11-03-07 06:48 PM, Pat Suwalski wrote: > I'll fix up trunk with these, but I'll leave 1.6.1 as it is. Or I would, but SVN isn't letting me commit... --Pat |
From: Andrew T. <ajt...@go...> - 2011-03-09 17:41:33
|
Well judging by http://www.shatters.net/forum/viewtopic.php?f=3&t=16370 this patch seems to have broken the Qt build for just about everyone, so I guess we should back it out for now. Andrew On 8 March 2011 00:50, Pat Suwalski <pa...@su...> wrote: > On 11-03-07 06:48 PM, Pat Suwalski wrote: >> I'll fix up trunk with these, but I'll leave 1.6.1 as it is. > > Or I would, but SVN isn't letting me commit... > > --Pat > > ------------------------------------------------------------------------------ > What You Don't Know About Data Connectivity CAN Hurt You > This paper provides an overview of data connectivity, details > its effect on application quality, and explores various alternative > solutions. http://p.sf.net/sfu/progress-d2d > _______________________________________________ > Celestia-developers mailing list > Cel...@li... > https://lists.sourceforge.net/lists/listinfo/celestia-developers > |
From: Nils L. <nis...@ho...> - 2011-03-09 19:56:15
|
onsdagen den 9 mars 2011 18.41.27 skrev Andrew Tribick: > Well judging by > http://www.shatters.net/forum/viewtopic.php?f=3&t=16370 this patch > seems to have broken the Qt build for just about everyone, so I guess > we should back it out for now. > > Andrew Common factor there appears to be qmake, which I didn't provide any patch for. I test with autotools and cmake(writen a little CMakeLists.txt) These build systems are always tedious and time consuming to manage. As someone very new to the celestia code base I have to ask: Could be please pick one and stick to it? Personally I prefer Cmake. It cross-plaftorm(only tried it on linux thou) and it works with qt-creator(IDE of choice?) |
From: Pat S. <pa...@su...> - 2011-03-09 20:24:50
|
On 09/03/11 02:54 PM, Nils Larsson wrote: > Common factor there appears to be qmake, which I didn't provide any patch for. > I test with autotools and cmake(writen a little CMakeLists.txt) So this has nothing to do with the Makefile change. And the code change is correct as well, it's the very lacking QMake project that needs updating to include the data directory definition. This tends to be a problem with QMake, in every project. It's not well structured to follow the FHS layout at all. However, the change in the code was needed one way or another. The QMake fix will eventually look like this: DEFINES += foo.path But none of the path information is set properly at the moment. I just committed a tiny patch that sets CONFIG_DATA_DIR to "./" if it's not set elsewhere. That will solve the issue for now. > These build systems are always tedious and time consuming to manage. As > someone very new to the celestia code base I have to ask: Could be please pick > one and stick to it? There has always been autotools and the MS project. I see this shifting to autotools and qmake. > Personally I prefer Cmake. It cross-plaftorm(only tried it on linux thou) and > it works with qt-creator(IDE of choice?) CMake is terrible. It solved none of the problems that it set out to solve that really gives it a leg up. In the meantime, it requires an external dependency, people are writing M4 macro wrappers for it, compiler features are a joke, and it has an annoying mechanism for getting at advanced features. None of the other alternatives have a proper way of generating releases; that includes error checking, setting of permissions, etc. The lack of 'distcheck' and 'dist' targets are why CMake isn't catching on like one might expect. --Pat |
From: vincent <vin...@fr...> - 2009-01-30 22:46:16
|
Steve, I just fixed this, thanks. The version of celestia.rc I commited allows longer strings to fit into the View Options menu. This was needed for some translations. For some reason, it didn't include the version number change. Vincent Selon Steve Popovich <car...@ya...>: > FYI, > The last update to celestia.rc changed the file version from 1.6.0.0 to 1.5.0.0. > Steve > > --- On Wed, 1/28/09, vin...@us... <vin...@us...> > wrote: > From: vin...@us... <vin...@us...> > Subject: [Celestia-cvs] SF.net SVN: celestia:[4611] trunk/celestia > To: cel...@li... > Date: Wednesday, January 28, 2009, 9:42 AM > > Revision: 4611 > http://celestia.svn.sourceforge.net/celestia/?rev=4611&view=rev > Author: vincent_gian > Date: 2009-01-28 14:42:56 +0000 (Wed, 28 Jan 2009) > > Log Message: > ----------- > Updated translations. > > Modified Paths: > -------------- > trunk/celestia/po/hu.po > trunk/celestia/po/zh_CN.po > trunk/celestia/po2/hu.po > trunk/celestia/src/celestia/res/celestia.rc > > Added Paths: > ----------- > trunk/celestia/locale/COPYING_zh_CN > trunk/celestia/locale/controls_zh_CN.txt > trunk/celestia/locale/demo_zh_CN.cel > trunk/celestia/locale/guide_zh_CN.cel > trunk/celestia/locale/start_zh_CN.cel > |