Thread: RE: [CEDET-devel] problems with current CVS-content of cedet!!
Brought to you by:
zappo
From: <kla...@sd...> - 2006-05-19 07:31:13
|
Hi David, i would assume that your new version would work because now the "out" = variable is set. But i still wonder if this is the right version because the argument = FORMATTER is not used. In the beta3-version it is used?! Klaus David Ponce wrote: > Hi Klaus, >=20 > [...] >> This is the code of semantic--format-tag-arguments contained in >> beta3 (which is working)=20 >>=20 >> (defun semantic--format-tag-arguments (args formatter color) >> "Format the argument list ARGS with FORMATTER. >> FORMATTER is a function used to format a tag. >> COLOR specifies if color should be used." >> (let ((out nil)) >> (while args >> (cond ((stringp (car args)) >> (let ((a (car args))) >> (if color >> (setq a (semantic--format-colorize-text a 'variable))) >> (setq out (cons a out)) >> )) >> ((semantic-tag-p (car args)) >> (setq out >> (cons (funcall formatter (car args) nil color) out)))) >> (setq args (cdr args))) >> (mapconcat 'identity (nreverse out) >> semantic-function-argument-separator) >> )) >>=20 >> This is the code i got aftre checking out cedet again - s.a.: . >> which is not working:=20 >>=20 >> (defun semantic--format-tag-arguments (args formatter color) >> "Format the argument list ARGS with FORMATTER. >> FORMATTER is a function used to format a tag. >> COLOR specifies if color should be used." >> (let ((out nil)) >> (while args >> (semantic-format-tag-name-from-anything (car args) nil color >> 'variable) (setq args (cdr args))) >> (mapconcat 'identity (nreverse out) >> semantic-function-argument-separator) >> )) >>=20 >> which is obviously a non working version of this function......for me >> this seems to be uch older than the version contained in beta3 of >> cedet but how can this be when i check out a new working dir of >> current cedet-CVS??? > [...] >=20 > The version you checked out is the good one (1.20). Unfortunately, I > don't remember why Eric did these changes since: >=20 > revision 1.19 > date: 2005/09/01 00:10:32; author: zappo; state: Exp; lines: +81 > -18 (semantic-format-tag-functions): Add > semantic-format-tag-canonical-name. > (semantic-format-parent-separator): New option. > (semantic--format-tag-arguments): Use below fcn > (semantic-format-tag-name-from-anything): New function (from above) > (semantic--format-tag-parent-tree): New unfinished function. > (semantic-format-tag-canonical-name): New overload function. > (semantic-format-tag-abbreviate-default): Use above.=20 >=20 > Anyway you're right the code doesn't look good. > Please, could you try this version, and tell me if it works > (untested):=20 >=20 > (defun semantic--format-tag-arguments (args formatter color) > "Format the argument list ARGS with FORMATTER. > FORMATTER is a function used to format a tag. > COLOR specifies if color should be used." > (let ((out nil)) > (while args > (push (semantic-format-tag-name-from-anything > (car args) nil color 'variable) out) > (setq args (cdr args))) > (mapconcat 'identity (nreverse out) > semantic-function-argument-separator) )) >=20 >=20 > David >=20 >=20 >=20 > ------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, > security?=20 > Get stuff done quickly with pre-integrated technology to make your > job easier Download IBM WebSphere Application Server v.1.0.1 based on > Apache Geronimo > = http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D= 121642 > _______________________________________________=20 > Cedet-devel mailing list > Ced...@li... > https://lists.sourceforge.net/lists/listinfo/cedet-devel |
From: <kla...@sd...> - 2006-05-19 07:35:42
|
Now tested, it works...but nevertheless see my recent posting concerning = this topic... Ciao Klaus kla...@sd... wrote: > Hi David, >=20 > i would assume that your new version would work because now the "out" > variable is set.=20 > But i still wonder if this is the right version because the argument > FORMATTER is not used. In the beta3-version it is used?! >=20 > Klaus >=20 > David Ponce wrote: >> Hi Klaus, >>=20 >> [...] >>> This is the code of semantic--format-tag-arguments contained in >>> beta3 (which is working)=20 >>>=20 >>> (defun semantic--format-tag-arguments (args formatter color) >>> "Format the argument list ARGS with FORMATTER. >>> FORMATTER is a function used to format a tag. >>> COLOR specifies if color should be used." >>> (let ((out nil)) >>> (while args >>> (cond ((stringp (car args)) >>> (let ((a (car args))) >>> (if color >>> (setq a (semantic--format-colorize-text a 'variable))) >>> (setq out (cons a out)) >>> )) >>> ((semantic-tag-p (car args)) >>> (setq out >>> (cons (funcall formatter (car args) nil color) out)))) =20 >>> (setq args (cdr args))) (mapconcat 'identity (nreverse out) >>> semantic-function-argument-separator) >>> )) >>>=20 >>> This is the code i got aftre checking out cedet again - s.a.: . >>> which is not working:=20 >>>=20 >>> (defun semantic--format-tag-arguments (args formatter color) >>> "Format the argument list ARGS with FORMATTER. >>> FORMATTER is a function used to format a tag. >>> COLOR specifies if color should be used." >>> (let ((out nil)) >>> (while args >>> (semantic-format-tag-name-from-anything (car args) nil color >>> 'variable) (setq args (cdr args))) >>> (mapconcat 'identity (nreverse out) >>> semantic-function-argument-separator) >>> )) >>>=20 >>> which is obviously a non working version of this function......for >>> me this seems to be uch older than the version contained in beta3 of >>> cedet but how can this be when i check out a new working dir of >>> current cedet-CVS??? >> [...] >>=20 >> The version you checked out is the good one (1.20). Unfortunately, I >> don't remember why Eric did these changes since: >>=20 >> revision 1.19 >> date: 2005/09/01 00:10:32; author: zappo; state: Exp; lines: +81 >> -18 (semantic-format-tag-functions): Add >> semantic-format-tag-canonical-name. >> (semantic-format-parent-separator): New option. >> (semantic--format-tag-arguments): Use below fcn >> (semantic-format-tag-name-from-anything): New function (from above) >> (semantic--format-tag-parent-tree): New unfinished function. >> (semantic-format-tag-canonical-name): New overload function. >> (semantic-format-tag-abbreviate-default): Use above. >>=20 >> Anyway you're right the code doesn't look good. >> Please, could you try this version, and tell me if it works >> (untested):=20 >>=20 >> (defun semantic--format-tag-arguments (args formatter color) >> "Format the argument list ARGS with FORMATTER. >> FORMATTER is a function used to format a tag. >> COLOR specifies if color should be used." >> (let ((out nil)) >> (while args >> (push (semantic-format-tag-name-from-anything >> (car args) nil color 'variable) out) >> (setq args (cdr args))) >> (mapconcat 'identity (nreverse out) >> semantic-function-argument-separator) )) >>=20 >>=20 >> David >>=20 >>=20 >>=20 >> ------------------------------------------------------- >> Using Tomcat but need to do more? Need to support web services, >> security? Get stuff done quickly with pre-integrated technology to >> make your job easier Download IBM WebSphere Application Server >> v.1.0.1 based on Apache Geronimo >> = http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D= 121642 >> _______________________________________________=20 >> Cedet-devel mailing list >> Ced...@li... >> https://lists.sourceforge.net/lists/listinfo/cedet-devel >=20 >=20 > ------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, > security?=20 > Get stuff done quickly with pre-integrated technology to make your > job easier=20 > Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > http://sel.as-us.falkag.net/sel?cmd=3Dk&kid=120709&bid&3057&dat=121642 > _______________________________________________=20 > Cedet-devel mailing list > Ced...@li... > https://lists.sourceforge.net/lists/listinfo/cedet-devel |
From: David P. <dav...@wa...> - 2006-05-19 10:24:33
|
Hi Klaus, > Now tested, it works...but nevertheless see my recent posting concerning this topic... OK, I committed the fix. [...] >> But i still wonder if this is the right version because the argument >> FORMATTER is not used. In the beta3-version it is used?! [...] That's right. I suppose that Eric did that for a good reason. I don't remember. So I would let him explain, before to go further. Thanks for testing. David |
From: <kla...@sd...> - 2006-05-19 10:30:34
|
Thanks to you!=B0 Klaus David PONCE wrote: > Hi Klaus, >=20 >> Now tested, it works...but nevertheless see my recent posting >> concerning this topic...=20 >=20 > OK, I committed the fix. >=20 > [...] >>> But i still wonder if this is the right version because the argument >>> FORMATTER is not used. In the beta3-version it is used?! [...] >=20 > That's right. I suppose that Eric did that for a good reason. > I don't remember. So I would let him explain, before to go further. >=20 > Thanks for testing. >=20 > David |