Thread: [CEDET-devel] [PATCH] semantic-goto-tag should unfold outlines
Brought to you by:
zappo
From: Oleh <ohw...@gm...> - 2014-02-23 10:57:57
|
Hi all, outline-minor-mode can hide tags. This patch will reveal the currently hidden tag in the same way as isearch does. In fact, the code is taken from isearch.el. regards, Oleh |
From: Oleh <ohw...@gm...> - 2014-02-23 10:58:32
|
Oops, forgot the patch :) On Sun, Feb 23, 2014 at 11:57 AM, Oleh <ohw...@gm...> wrote: > Hi all, > > outline-minor-mode can hide tags. > This patch will reveal the currently hidden tag in the same > way as isearch does. In fact, the code is taken from isearch.el. > > regards, > Oleh |
From: Eric M. L. <er...@si...> - 2014-02-26 01:26:28
|
On 02/23/2014 05:58 AM, Oleh wrote: > Oops, forgot the patch :) > > On Sun, Feb 23, 2014 at 11:57 AM, Oleh<ohw...@gm...> wrote: >> Hi all, >> >> outline-minor-mode can hide tags. >> This patch will reveal the currently hidden tag in the same >> way as isearch does. In fact, the code is taken from isearch.el. Hi Oleh, Thanks for the patch. I am surprised there is no generic function for making sure point's area becomes visible. Should this also put invisible back later? Unfortunately, semantic-go-to-tag is used by lots of functions that do not leave the cursor at the tag, such as semantic-documentation-for-tag, and cogre-refresh-tag. I suspect this needs to be applied to semantic-ia--fast-jump-helper, and a few other key places where users interactively jump to a location. Perhaps it could be part of 'pulse' which I think is called universally that way. What functions do you use that need this behavior? Thanks Eric |
From: Oleh <ohw...@gm...> - 2014-02-26 08:04:40
|
Hi Eric, >>> Hi all, >>> >>> outline-minor-mode can hide tags. >>> This patch will reveal the currently hidden tag in the same >>> way as isearch does. In fact, the code is taken from isearch.el. > > > Hi Oleh, > > Thanks for the patch. > > I am surprised there is no generic function for making sure point's area > becomes visible. Should this also put invisible back later? Actually I've found out yesterday that there is one called `reveal-mode`. But if I didn't know about it for years, it's likely that many other people don't as well. The point should not be put invisible later in the same way that isearch doesn't do so. After all, it's just outlines: the user can re-hide them easily again. > Unfortunately, semantic-go-to-tag is used by lots of functions that do not > leave the cursor at the tag, such as semantic-documentation-for-tag, and > cogre-refresh-tag. > > I suspect this needs to be applied to semantic-ia--fast-jump-helper, and a > few other key places where users interactively jump to a location. Perhaps > it could be part of 'pulse' which I think is called universally that way. Yes, maybe `called-interactively-p` should be added. > What functions do you use that need this behavior? Actually, just `semantic-go-to-tag` so far. Have a look at this video: https://vimeo.com/86768594 to see how I've combined semanticdb and helm. There's actually a series of videos there, including one for Common Lisp and one for Clojure. Are you in contact with the author of https://github.com/kototama/clojure-semantic ? I'd be happy to see it as part of CEDET. regards, Oleh |
From: Eric M. L. <er...@si...> - 2014-02-26 12:50:28
|
On 02/26/2014 03:04 AM, Oleh wrote: > Hi Eric, > >>>> Hi all, >>>> >>>> outline-minor-mode can hide tags. >>>> This patch will reveal the currently hidden tag in the same >>>> way as isearch does. In fact, the code is taken from isearch.el. >> >> >> Hi Oleh, >> >> Thanks for the patch. >> [...] >> Unfortunately, semantic-go-to-tag is used by lots of functions that do not >> leave the cursor at the tag, such as semantic-documentation-for-tag, and >> cogre-refresh-tag. >> >> I suspect this needs to be applied to semantic-ia--fast-jump-helper, and a >> few other key places where users interactively jump to a location. Perhaps >> it could be part of 'pulse' which I think is called universally that way. > > Yes, maybe `called-interactively-p` should be added. > semantic-go-to-tag is not an interactive function, so that will always return false. It is really the interactive function that moves point that needs to have this function. We could put in a recommendation for reveal-mode in the manual/setup so folks who use modes that hide things will get that benefit. >> What functions do you use that need this behavior? > > Actually, just `semantic-go-to-tag` so far. Have a look > at this video: https://vimeo.com/86768594 to see how I've combined > semanticdb and helm. > There's actually a series of videos there, including one for Common > Lisp and one for Clojure. That's pretty neat. I'm glad Semantic is able to help make those features work. > Are you in contact with the author of > https://github.com/kototama/clojure-semantic ? > I'd be happy to see it as part of CEDET. Yes, he emailed to the semantic mailing list last year, and I think Alex Ott helped him out. He will need to sign papers with the FSF for us to adopt his code. I haven't heard from him since though. Eric |