Thread: [CEDET-devel] Making listing buffers (data-debug and symref) read-only
Brought to you by:
zappo
From: Daniel H. <da...@ha...> - 2012-04-21 00:10:13
|
I have a branch which makes these two buffers read-only, so they don't get junk written to them in the form of self-inserting keys. After a long fight with Bazaar, I have a branch here: lp:~haxney/+junk/listing-buffers-read-only Rather than using `toggle-read-only', which the documentation says is bad form in an elisp program, I used `buffer-read-only' and `inhibit-read-only' to achieve the desired effect. Also, I made sure the buffers do not show up as modified when sections are expanded and collapsed. |
From: Eric M. L. <eri...@gm...> - 2012-04-28 23:04:51
|
On 04/20/2012 07:02 PM, Daniel Hackney wrote: > I have a branch which makes these two buffers read-only, so they don't get junk > written to them in the form of self-inserting keys. After a long fight with > Bazaar, I have a branch here: > > lp:~haxney/+junk/listing-buffers-read-only > > Rather than using `toggle-read-only', which the documentation says is bad form > in an elisp program, I used `buffer-read-only' and `inhibit-read-only' to > achieve the desired effect. Also, I made sure the buffers do not show up as > modified when sections are expanded and collapsed. I like this idea based on your description, but don't know how to access the location you provided. If the patch is short (in terms of new code lines) we can include it, otherwise we may need a release from you for this work. Thanks Eric |
From: David E. <de...@ra...> - 2012-04-29 07:50:28
|
Eric M. Ludlam writes: > On 04/20/2012 07:02 PM, Daniel Hackney wrote: >> I have a branch which makes these two buffers read-only, so they don't get junk >> written to them in the form of self-inserting keys. After a long fight with >> Bazaar, I have a branch here: > >> >> lp:~haxney/+junk/listing-buffers-read-only >> >> Rather than using `toggle-read-only', which the documentation says is bad form >> in an elisp program, I used `buffer-read-only' and `inhibit-read-only' to >> achieve the desired effect. Also, I made sure the buffers do not show up as >> modified when sections are expanded and collapsed. > > I like this idea based on your description, but don't know how to access > the location you provided. Launchpad support is built into bzr. If you already have a CEDET repository with different branches (meaning ~/cedet/trunk, ~/cedet/newtrunk, etc.), enter the toplevel (~/cedet) and do: bzr branch lp:~haxney/+junk/listing-buffers-read-only Afterwards, you can merge that branch into one of your existing ones. -David |
From: Daniel H. <da...@ha...> - 2012-04-29 00:21:36
|
Eric M. Ludlam <eri...@gm...> wrote: > On 04/20/2012 07:02 PM, Daniel Hackney wrote: >> >> I have a branch which makes these two buffers read-only, so they >> don't get junk written to them in the form of self-inserting keys. >> After a long fight with Bazaar, I have a branch here: >> >> lp:~haxney/+junk/listing-buffers-read-only > > I like this idea based on your description, but don't know how to > access the location you provided. Sorry, Launchpad only showed me the "lp:" urls. After a little digging, you should be able to access it at: http://bazaar.launchpad.net/~haxney/%2Bjunk/listing-buffers-read-only/ > If the patch is short (in terms of new code lines) we can include it, > otherwise we may need a release from you for this work. I'll let you decide whether the patch crosses the "threshold of substantiality;" it consists of a ~200 line diff in which most of the changes are fairly mechanical additions of changing `inhibit-read-only' and `set-buffer-modified-p'. I have already signed papers with the FSF for committing to Emacs core, but I'd be happy to sign any other release you may need. -- Daniel M. Hackney |
From: Daniel H. <da...@ha...> - 2012-05-04 05:26:04
|
Eric M. Ludlam <eri...@gm...> wrote: > On 04/20/2012 07:02 PM, Daniel Hackney wrote: >> >> I have a branch which makes these two buffers read-only, so they don't get >> junk >> written to them in the form of self-inserting keys. After a long fight >> with >> Bazaar, I have a branch here: >> >> lp:~haxney/+junk/listing-buffers-read-only >> >> Rather than using `toggle-read-only', which the documentation says is bad >> form >> in an elisp program, I used `buffer-read-only' and `inhibit-read-only' to >> achieve the desired effect. Also, I made sure the buffers do not show up >> as >> modified when sections are expanded and collapsed. > > > I like this idea based on your description, but don't know how to access the > location you provided. If the patch is short (in terms of new code lines) > we can include it, otherwise we may need a release from you for this work. Any progress on this? Once again, the bzr URL is: http://bazaar.launchpad.net/~haxney/%2Bjunk/listing-buffers-read-only/ Consider this a friendly, gentle poke :) -- Daniel M. Hackney |
From: Eric L. <eri...@gm...> - 2012-05-04 11:02:44
|
On 05/04/2012 01:02 AM, Daniel Hackney wrote: > Eric M. Ludlam<eri...@gm...> wrote: >> On 04/20/2012 07:02 PM, Daniel Hackney wrote: >>> I have a branch which makes these two buffers read-only, so they don't get >>> junk >>> written to them in the form of self-inserting keys. After a long fight >>> with >>> Bazaar, I have a branch here: >>> >>> lp:~haxney/+junk/listing-buffers-read-only >>> >>> Rather than using `toggle-read-only', which the documentation says is bad >>> form >>> in an elisp program, I used `buffer-read-only' and `inhibit-read-only' to >>> achieve the desired effect. Also, I made sure the buffers do not show up >>> as >>> modified when sections are expanded and collapsed. >> >> I like this idea based on your description, but don't know how to access the >> location you provided. If the patch is short (in terms of new code lines) >> we can include it, otherwise we may need a release from you for this work. > Any progress on this? Once again, the bzr URL is: > > http://bazaar.launchpad.net/~haxney/%2Bjunk/listing-buffers-read-only/ > > Consider this a friendly, gentle poke :) I haven't gotten anywhere on pretty much anything in a few weeks as my hacking machine is currently in my livingroom as a mythtv experiment. Hacking code on the TV is kind of sucky, even if the couch is comfy. I'm hoping to remedy this soon, but it may be a couple weeks. Eric |
From: Eric M. L. <eri...@gm...> - 2012-06-04 02:04:27
|
>> I like this idea based on your description, but don't know how to access the >> location you provided. If the patch is short (in terms of new code lines) >> we can include it, otherwise we may need a release from you for this work. > > Any progress on this? Once again, the bzr URL is: > > http://bazaar.launchpad.net/~haxney/%2Bjunk/listing-buffers-read-only/ > > Consider this a friendly, gentle poke :) I finally got a chance to work through your patch. It appears that the changes you suggested to symref mode have already been made, though differently. I added in the suppressed keymap. I also found a way to apply your data-debug patches more easily, so I did that and checked it it. Your patch was against the previous file name scheme, and I have applied your patch against the latest bzr version, compatible with the Emacs names. Thanks! Eric |