Thread: [CEDET-devel] "ede-new in root directory" fix
Brought to you by:
zappo
From: Hannu K. <az...@ik...> - 2009-03-05 18:02:36
Attachments:
ede-parent-project-simple.diff
ede-parent-project.diff
|
-- Hannu |
From: Eric M. L. <er...@si...> - 2009-03-05 19:31:29
|
>>> Hannu Koivisto <az...@ik...> seems to think that: [ ... ] >I would like to verify if it is inteded that in the code below the >second attempt (ede-directory-get-open-project) overwrites ans even >if ans was set by the first attempt (ede-find-subproject-for-directory)? > >;; This lets us find a subproject under root based on updir. >(when root > (setq ans (ede-find-subproject-for-directory > root updir))) > >;; Try the all structure based search. >(setq ans (ede-directory-get-open-project updir)) Hi, I think you are right. This looks like an error when I was trying to optimize performance by reducing file-system hits. Both functions do similar things, so the second is a backup plan. I hope to integrate your patch soon. >If it is not intended, then you might want to take a look at the >second patch. It changes that behaviour and also changes the code >otherwise as well. Why? Nothing important, I just found the >function a bit hard to read so I thought I'd flex my Elisp muscles >and see if I can make it a bit more to my liking, which of course >may not be to your liking (for example that dangling close paren -- >not usually approved by Lisp programmers -- irritated my eye but >you seem to have them elsewhere as well so I suppose I shouldn't >have changed the style...) I don't understand the anti-dangling parens thing. I use them with the indenter in Emacs to debug structure issue. They also make it clear where to add a new line of code, if needed. I can't imagine hacking without them. If I'm not the one typing though, I don't really care. Thanks for your research! Eric -- Eric Ludlam: er...@si... Siege: www.siege-engine.com Emacs: http://cedet.sourceforge.net |
From: Eric M. L. <er...@si...> - 2009-03-06 00:14:31
|
>>> Hannu Koivisto <az...@ik...> seems to think that: >Greetings, > >In my continuing experiments with CEDET, I noticed that ede-new >fails if you call it in a buffer whose default-directory is the >root directory of a drive (on Windows but probably applies to / on >Unix as well). The first, minimal patch appears to fix the >problem. Hi, I checked in your second patch today. Thanks! Eric -- Eric Ludlam: er...@si... Siege: www.siege-engine.com Emacs: http://cedet.sourceforge.net |