Thread: Re: [CEDET-devel] Various Semantic updates
Brought to you by:
zappo
From: David P. <dav...@wa...> - 2005-01-13 08:45:10
|
Hi Eric, > I checked in a bunch of semantic changes I've had lying about for > the past few months. Here is a summary: [...] That's great! Thanks! Just a minor remark. I noticed that in some files, in the copyright notice, your changed the list of years by a range. As it seemed to me that it was not allowed I checked in the "Maintaining GNU software" manual which says: "Do not abbreviate the year list using a range; for instance, do not write `1996--1998'; instead, write `1996, 1997, 1998'." Maybe following that rule is important if you plan to include [parts of] CEDET in Emacs? I don't know. Anyway it is worth knowing it ;) David |
From: <kla...@sd...> - 2005-01-13 09:03:03
|
Hi, thanks for checking in these codes... Another remark: I have updated all sources but now defalias will no = being parsed - i thought after our discussion there was agreement how to = handle aliases.... have i misunderstood something or why defaliases are not = being parsed? Another remark: The defstruct parser still adds plain strings as = members. I thought david and Eric have basically agreed to used semantic-tags as = members or have i misunderstood something here too? Thanks, Klaus David PONCE wrote: > Hi Eric, >=20 >> I checked in a bunch of semantic changes I've had lying about for >> the past few months. Here is a summary: > [...] >=20 > That's great! Thanks! >=20 > Just a minor remark. I noticed that in some files, in the copyright > notice, your changed the list of years by a range. >=20 > As it seemed to me that it was not allowed I checked in the > "Maintaining GNU software" manual which says: >=20 > "Do not abbreviate the year list using a range; for instance, do not > write `1996--1998'; instead, write `1996, 1997, 1998'." >=20 > Maybe following that rule is important if you plan to include [parts > of] CEDET in Emacs? I don't know. Anyway it is worth knowing it ;) >=20 > David >=20 >=20 >=20 >=20 > ------------------------------------------------------- > The SF.Net email is sponsored by: Beat the post-holiday blues > Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. > It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt > _______________________________________________ > Cedet-devel mailing list > Ced...@li... > https://lists.sourceforge.net/lists/listinfo/cedet-devel |
From: Eric M. L. <er...@si...> - 2005-01-13 12:24:13
|
>>> <kla...@sd...> seems to think that: >Hi, > >thanks for checking in these codes... > >Another remark: I have updated all sources but now defalias will no being >parsed - i thought after our discussion there was agreement how to handle >aliases.... have i misunderstood something or why defaliases are not being parsed? > >Another remark: The defstruct parser still adds plain strings as members. >I thought david and Eric have basically agreed to used semantic-tags as members >or have i misunderstood something here too? [ ... ] I didn't work on those things. I was just trying to get some pending changes I had in. If I accidentally erased something, it was a mistake. Eric -- Eric Ludlam: za...@gn..., er...@si... Home: http://www.ludlam.net Siege: www.siege-engine.com Emacs: http://cedet.sourceforge.net GNU: www.gnu.org |
From: <kla...@sd...> - 2005-01-13 10:45:22
|
kla...@sd... wrote: > Hi, >=20 > thanks for checking in these codes... >=20 > Another remark: I have updated all sources but now defalias will no > being=20 > parsed - i thought after our discussion there was agreement how to > handle aliases.... have i misunderstood something or why defaliases > are not being parsed?=20 >=20 > Another remark: The defstruct parser still adds plain strings as > members.=20 > I thought david and Eric have basically agreed to used semantic-tags > as members or have i misunderstood something here too? Well, forget this... i have now modified ECB as follows: (defun ecb-children-tags (parent-tag) "Return a list of children-tags of PARENT-TAG. If a child is not a semantic-tag \(but a plain string) then it will be converted to a = positionless tag of class 'variable." (mapcar (function (lambda (c) (cond ((ecb--semantic-tag-p c) c) ((stringp c) (ecb--semantic-tag-new-variable c nil nil = nil)) (t (ecb-error "Tag with name %s contains = invalid childrens" (ecb--semantic-tag-name = parent-tag)))))) (ecb--semantic-tag-children-compatibility parent-tag ecb-show-only-positioned-tags))) This function ensures that ECB is always working with semantic-tags = regardless if a parser adds plain-strings as tag-members. If positionless tags = should be displayed is driven by the option ecb-show-only-positioned-tags. So there is no need for me to change any parser... Ciao, Klaus |
From: Eric M. L. <er...@si...> - 2005-01-13 12:32:12
|
>>> <kla...@sd...> seems to think that: >kla...@sd... wrote: >> Hi, >> >> thanks for checking in these codes... >> >> Another remark: I have updated all sources but now defalias will no >> being >> parsed - i thought after our discussion there was agreement how to >> handle aliases.... have i misunderstood something or why defaliases >> are not being parsed? >> >> Another remark: The defstruct parser still adds plain strings as >> members. >> I thought david and Eric have basically agreed to used semantic-tags >> as members or have i misunderstood something here too? > >Well, forget this... i have now modified ECB as follows: > >(defun ecb-children-tags (parent-tag) > "Return a list of children-tags of PARENT-TAG. If a child is not a >semantic-tag \(but a plain string) then it will be converted to a positionless >tag of class 'variable." > (mapcar (function (lambda (c) > (cond ((ecb--semantic-tag-p c) > c) > ((stringp c) > (ecb--semantic-tag-new-variable c nil nil nil)) > (t > (ecb-error "Tag with name %s contains invalid childrens" > (ecb--semantic-tag-name parent-tag)))))) > (ecb--semantic-tag-children-compatibility > parent-tag ecb-show-only-positioned-tags))) > >This function ensures that ECB is always working with semantic-tags regardless >if a parser adds plain-strings as tag-members. If positionless tags should be >displayed is driven by the option ecb-show-only-positioned-tags. > >So there is no need for me to change any parser... [ ... ] Hi Klaus, In addition to the current semantic 2.0 function `semantic-tag-components', there is also `semantic-tag-components-with-overlays' which will also strip out string return values. There is a semantic 1.4 equivalent also, though I don't recall the name. Eric -- Eric Ludlam: za...@gn..., er...@si... Home: http://www.ludlam.net Siege: www.siege-engine.com Emacs: http://cedet.sourceforge.net GNU: www.gnu.org |
From: Eric M. L. <er...@si...> - 2005-01-13 12:22:53
|
>>> David PONCE <dav...@wa...> seems to think that: >Hi Eric, > >> I checked in a bunch of semantic changes I've had lying about for >> the past few months. Here is a summary: >[...] > >That's great! Thanks! > >Just a minor remark. I noticed that in some files, in the copyright >notice, your changed the list of years by a range. > >As it seemed to me that it was not allowed I checked in the >"Maintaining GNU software" manual which says: > >"Do not abbreviate the year list using a range; for instance, do not >write `1996--1998'; instead, write `1996, 1997, 1998'." > >Maybe following that rule is important if you plan to include [parts >of] CEDET in Emacs? I don't know. Anyway it is worth knowing it ;) [ ... ] Hmmm, interesting. I'll have to put them back. My name scrolled off the right side of the buffer on one, so I just started shortening them. Eric -- Eric Ludlam: za...@gn..., er...@si... Home: http://www.ludlam.net Siege: www.siege-engine.com Emacs: http://cedet.sourceforge.net GNU: www.gnu.org |