Thread: [CEDET-devel] Bug in the VC-support of speedbar
Brought to you by:
zappo
From: Berndl, K. <kla...@sd...> - 2004-09-30 08:27:48
|
Hi Eric, i have found a small bug in speedbar which probably prevents = `speedbar-vc-directory-enable-hook' to work correct or to work at all. The line (run-hook-with-args ....)=20 must be (run-hook-with-arg-until-success ...) because the docstring of run-hook-with-args says "...it is the best to = to depend on the value returned by run-hook-with-args!..." Otherwise the result of speedbar-vc-check-dir-p is unpredictable for all = backends besides CVS, RCS and SCCS... Ciao, Klaus |
From: Eric M. L. <er...@si...> - 2004-10-02 17:41:02
|
>>> "Berndl, Klaus" <kla...@sd...> seems to think that: >Hi Eric, > >i have found a small bug in speedbar which probably prevents = >`speedbar-vc-directory-enable-hook' to work correct or to work at all. > >The line > >(run-hook-with-args ....)=20 > >must be > >(run-hook-with-arg-until-success ...) > >because the docstring of run-hook-with-args says "...it is the best to = >to depend on the value returned by run-hook-with-args!..." > >Otherwise the result of speedbar-vc-check-dir-p is unpredictable for all = >backends besides CVS, RCS and SCCS... [ ... ] Thanks! Could you check that in? Eric -- Eric Ludlam: za...@gn..., er...@si... Home: http://www.ludlam.net Siege: www.siege-engine.com Emacs: http://cedet.sourceforge.net GNU: www.gnu.org |