Menu ▾ ▴

#638 Hydrogen Place bug fix and tidy

Accepted
closed
nobody
sdg (1) hydrogen placer (1)
cdk-1.4.x
1
2013-06-08
2013-06-01
John May
No

Two commits, first resolves resolves /bugs/1269. The second tidys up the class and adds additional checks to prevent incorrect usage.

Discussion

  • John May

    John May - 2013-06-01
    • labels: --> sdg, hydrogen placer
     

  • John May

    John May - 2013-06-01

    Small correction.

     
    hydrogen-placer.patch

  • Egon Willighagen

    Egon Willighagen - 2013-06-08
    • status: open --> closed
    • Group: Needs_Review --> Accepted
     

  • Egon Willighagen

    Egon Willighagen - 2013-06-08

    Generally looks good and applied. For next time (or a follow up patch):

      • Copyright (C) 2003-2007 The Chemistry Development Kit (CDK) project
        +/* Copyright (C) 2003-2013 The Chemistry Development Kit (CDK) project

    -> Add yourself, even if no specific authors have been given before

     

  • Egon Willighagen

    Egon Willighagen - 2013-06-08

    Oh, and don't use nonotify things in the tests, because that makes porting to master hard.

     

  • John May

    John May - 2013-06-08

    No problem, I think it was probably because it was already used. Sorry.

     

Log in to post a comment.