#584 Second half of the group module/package

[gilleain maclean torrance]

There are 4 patch files in the zip, but the first three are minor additions and a bugfix to the existing partition class.

The large patch contains all the new classes, test cases, and additions to depends files. Test-module runs without errors or fails. These patches are also available from this branch https://github.com/gilleain/cdk/tree/group

Also, there is a post explaining a bit about the module on my blog, although I won't spam the link here.

[gilleain maclean torrance]

Argh. Dammit, yes : the whole point of the javadoc comment is that you can either call "class.getX(Y)" or "class.refine(Y); super.getX()" so that #getGroup should be a link to the superclass method.

Anyway, thanks for the reviews!

[gilleain maclean torrance]

Sorry, re-reading my last comment it may not have been clear. You are correct; it's my mistake. Could make a tiny patch for it.

[John May]

I don't think Egon has pulled it yet so I can just edit the commit... two seconds

[Egon Willighagen]

Can you double check? I pushed a few commits this morning? Does that affect what you updated?

[John May]

Yep, I saw you pulled the previous ones. This was for the two extra ones Gilleain added to correct javadoc links and data representation.

• https://github.com/johnmay/cdk/commit/779635e4b9ab4e2bc223b2c5b1a26ab6438201e8
• https://github.com/johnmay/cdk/commit/1403403ebfaa43e0ce42574f3e79d44a5dd6bb5a

Thanks,
J

[John May]

Okay done

[Egon Willighagen]

Applied and pushed.

Added a missing dep in test-group.libdepends.