From: Mark R. <ma...@eb...> - 2009-07-15 16:29:57
|
hi Egon/Arvid, I wanted to ask two things regarding the new controller/renderer as I'm trying to build the applet. (1) SwingMouseEventRelay has been changed in jcp-primary, it now just implements MouseMotionListener, MouseListener. But the RenderPanel assumes it also implements MouseWheelListener. Is there as reason why this has been removed? (2) The next method in the applet's RenderPanel fails: this.hub = new ControllerHub(controllerModel, renderer, chemModel, this, undoredohandler, new SwingUndoRedoFactory()); It's because renderer instantiates a Renderer which extends AtomContainerRenderer. But neither implements IRenderer, so the constructor ControllerHub fails. Could you fix that? I suppose it's a mistake. thanks, Mark |
From: Egon W. <ego...@gm...> - 2009-07-15 21:09:00
|
Hi Mark, On Wed, Jul 15, 2009 at 7:28 PM, Mark Rijnbeek<ma...@eb...> wrote: > (1) > SwingMouseEventRelay has been changed in jcp-primary, it now just > implements MouseMotionListener, MouseListener. > But the RenderPanel assumes it also implements MouseWheelListener. Is > there as reason why this has been removed? I have to take a deeper look at this... > (2) > The next method in the applet's RenderPanel fails: > this.hub = new ControllerHub(controllerModel, > renderer, > chemModel, > this, > undoredohandler, > new SwingUndoRedoFactory()); > > It's because renderer instantiates a Renderer which extends > AtomContainerRenderer. But neither implements IRenderer, so the > constructor ControllerHub fails. Ah, that's a mistake indeed. > Could you fix that? I suppose it's a mistake. Fixed in the 10-unsorted branch, which branches from 5-rendersvg, but the two patches there eventually will end up in renderbasic and renderextra. Egon -- Post-doc @ Uppsala University http://chem-bla-ics.blogspot.com/ |
From: Egon W. <ego...@gm...> - 2009-07-16 05:44:28
|
Hi Mark, On Wed, Jul 15, 2009 at 11:08 PM, Egon Willighagen<ego...@gm...> wrote: > On Wed, Jul 15, 2009 at 7:28 PM, Mark Rijnbeek<ma...@eb...> wrote: >> (1) >> SwingMouseEventRelay has been changed in jcp-primary, it now just >> implements MouseMotionListener, MouseListener. >> But the RenderPanel assumes it also implements MouseWheelListener. Is >> there as reason why this has been removed? > > I have to take a deeper look at this... I think I copied in the files from the wrong local folder, but now copied in the proper, latest version from the jchempaint-primary SVN branch and submitted this to the 10-other branch, which contains patches that will need to be integrated with the other branches at some point, requiring another rebase, which will change hashes, etc... I still get compile errors in the JChemPaint app project in Eclipse, but these are unrelated to renderer/controller changes, and due to the new JChemPaint Primary patches being based on 'master' instead of 'cdk-1.2.x'... Egon -- Post-doc @ Uppsala University http://chem-bla-ics.blogspot.com/ |
From: Mark R. <ma...@eb...> - 2009-07-16 11:07:05
|
> I think I copied in the files from the wrong local folder, but now > copied in the proper, latest version from the jchempaint-primary SVN > branch and submitted this to the 10-other branch, which contains > patches that will need to be integrated with the other branches at > some point, requiring another rebase, which will change hashes, etc... > > I still get compile errors in the JChemPaint app project in Eclipse, > but these are unrelated to renderer/controller changes, and due to the > new JChemPaint Primary patches being based on 'master' instead of > 'cdk-1.2.x'... > hi Egon, Thanks for the quick fix. Regarding compiling errors, I think there's only two issues now: - Applet class ConvertToRadicalAction Line: number = new LonePairElectronChecker().getImplicitLonePairCount(atom, relevantContainer); Method getImplicitLonePairCount no longer exists. Only methods related to saturation seem to be available. Do you know if this was done on purpose, or perhaps a similar - And then there is the controlawt module missing. Right now, the applet task "dist" fails because SwingMouseEventRelay is missing. This class is supposed to go into "controlawt", but then this module is nowhere mentioned in the lists in the build.xml? I don't see a controlawt.jar in dist/jar when I run ant dist-all for jchempaint-primary. cheers, Mark |
From: Egon W. <ego...@gm...> - 2009-07-17 13:02:04
|
On Thu, Jul 16, 2009 at 2:06 PM, Mark Rijnbeek<ma...@eb...> wrote: > And then there is the controlawt module missing. Right now, the applet > task "dist" fails because SwingMouseEventRelay is missing. > This class is supposed to go into "controlawt", but then this module is > nowhere mentioned in the lists in the build.xml? > I don't see a controlawt.jar in dist/jar when I run ant dist-all for > jchempaint-primary. OK, fixing this. Apologies for having missed this earlier. Egon -- Post-doc @ Uppsala University http://chem-bla-ics.blogspot.com/ |
From: Egon W. <ego...@gm...> - 2009-07-17 15:10:17
|
Hi Mark, On Fri, Jul 17, 2009 at 3:01 PM, Egon Willighagen<ego...@gm...> wrote: >> I don't see a controlawt.jar in dist/jar when I run ant dist-all for >> jchempaint-primary. > > OK, fixing this. Apologies for having missed this earlier. Now uploaded. You'll need to updated the branches 10-unsorted and the new 11-controlawt. The 10-unsorted now branches from 11-controlawt. Egon -- Post-doc @ Uppsala University http://chem-bla-ics.blogspot.com/ |
From: Mark R. <ma...@eb...> - 2009-07-17 16:06:05
|
> Now uploaded. > > You'll need to updated the branches 10-unsorted and the new > 11-controlawt. The 10-unsorted now branches from 11-controlawt. > > Egon > > Thanks for the fix ! |
From: Egon W. <ego...@gm...> - 2009-07-15 21:21:30
|
On Wed, Jul 15, 2009 at 11:08 PM, Egon Willighagen<ego...@gm...> wrote: > On Wed, Jul 15, 2009 at 7:28 PM, Mark Rijnbeek<ma...@eb...> wrote: >> (1) >> SwingMouseEventRelay has been changed in jcp-primary, it now just >> implements MouseMotionListener, MouseListener. >> But the RenderPanel assumes it also implements MouseWheelListener. Is >> there as reason why this has been removed? > > I have to take a deeper look at this... If you have more information on this, that would help... it has changed... since what version? Did some patch not get ported from SVN to Git? That is, did the SVN jchempaint-primary branch have it implement MouseWheelListener? RenderPanel is in the JChemPaint project, correct? I will be offline tomorrow, but will try to compile the JChemPaint applet/application on Friday and see what goes wrong... Egon -- Post-doc @ Uppsala University http://chem-bla-ics.blogspot.com/ |
From: gilleain t. <gil...@gm...> - 2009-07-15 22:39:46
|
Hmmm. It was I who added the MouseWheelListener, but I thought it was done in both. RenderPanel is a swing-JCP class, yes. > If you have more information on this, that would help... it has > changed... since what version? Did some patch not get ported from SVN > to Git? That is, did the SVN jchempaint-primary branch have it > implement MouseWheelListener? RenderPanel is in the JChemPaint > project, correct? > > I will be offline tomorrow, but will try to compile the JChemPaint > applet/application on Friday and see what goes wrong... > |