From: SourceForge.net <no...@so...> - 2003-11-05 06:32:29
|
Bugs item #836296, was opened at 2003-11-05 14:32 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=120024&aid=836296&group_id=20024 Category: cdk-core module Group: None Status: Open Resolution: None Priority: 5 Submitted By: Chris Pudney (cpudney) Assigned to: Christoph Steinbeck (steinbeck) Summary: Minor fixes for lazyCreation patch Initial Comment: G'day, (For cdk20031017) When building with the lazyCreation patch the ChemObject.setProperties() method needs fixing as it doesn't call lazyProperties(). It should do something like the following: /** * Sets the properties of this object. */ public void setProperties(Hashtable properties) { Enumeration keys = properties.keys(); Hashtable p = lazyProperties(); while (keys.hasMoreElements()) { Object key = keys.nextElement(); p.put(key, properties.get(key)); } } Unit tests pass (except for the three that already fail) after this change. Regards, Chris. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=120024&aid=836296&group_id=20024 |
From: SourceForge.net <no...@so...> - 2003-12-07 16:59:55
|
Bugs item #836296, was opened at 2003-11-05 07:32 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=120024&aid=836296&group_id=20024 Category: cdk-core module Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Chris Pudney (cpudney) >Assigned to: Egon Willighagen (egonw) Summary: Minor fixes for lazyCreation patch Initial Comment: G'day, (For cdk20031017) When building with the lazyCreation patch the ChemObject.setProperties() method needs fixing as it doesn't call lazyProperties(). It should do something like the following: /** * Sets the properties of this object. */ public void setProperties(Hashtable properties) { Enumeration keys = properties.keys(); Hashtable p = lazyProperties(); while (keys.hasMoreElements()) { Object key = keys.nextElement(); p.put(key, properties.get(key)); } } Unit tests pass (except for the three that already fail) after this change. Regards, Chris. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2003-12-07 17:59 Message: Logged In: YES user_id=25678 Patch was not fully applied, and the method was therefor not added. (Patches are a bit tricky, and often fail after the original source file have been changed...). Fixed now. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=120024&aid=836296&group_id=20024 |