From: John M. <jo...@eb...> - 2013-05-17 09:03:33
|
Hi All, Hope every ones well. I was chatting someone the other day and they suggested an entire reformat (i.e. tidy) of the CDK code base. To my understanding the reason this would be bad would be it complicates git-blame however there would be great benefits. The two main benefits would be it looks better thus is easier to understand but it also decreases code ownership decreases. As every programmer has their own style it's possible to be possessive over code written and tell who wrote what (ignoring the copyright header). Although there would still be a style after formatting it would be greatly decreased and would install a sense of a collective code base. The formatting would of course be agreed on collectively. - git-blame has a -w flag which allows you ignore white space changes - most formatting can simply be ignored. - If the reformatting was done in one go when you hit a line that change it will always be the same commit id for git blame. - once the reformatting is done, add a formatter to the build so all future code is formatted before patch. There are plugins for ant and maven which would take an eclipse config file so the style could also be installed in the IDE. There is some real mess in there :/. Thoughts? J |
From: gilleain t. <gil...@gm...> - 2013-05-17 11:04:44
|
Hi, Yes please! Personally, I don't care what style is used, so long as it is consistent. Well, hopefully we won't use K&R style brackets, but... Some classes in the CDK have a really horrible style, and a global cleanup would go a long way towards making them readable enough to be bug fixed properly. gilleain On 5/17/13, John May <jo...@eb...> wrote: > Hi All, > > Hope every ones well. I was chatting someone the other day and they > suggested an entire reformat (i.e. tidy) of the CDK code base. To my > understanding the reason this would be bad would be it complicates git-blame > however there would be great benefits. The two main benefits would be it > looks better thus is easier to understand but it also decreases code > ownership decreases. As every programmer has their own style it's possible > to be possessive over code written and tell who wrote what (ignoring the > copyright header). Although there would still be a style after formatting it > would be greatly decreased and would install a sense of a collective code > base. The formatting would of course be agreed on collectively. > - git-blame has a -w flag which allows you ignore white space changes - > most formatting can simply be ignored. > - If the reformatting was done in one go when you hit a line that change it > will always be the same commit id for git blame. > - once the reformatting is done, add a formatter to the build so all future > code is formatted before patch. There are plugins for ant and maven which > would take an eclipse config file so the style could also be installed in > the IDE. > > There is some real mess in there :/. > > Thoughts? > > J > > |
From: Rajarshi G. <raj...@gm...> - 2013-05-17 12:00:19
|
Definitely support a reformat On Fri, May 17, 2013 at 5:03 AM, John May <jo...@eb...> wrote: > Hi All, > > Hope every ones well. I was chatting someone the other day and they > suggested an entire reformat (i.e. tidy) of the CDK code base. To my > understanding the reason this would be bad would be it complicates * > git-blame* however there would be great benefits. The two main benefits > would be it looks better thus is easier to understand but it also decreases > code ownership decreases. As every programmer has their own style it's > possible to be possessive over code written and tell who wrote what > (ignoring the copyright header). Although there would still be a *style* after > formatting it would be greatly decreased and would install a sense of a *collective > *code base. The formatting would of course be agreed on collectively. > * - git-blame* has a *-w* flag which allows you ignore white space > changes - most formatting can simply be ignored. > - If the reformatting was done in one go when you hit a line that change > it will always be the same commit id for git blame. > - once the reformatting is done, add a formatter to the build so all > future code is formatted before patch. There are plugins for ant and maven > which would take an eclipse config file so the style could also be > installed in the IDE. > > There is some real mess in there :/. > > Thoughts? > > J > > > > ------------------------------------------------------------------------------ > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily and > efficiently configure, manage, and operate all of your security controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d > _______________________________________________ > Cdk-devel mailing list > Cdk...@li... > https://lists.sourceforge.net/lists/listinfo/cdk-devel > > -- Rajarshi Guha | http://blog.rguha.net NIH Center for Advancing Translational Science |
From: Egon W. <ego...@gm...> - 2013-05-17 12:11:31
|
On Fri, May 17, 2013 at 11:03 AM, John May <jo...@eb...> wrote: > Hope every ones well. I was chatting someone the other day and they > suggested an entire reformat (i.e. tidy) of the CDK code base. No objections, because we will use my style, right? Egon -- Dr E.L. Willighagen Postdoctoral Researcher Department of Bioinformatics - BiGCaT Maastricht University (http://www.bigcat.unimaas.nl/) Homepage: http://egonw.github.com/ LinkedIn: http://se.linkedin.com/in/egonw Blog: http://chem-bla-ics.blogspot.com/ PubList: http://www.citeulike.org/user/egonw/tag/papers |
From: John M. <joh...@gm...> - 2013-05-17 12:25:15
|
Hehe - well we could always be democratic. Probably best bet is to just the conventions from sun/oracle when we can agree: http://www.oracle.com/technetwork/java/codeconventions-150003.pdf As with Gilleain I'm happy with anything as long as it's consistent. Even if it means I can't do my pretty one line if and for any more… but I always knew it is was naughty… :). J On 17 May 2013, at 13:11, Egon Willighagen <ego...@gm...> wrote: > On Fri, May 17, 2013 at 11:03 AM, John May <jo...@eb...> wrote: >> Hope every ones well. I was chatting someone the other day and they >> suggested an entire reformat (i.e. tidy) of the CDK code base. > > No objections, because we will use my style, right? > > Egon > > > -- > Dr E.L. Willighagen > Postdoctoral Researcher > Department of Bioinformatics - BiGCaT > Maastricht University (http://www.bigcat.unimaas.nl/) > Homepage: http://egonw.github.com/ > LinkedIn: http://se.linkedin.com/in/egonw > Blog: http://chem-bla-ics.blogspot.com/ > PubList: http://www.citeulike.org/user/egonw/tag/papers > > ------------------------------------------------------------------------------ > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily and > efficiently configure, manage, and operate all of your security controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d > _______________________________________________ > Cdk-devel mailing list > Cdk...@li... > https://lists.sourceforge.net/lists/listinfo/cdk-devel |
From: John M. <joh...@gm...> - 2013-05-17 12:25:39
|
*can't On 17 May 2013, at 13:25, John May <joh...@gm...> wrote: > Hehe - well we could always be democratic. > > Probably best bet is to just the conventions from sun/oracle when we can agree: http://www.oracle.com/technetwork/java/codeconventions-150003.pdf > > As with Gilleain I'm happy with anything as long as it's consistent. Even if it means I can't do my pretty one line if and for any more… but I always knew it is was naughty… :). > > J > > On 17 May 2013, at 13:11, Egon Willighagen <ego...@gm...> wrote: > >> On Fri, May 17, 2013 at 11:03 AM, John May <jo...@eb...> wrote: >>> Hope every ones well. I was chatting someone the other day and they >>> suggested an entire reformat (i.e. tidy) of the CDK code base. >> >> No objections, because we will use my style, right? >> >> Egon >> >> >> -- >> Dr E.L. Willighagen >> Postdoctoral Researcher >> Department of Bioinformatics - BiGCaT >> Maastricht University (http://www.bigcat.unimaas.nl/) >> Homepage: http://egonw.github.com/ >> LinkedIn: http://se.linkedin.com/in/egonw >> Blog: http://chem-bla-ics.blogspot.com/ >> PubList: http://www.citeulike.org/user/egonw/tag/papers >> >> ------------------------------------------------------------------------------ >> AlienVault Unified Security Management (USM) platform delivers complete >> security visibility with the essential security capabilities. Easily and >> efficiently configure, manage, and operate all of your security controls >> from a single console and one unified framework. Download a free trial. >> http://p.sf.net/sfu/alienvault_d2d >> _______________________________________________ >> Cdk-devel mailing list >> Cdk...@li... >> https://lists.sourceforge.net/lists/listinfo/cdk-devel > |
From: John M. <joh...@gm...> - 2013-05-17 12:27:07
|
Ergh, typing fail! Not with it today. > Hehe - well we could always be democratic. > > Probably best bet is to just the conventions from sun/oracle when we can't agree: http://www.oracle.com/technetwork/java/codeconventions-150003.pdf > > As with Gilleain I'm happy with anything as long as it's consistent. Even if it means I can't do my pretty one line if and for any more… but I always knew it was naughty… :). > > J On 17 May 2013, at 13:25, John May <joh...@gm...> wrote: > *can't > > On 17 May 2013, at 13:25, John May <joh...@gm...> wrote: > >> Hehe - well we could always be democratic. >> >> Probably best bet is to just the conventions from sun/oracle when we can agree: http://www.oracle.com/technetwork/java/codeconventions-150003.pdf >> >> As with Gilleain I'm happy with anything as long as it's consistent. Even if it means I can't do my pretty one line if and for any more… but I always knew it is was naughty… :). >> >> J >> >> On 17 May 2013, at 13:11, Egon Willighagen <ego...@gm...> wrote: >> >>> On Fri, May 17, 2013 at 11:03 AM, John May <jo...@eb...> wrote: >>>> Hope every ones well. I was chatting someone the other day and they >>>> suggested an entire reformat (i.e. tidy) of the CDK code base. >>> >>> No objections, because we will use my style, right? >>> >>> Egon >>> >>> >>> -- >>> Dr E.L. Willighagen >>> Postdoctoral Researcher >>> Department of Bioinformatics - BiGCaT >>> Maastricht University (http://www.bigcat.unimaas.nl/) >>> Homepage: http://egonw.github.com/ >>> LinkedIn: http://se.linkedin.com/in/egonw >>> Blog: http://chem-bla-ics.blogspot.com/ >>> PubList: http://www.citeulike.org/user/egonw/tag/papers >>> >>> ------------------------------------------------------------------------------ >>> AlienVault Unified Security Management (USM) platform delivers complete >>> security visibility with the essential security capabilities. Easily and >>> efficiently configure, manage, and operate all of your security controls >>> from a single console and one unified framework. Download a free trial. >>> http://p.sf.net/sfu/alienvault_d2d >>> _______________________________________________ >>> Cdk-devel mailing list >>> Cdk...@li... >>> https://lists.sourceforge.net/lists/listinfo/cdk-devel >> > |
From: Egon W. <ego...@gm...> - 2013-05-17 12:32:15
|
On Fri, May 17, 2013 at 2:25 PM, John May <joh...@gm...> wrote: > Hehe - well we could always be democratic. > > Probably best bet is to just the conventions from sun/oracle when we can > agree: http://www.oracle.com/technetwork/java/codeconventions-150003.pdf > > As with Gilleain I'm happy with anything as long as it's consistent. Even if > it means I can't do my pretty one line if and for any more… but I always > knew it is was naughty… :). I'm fine with most too... it's only line width that I feel strong about. My screens allow for up to 120 chars wide, but not more... this is the current CDK "standard"... having to scroll in two directions to read code really sucks... I do have a preference for this: if () { } rather than: if () { } But not even closely as strong on that.... Egon -- Dr E.L. Willighagen Postdoctoral Researcher Department of Bioinformatics - BiGCaT Maastricht University (http://www.bigcat.unimaas.nl/) Homepage: http://egonw.github.com/ LinkedIn: http://se.linkedin.com/in/egonw Blog: http://chem-bla-ics.blogspot.com/ PubList: http://www.citeulike.org/user/egonw/tag/papers |
From: John M. <joh...@gm...> - 2013-05-17 13:01:27
|
I was going to say those were the two most likely sticking points. I also prefer the 1TBS, there is no other :-). Line width will be fine - I actually have the marker at 80 chars, to remind me indenting too much => make a new method. If it was currently defined at 120 then it's left there. I'll make a draft config and send it round. J On 17 May 2013, at 13:31, Egon Willighagen <ego...@gm...> wrote: > On Fri, May 17, 2013 at 2:25 PM, John May <joh...@gm...> wrote: >> Hehe - well we could always be democratic. >> >> Probably best bet is to just the conventions from sun/oracle when we can >> agree: http://www.oracle.com/technetwork/java/codeconventions-150003.pdf >> >> As with Gilleain I'm happy with anything as long as it's consistent. Even if >> it means I can't do my pretty one line if and for any more… but I always >> knew it is was naughty… :). > > I'm fine with most too... it's only line width that I feel strong > about. My screens allow for up to 120 chars wide, but not more... this > is the current CDK "standard"... having to scroll in two directions to > read code really sucks... > > I do have a preference for this: > > if () { > } > > rather than: > > if () > { > } > > But not even closely as strong on that.... > > Egon > > -- > Dr E.L. Willighagen > Postdoctoral Researcher > Department of Bioinformatics - BiGCaT > Maastricht University (http://www.bigcat.unimaas.nl/) > Homepage: http://egonw.github.com/ > LinkedIn: http://se.linkedin.com/in/egonw > Blog: http://chem-bla-ics.blogspot.com/ > PubList: http://www.citeulike.org/user/egonw/tag/papers > > ------------------------------------------------------------------------------ > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily and > efficiently configure, manage, and operate all of your security controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d > _______________________________________________ > Cdk-devel mailing list > Cdk...@li... > https://lists.sourceforge.net/lists/listinfo/cdk-devel |
From: Egon W. <ego...@gm...> - 2013-05-17 13:04:48
|
On Fri, May 17, 2013 at 3:01 PM, John May <joh...@gm...> wrote: > I'll make a draft config and send it round. +1 Egon -- Dr E.L. Willighagen Postdoctoral Researcher Department of Bioinformatics - BiGCaT Maastricht University (http://www.bigcat.unimaas.nl/) Homepage: http://egonw.github.com/ LinkedIn: http://se.linkedin.com/in/egonw Blog: http://chem-bla-ics.blogspot.com/ PubList: http://www.citeulike.org/user/egonw/tag/papers |
From: John M. <joh...@gm...> - 2013-05-19 19:49:59
|
Okay, Done some research and unfortunately it's not as easy as you'd think. There is a couple of paid stand-alone products available but the primary open source (Jalopy) went commercial a couple of years ago. As much as I don't like eclipse the best bet seems to be to use it's formatter as a standalone. There are ant tasks which can do this and also a maven plugin. I'm not entirely sure how the ant task would work (as I don't use ant) but I guess it could pick up an environment variable. Perhaps it might be best just to do a reformat once instead of adding to the build cycle. With the provided config file you can format from the command line as follows > eclipse -nosplash -application org.eclipse.jdt.core.JavaCodeFormatter -config ~/workspace/github/johnmay/cdk/org.eclipse.jdt.core.prefs ~/workspace/github/johnmay/cdk/src/main/ Most of the changes were column alignment, but unfortunately it won't do everything. For example, I could not find a way to align arrays nicely. > new IAtom[]{ new Atom("H"), > new Atom("H"), > new Atom("O") }; Here is what I changed from the eclipse 'java conventions [built-in]'. > Indentation > + Tab policy: Spaces only > + Align fields to columns > + Indent, Spaces within 'case' body > > Blank Lines > + Before first declaration: 1 > > Line Wrapping > General Settings > + Line Wrapping: 100 > + Never join already wrapped lines > > Annotations > Element-value pairs > + Wrap all elements, except first element if not necessary > + Indent on column > > 'enum' declaration > Constants > + Wrap all elements, every element on a new line > > Function calls > Arguments > + Indent on column > Explicit constructor invocations > + Indent on column > Object allocation arguments > + Indent on column > Qualified object allocation arguments > + Indent on column > > Expression > Binary Expressions > + Indent on column > Conditionals > + Indent on column > Array init > + Indent on column > > Statements > Try-with-resources > + Indent on column > Multi-catch > + Indent on column > > Comments > + Remove blank lines (javadoc) > + Remove blank lines (block) |
From: gilleain t. <gil...@gm...> - 2013-05-20 11:53:29
|
The formatting choices look fine, although I should probably run it to really see, but never mind. Did you consider jacobe - it seems to have a free option, but with binaries only for win and Linux. Gilleain On Sunday, May 19, 2013, John May wrote: > Okay, > > Done some research and unfortunately it's not as easy as you'd think. > There is a couple of paid stand-alone products available but the primary > open source (Jalopy) went commercial a couple of years ago. As much as I > don't like eclipse the best bet seems to be to use it's formatter as a > standalone. There are ant tasks which can do this and also a maven plugin. > I'm not entirely sure how the ant task would work (as I don't use ant) but > I guess it could pick up an environment variable. Perhaps it might be best > just to do a reformat once instead of adding to the build cycle. > > With the provided config file you can format from the command line as > follows > > eclipse -nosplash -application *org.eclipse.jdt.core.JavaCodeFormatter*-config > *~/workspace/github/johnmay/cdk/org.eclipse.jdt.core.prefs* * > ~/workspace/github/johnmay/cdk/src/main/* > > > Most of the changes were column alignment, but unfortunately it won't do > everything. For example, I could not find a way to align arrays nicely. > > new IAtom[]{ new Atom("H"), > > new Atom("H"), > > new Atom("O") }; > > > Here is what I changed from the eclipse 'java conventions [built-in]'. > > Indentation > + Tab policy: Spaces only > + Align fields to columns > + Indent, Spaces within 'case' body > > Blank Lines > + Before first declaration: 1 > > Line Wrapping > General Settings > + Line Wrapping: 100 > + Never join already wrapped lines > > Annotations > Element-value pairs > + Wrap all elements, except first element if not necessary > + Indent on column > > 'enum' declaration > Constants > + Wrap all elements, every element on a new line > > Function calls > Arguments > + Indent on column > Explicit constructor invocations > + Indent on column > Object allocation arguments > + Indent on column > Qualified object allocation arguments > + Indent on column > > Expression > Binary Expressions > + Indent on column > Conditionals > + Indent on column > Array init > + Indent on column > > Statements > Try-with-resources > + Indent on column > Multi-catch > + Indent on column > > Comments > + Remove blank lines (javadoc) > + Remove blank lines (block) > > > |
From: John M. <joh...@gm...> - 2013-05-20 13:05:35
|
Yep, several posts pointed to it as a replacement for Jalopy. I tried running the unix version on OS X but couldn't get it to work :(. Jalopy might be an option but would only support code features up to 1.5. J On 20 May 2013, at 12:53, gilleain torrance <gil...@gm...> wrote: > The formatting choices look fine, although I should probably run it to really see, but never mind. > > Did you consider jacobe - it seems to have a free option, but with binaries only for win and Linux. > > Gilleain > > On Sunday, May 19, 2013, John May wrote: > Okay, > > Done some research and unfortunately it's not as easy as you'd think. There is a couple of paid stand-alone products available but the primary open source (Jalopy) went commercial a couple of years ago. As much as I don't like eclipse the best bet seems to be to use it's formatter as a standalone. There are ant tasks which can do this and also a maven plugin. I'm not entirely sure how the ant task would work (as I don't use ant) but I guess it could pick up an environment variable. Perhaps it might be best just to do a reformat once instead of adding to the build cycle. > > With the provided config file you can format from the command line as follows > >> eclipse -nosplash -application org.eclipse.jdt.core.JavaCodeFormatter -config ~/workspace/github/johnmay/cdk/org.eclipse.jdt.core.prefs ~/workspace/github/johnmay/cdk/src/main/ > > > Most of the changes were column alignment, but unfortunately it won't do everything. For example, I could not find a way to align arrays nicely. > >> new IAtom[]{ new Atom("H"), >> new Atom("H"), >> new Atom("O") }; > > > Here is what I changed from the eclipse 'java conventions [built-in]'. > >> Indentation >> + Tab policy: Spaces only >> + Align fields to columns >> + Indent, Spaces within 'case' body >> >> Blank Lines >> + Before first declaration: 1 >> >> Line Wrapping >> General Settings >> + Line Wrapping: 100 >> + Never join already wrapped lines >> >> Annotations >> Element-value pairs >> + Wrap all elements, except first element if not necessary >> + Indent on column >> >> 'enum' declaration >> Constants >> + Wrap all elements, every element on a new line >> >> Function calls >> Arguments >> + Indent on column >> Explicit constructor invocations >> + Indent on column >> Object allocation arguments >> + Indent on column >> Qualified object allocation arguments >> + Indent on column >> >> Expression >> Binary Expressions >> + Indent on column >> Conditionals >> + Indent on column >> Array init >> + Indent on column >> >> Statements >> Try-with-resources >> + Indent on column >> Multi-catch >> + Indent on column >> >> Comments >> + Remove blank lines (javadoc) >> + Remove blank lines (block) > > > ------------------------------------------------------------------------------ > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily and > efficiently configure, manage, and operate all of your security controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d_______________________________________________ > Cdk-devel mailing list > Cdk...@li... > https://lists.sourceforge.net/lists/listinfo/cdk-devel |
From: Till S. <til...@tu...> - 2013-05-17 14:45:37
Attachments:
signature.asc
|
Hi, we are maintaining a set of external performance patches for the CDK, which are used in our project Scaffold Hunter (scaffoldhunter.sourceforge.net). The patches were send to Egon a while ago, but not all are included right now (because of different reasons). A reformat will make it a lot more difficult to keep the patches up-to date. In general: A reformat will make it difficult to compare recent revisions with older ones. I am not a daily contributor of the CDK and therefore my word may not count that much, but i suggest to set up the formatter and only reformat that code that is changing anyway during modifications. This will lead to a cleaner code-style in the long term and avoids the above mentions problems. Best Regards Till Schäfer Am 17.05.2013 15:04, schrieb Egon Willighagen: > On Fri, May 17, 2013 at 3:01 PM, John May <joh...@gm...> wrote: >> I'll make a draft config and send it round. > > +1 > > Egon > > -- > Dr E.L. Willighagen > Postdoctoral Researcher > Department of Bioinformatics - BiGCaT > Maastricht University (http://www.bigcat.unimaas.nl/) > Homepage: http://egonw.github.com/ > LinkedIn: http://se.linkedin.com/in/egonw > Blog: http://chem-bla-ics.blogspot.com/ > PubList: http://www.citeulike.org/user/egonw/tag/papers > > ------------------------------------------------------------------------------ > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily and > efficiently configure, manage, and operate all of your security controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d > _______________________________________________ > Cdk-devel mailing list > Cdk...@li... > https://lists.sourceforge.net/lists/listinfo/cdk-devel > -- Dipl.-Inf. Till Schäfer Technische Universität Dortmund Chair 11 - Algorithm Engineering Otto-Hahn-Str. 14 44227 Dortmund, Germany e-mail: til...@cs... phone: +49(231)755-7706 fax: +49(231)755-7740 web: http://ls11-www.cs.uni-dortmund.de/staff/schaefer pgp: https://keyserver2.pgp.com/vkd/SubmitSearch.event?&&SearchCriteria=0xD84DED79 |
From: John M. <joh...@gm...> - 2013-06-09 12:44:43
|
Hi Till, Have you got these patches online somewhere? J On 17 May 2013, at 15:45, Till Schäfer <til...@tu...> wrote: > Hi, > we are maintaining a set of external performance patches for the CDK, which are used in our project Scaffold Hunter > (scaffoldhunter.sourceforge.net). The patches were send to Egon a while ago, but not all are included right now (because > of different reasons). A reformat will make it a lot more difficult to keep the patches up-to date. In general: A > reformat will make it difficult to compare recent revisions with older ones. > > I am not a daily contributor of the CDK and therefore my word may not count that much, but i suggest to set up the > formatter and only reformat that code that is changing anyway during modifications. This will lead to a cleaner > code-style in the long term and avoids the above mentions problems. > > Best Regards > Till Schäfer > > Am 17.05.2013 15:04, schrieb Egon Willighagen: >> On Fri, May 17, 2013 at 3:01 PM, John May <joh...@gm...> wrote: >>> I'll make a draft config and send it round. >> >> +1 >> >> Egon >> >> -- >> Dr E.L. Willighagen >> Postdoctoral Researcher >> Department of Bioinformatics - BiGCaT >> Maastricht University (http://www.bigcat.unimaas.nl/) >> Homepage: http://egonw.github.com/ >> LinkedIn: http://se.linkedin.com/in/egonw >> Blog: http://chem-bla-ics.blogspot.com/ >> PubList: http://www.citeulike.org/user/egonw/tag/papers >> >> ------------------------------------------------------------------------------ >> AlienVault Unified Security Management (USM) platform delivers complete >> security visibility with the essential security capabilities. Easily and >> efficiently configure, manage, and operate all of your security controls >> from a single console and one unified framework. Download a free trial. >> http://p.sf.net/sfu/alienvault_d2d >> _______________________________________________ >> Cdk-devel mailing list >> Cdk...@li... >> https://lists.sourceforge.net/lists/listinfo/cdk-devel >> > > -- > Dipl.-Inf. Till Schäfer > Technische Universität Dortmund > Chair 11 - Algorithm Engineering > Otto-Hahn-Str. 14 > 44227 Dortmund, Germany > > e-mail: til...@cs... > phone: +49(231)755-7706 > fax: +49(231)755-7740 > web: http://ls11-www.cs.uni-dortmund.de/staff/schaefer > pgp: https://keyserver2.pgp.com/vkd/SubmitSearch.event?&&SearchCriteria=0xD84DED79 > > ------------------------------------------------------------------------------ > How ServiceNow helps IT people transform IT departments: > 1. A cloud service to automate IT design, transition and operations > 2. Dashboards that offer high-level views of enterprise services > 3. A single system of record for all IT processes > http://p.sf.net/sfu/servicenow-d2d-j_______________________________________________ > Cdk-devel mailing list > Cdk...@li... > https://lists.sourceforge.net/lists/listinfo/cdk-devel |
From: Egon W. <ego...@gm...> - 2013-06-10 06:04:45
|
Dear Till, On Fri, May 17, 2013 at 4:45 PM, Till Schäfer <til...@tu...> wrote: > we are maintaining a set of external performance patches for the CDK, which are used in our project Scaffold Hunter > (scaffoldhunter.sourceforge.net). The patches were send to Egon a while ago, but not all are included right now (because > of different reasons). I am really sorry about this. All, the patches were send around to the cdk-devel@ lists at the time. > A reformat will make it a lot more difficult to keep the patches up-to date. In general: A > reformat will make it difficult to compare recent revisions with older ones. Agreed. > I am not a daily contributor of the CDK and therefore my word may not count that much, You speak up, and that's what counts to me. > but i suggest to set up the > formatter and only reformat that code that is changing anyway during modifications. This will lead to a cleaner > code-style in the long term and avoids the above mentions problems. Yes, that certainly makes sense, but for the sake of peer review, it is still important that the formatting itself happens in a different patch. Otherwise, it is practically impossible to efficiently review a code-changing patch, because you'd have no clue what really changed and what just was reformatted... Egon -- Dr E.L. Willighagen Postdoctoral Researcher Department of Bioinformatics - BiGCaT Maastricht University (http://www.bigcat.unimaas.nl/) Homepage: http://egonw.github.com/ LinkedIn: http://se.linkedin.com/in/egonw Blog: http://chem-bla-ics.blogspot.com/ PubList: http://www.citeulike.org/user/egonw/tag/papers |