From: Egon W. <eg...@us...> - 2006-02-09 12:10:52
|
Hi all, Just a reminder: please do run 'ant test-all' to make sure that your patch does not break anything. Now, it is somethimes difficult to decide wether you broke something new or not, because by default not all CDK JUnit tests succeed when calling 'ant test-all'... The IRC chat channel normall lists the number of know fails... However, when working on the Open Source JVM Test Suite, I realized that it would be handy to add a trigger that allows skipping these know fails. I've added a command line option for this: ant -DrunKnownBugs=false test-all CDKTestCase, which all CDK JUnit test cases must extend, now has a method: CDKTestCase.runKnownBugs() For example, as in: /** * @cdk.bug 1095690 */ public void testClone_Mapping() { if (runKnownBugs()) fail("Affected by bug #1095690"); } But, you may only use this method if: 1. the bug is reported CDK's bug track system on SourceForge 2. the test class test method mentions it in it's JavaDoc (as above) 3. the buggy class method mentions it in it's JavaDoc Egon -- eg...@us... Blog: http://chem-bla-ics.blogspot.com/ GPG: 1024D/D6336BA6 |
From: Egon W. <eg...@us...> - 2006-02-09 12:36:47
|
On Thursday 09 February 2006 13:10, Egon Willighagen wrote: > However, when working on the Open Source JVM Test Suite, I realized that it > would be handy to add a trigger that allows skipping these know fails. I've > added a command line option for this: > > ant -DrunKnownBugs=false test-all Forgot to mention this: adding this option does not remove all known failing test just now. I'm working on that, so hang on. It should work tomorrow. Egon -- eg...@us... Blog: http://chem-bla-ics.blogspot.com/ GPG: 1024D/D6336BA6 |