From: <eg...@us...> - 2008-06-29 20:16:52
|
Revision: 11461 http://cdk.svn.sourceforge.net/cdk/?rev=11461&view=rev Author: egonw Date: 2008-06-29 13:16:50 -0700 (Sun, 29 Jun 2008) Log Message: ----------- Fixed some PMD warnings Modified Paths: -------------- cdk/branches/egonw-diff/pmd.xml cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/BooleanArrayDifference.java cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/ChemObjectDifference.java cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/Point2dDifference.java cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/Point3dDifference.java Modified: cdk/branches/egonw-diff/pmd.xml =================================================================== --- cdk/branches/egonw-diff/pmd.xml 2008-06-29 19:56:29 UTC (rev 11460) +++ cdk/branches/egonw-diff/pmd.xml 2008-06-29 20:16:50 UTC (rev 11461) @@ -55,6 +55,7 @@ <antcall target="test-module"><param name="pmd.test" value="custom"/><param name="module" value="structgen"/></antcall> <antcall target="test-module"><param name="pmd.test" value="custom"/><param name="module" value="valencycheck"/></antcall> <antcall target="test-module"><param name="pmd.test" value="custom"/><param name="module" value="charges"/></antcall> + <antcall target="test-module"><param name="pmd.test" value="custom"/><param name="module" value="diff"/></antcall> <!-- the test modules --> <antcall target="test-module"><param name="pmd.test" value="custom-test"/><param name="module" value="test-core"/></antcall> <antcall target="test-module"><param name="pmd.test" value="custom-test"/><param name="module" value="test-data"/></antcall> @@ -76,6 +77,7 @@ <antcall target="test-module"><param name="pmd.test" value="custom-test"/><param name="module" value="test-qsarmolecular"/></antcall> <antcall target="test-module"><param name="pmd.test" value="custom-test"/><param name="module" value="test-qsarprotein"/></antcall> <antcall target="test-module"><param name="pmd.test" value="custom-test"/><param name="module" value="test-charges"/></antcall> + <antcall target="test-module"><param name="pmd.test" value="custom-test"/><param name="module" value="test-diff"/></antcall> </target> <target id="test-module" name="test-module" Modified: cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/BooleanArrayDifference.java =================================================================== --- cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/BooleanArrayDifference.java 2008-06-29 19:56:29 UTC (rev 11460) +++ cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/BooleanArrayDifference.java 2008-06-29 20:16:50 UTC (rev 11461) @@ -77,7 +77,7 @@ if (differences.size() == 0) return ""; StringBuffer diffBuffer = new StringBuffer(); - diffBuffer.append(this.name).append("{"); + diffBuffer.append(this.name).append('{'); Iterator<IDifference> children = getChildren(); while (children.hasNext()) { diffBuffer.append(children.next().toString()); @@ -85,7 +85,7 @@ diffBuffer.append(", "); } } - diffBuffer.append("}"); + diffBuffer.append('}'); return diffBuffer.toString(); } Modified: cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/ChemObjectDifference.java =================================================================== --- cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/ChemObjectDifference.java 2008-06-29 19:56:29 UTC (rev 11460) +++ cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/ChemObjectDifference.java 2008-06-29 20:16:50 UTC (rev 11461) @@ -46,7 +46,7 @@ if (differences.size() == 0) return ""; StringBuffer diffBuffer = new StringBuffer(); - diffBuffer.append(this.name).append("{"); + diffBuffer.append(this.name).append('{'); Iterator<IDifference> children = getChildren(); while (children.hasNext()) { diffBuffer.append(children.next().toString()); @@ -54,7 +54,7 @@ diffBuffer.append(", "); } } - diffBuffer.append("}"); + diffBuffer.append('}'); return diffBuffer.toString(); } Modified: cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/Point2dDifference.java =================================================================== --- cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/Point2dDifference.java 2008-06-29 19:56:29 UTC (rev 11460) +++ cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/Point2dDifference.java 2008-06-29 20:16:50 UTC (rev 11461) @@ -68,7 +68,7 @@ if (differences.size() == 0) return ""; StringBuffer diffBuffer = new StringBuffer(); - diffBuffer.append(this.name).append("{"); + diffBuffer.append(this.name).append('{'); Iterator<IDifference> children = getChildren(); while (children.hasNext()) { diffBuffer.append(children.next().toString()); @@ -76,7 +76,7 @@ diffBuffer.append(", "); } } - diffBuffer.append("}"); + diffBuffer.append('}'); return diffBuffer.toString(); } Modified: cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/Point3dDifference.java =================================================================== --- cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/Point3dDifference.java 2008-06-29 19:56:29 UTC (rev 11460) +++ cdk/branches/egonw-diff/src/main/org/openscience/cdk/tools/diff/tree/Point3dDifference.java 2008-06-29 20:16:50 UTC (rev 11461) @@ -73,7 +73,7 @@ if (differences.size() == 0) return ""; StringBuffer diffBuffer = new StringBuffer(); - diffBuffer.append(this.name).append("{"); + diffBuffer.append(this.name).append('{'); Iterator<IDifference> children = getChildren(); while (children.hasNext()) { diffBuffer.append(children.next().toString()); @@ -81,7 +81,7 @@ diffBuffer.append(", "); } } - diffBuffer.append("}"); + diffBuffer.append('}'); return diffBuffer.toString(); } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |