#48 dtmail does not build on FreeBSD 10.1-RELEASE

[Douglas Carmichael]

When I try to build CDE on FreeBSD 10.1-RELEASE, the build fails with dtmail:

~~~~~
c++ -c -O2 -fno-strict-aliasing -I. -I../../include -I../../include/utils -I../../../../lib -I/usr/local/include -I../../../.. -I../../../../exports/include -I../../../../imports/motif/include -I../../../../imports/x11/include -DCSRG_BASED -DANSICPP -DMULTIBYTE -DNLS16 -DOSMAJORVERSION=10 -DOSMINORVERSION=1 -DHAS_VFORK -DDL_NOT_DYNAMIC -DUSE_SOCKSTREAM Session.C

Session.C:1412:25: warning: conversion from string literal to 'char *' is deprecated [-Wc++11-compat-deprecated-writable-strings]
DtXlateStdToOpCodeset(DtLCX_OPER_INTERCHANGE_CODESET,
^

../../../../lib/DtHelp/LocaleXlate.h:77:41: note: expanded from macro
'DtLCX_OPER_INTERCHANGE_CODESET'

(note: a whole lot more of this same warning)

Session.C:1661:18: error: no matching function for call to 'libiconv'

  if ((ret = iconv(cd, &ip, &ileft, &op, &oleft)) == (size_t) -1) {

             ^~~~~

/usr/local/include/iconv.h:83:15: note: expanded from macro 'iconv'

define iconv libiconv

          ^~~~~~~~

/usr/local/include/iconv.h:85:15: note: candidate function not viable: no known

  conversion from 'const char **' to 'char **' for 2nd argument

extern size_t iconv (iconv_t cd, char * inbuf, size_t inbytesleft, ch...

          ^

/usr/local/include/iconv.h:83:15: note: expanded from macro 'iconv'

define iconv libiconv

          ^

13 warnings and 1 error generated.

*** Error code 1

Stop.
~~~~

Should we still be building dtmail, given that it is not compatible with modern mail standards?

[Douglas Carmichael]

Attached is a patch to not build dtmail on a 'make World.'