Menu ▾ ▴

#173 Code refactoring patch for src/librt/primitives/brep/brep_debug.cpp

Untested
closed-accepted
Sean Morrison
None
5
2013-07-13
2013-05-01
Avneet Kaur
No

This patch is attempt to reduce unnecessary code in src/librt/primitives/brep/brep_debug.cpp.
I hope this patch will enhance the BRl-CAD codebase. :)

1 Attachments
brep_debugcpp.patch

Discussion

  • Sean Morrison

    Sean Morrison - 2013-07-13

    Nice refactoring, Avneet. The patch was just a little malformed (perhaps manually edited?) and there were style problems, but I was able to get it applied by breaking it into two parts and applying them separately (and then manually fixing the style).

    Your name has been credited in our authorship file's code contributions section. Thank you for the reduction.

     

  • Sean Morrison

    Sean Morrison - 2013-07-13
    • status: open --> closed-accepted
     

  • Avneet Kaur

    Avneet Kaur - 2013-07-13

    On Sat, Jul 13, 2013 at 8:17 AM, Sean Morrison brlcad@users.sf.net wrote:

    Nice refactoring, Avneet. The patch was just a little malformed (perhaps
    manually edited?) and there were style problems, but I was able to get it
    applied by breaking it into two parts and applying them separately (and then
    manually fixing the style).

    Your name has been credited in our authorship file's code contributions
    section. Thank you for the reduction

    I will take care of these type of malformed in future.

    --
    Er. Avneet Kaur
    Blog: www.avneetkhasla.wordpress.com

    "Coming together is a beginning; keeping together is progress; working
    together is success."

     

Log in to post a comment.