Thread: [brlcad-tracker] [ brlcad-Patches-3514098 ] Removal of global variable bu_strdup_message
Open Source Solid Modeling CAD
Brought to you by:
brlcad
From: SourceForge.net <no...@so...> - 2012-04-02 10:05:55
|
Patches item #3514098, was opened at 2012-04-02 03:05 Message generated for change (Settings changed) made by popescuandrei You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514098&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Benchmark & Performance Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andrei Popescu (popescuandrei) Assigned to: Nobody/Anonymous (nobody) >Summary: Removal of global variable bu_strdup_message Initial Comment: I have removed the global variable const char bu_strdup_message[] = "bu_strdup string"; Replaced the global declarations in /src/libbu/globals.c Modified functions ( and files containing the functions) void bu_prmem(const char *str) - /src/libbu/malloc.c and in char * bu_vls_strdup(const struct bu_vls *vp) - /src/libbu/vls.c On the virtual machine provided the source recompiles succesfuly. I attached the 3 modified files. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514098&group_id=105292 |
From: SourceForge.net <no...@so...> - 2012-05-07 19:31:25
|
Patches item #3514098, was opened at 2012-04-02 03:05 Message generated for change (Comment added) made by erikgreenwald You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514098&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: None Group: None >Status: Pending Resolution: None >Priority: 1 Private: No Submitted By: Andrei Popescu (popescuandrei) >Assigned to: Erik Greenwald (erikgreenwald) Summary: Removal of global variable bu_strdup_message Initial Comment: I have removed the global variable const char bu_strdup_message[] = "bu_strdup string"; Replaced the global declarations in /src/libbu/globals.c Modified functions ( and files containing the functions) void bu_prmem(const char *str) - /src/libbu/malloc.c and in char * bu_vls_strdup(const struct bu_vls *vp) - /src/libbu/vls.c On the virtual machine provided the source recompiles succesfuly. I attached the 3 modified files. ---------------------------------------------------------------------- >Comment By: Erik Greenwald (erikgreenwald) Date: 2012-05-07 12:31 Message: please resubmit as a patch file (svn diff > somefile.patch) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514098&group_id=105292 |
From: SourceForge.net <no...@so...> - 2012-05-07 19:58:43
|
Patches item #3514098, was opened at 2012-04-02 03:05 Message generated for change (Comment added) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514098&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Pending Resolution: None Priority: 1 Private: No Submitted By: Andrei Popescu (popescuandrei) Assigned to: Erik Greenwald (erikgreenwald) Summary: Removal of global variable bu_strdup_message Initial Comment: I have removed the global variable const char bu_strdup_message[] = "bu_strdup string"; Replaced the global declarations in /src/libbu/globals.c Modified functions ( and files containing the functions) void bu_prmem(const char *str) - /src/libbu/malloc.c and in char * bu_vls_strdup(const struct bu_vls *vp) - /src/libbu/vls.c On the virtual machine provided the source recompiles succesfuly. I attached the 3 modified files. ---------------------------------------------------------------------- >Comment By: Sean Morrison (brlcad) Date: 2012-05-07 12:58 Message: Plus, the comment in vls.c is unnecessary (and the local no longer needs to exist (and shouldn't be named with a bu_ prefix regardless)). It's also not clear to me what the logic now means in malloc.c... we're checking if the pointer is still the static string, yet can never change it? ---------------------------------------------------------------------- Comment By: Erik Greenwald (erikgreenwald) Date: 2012-05-07 12:31 Message: please resubmit as a patch file (svn diff > somefile.patch) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514098&group_id=105292 |
From: SourceForge.net <no...@so...> - 2012-05-18 20:27:08
|
Patches item #3514098, was opened at 2012-04-02 03:05 Message generated for change (Comment added) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514098&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Pending Resolution: None Priority: 1 Private: No Submitted By: Andrei Popescu (popescuandrei) Assigned to: Erik Greenwald (erikgreenwald) Summary: Removal of global variable bu_strdup_message Initial Comment: I have removed the global variable const char bu_strdup_message[] = "bu_strdup string"; Replaced the global declarations in /src/libbu/globals.c Modified functions ( and files containing the functions) void bu_prmem(const char *str) - /src/libbu/malloc.c and in char * bu_vls_strdup(const struct bu_vls *vp) - /src/libbu/vls.c On the virtual machine provided the source recompiles succesfuly. I attached the 3 modified files. ---------------------------------------------------------------------- >Comment By: Sean Morrison (brlcad) Date: 2012-05-18 13:27 Message: Andrei, do you plan to update this patch or should we close it out? ---------------------------------------------------------------------- Comment By: Sean Morrison (brlcad) Date: 2012-05-07 12:58 Message: Plus, the comment in vls.c is unnecessary (and the local no longer needs to exist (and shouldn't be named with a bu_ prefix regardless)). It's also not clear to me what the logic now means in malloc.c... we're checking if the pointer is still the static string, yet can never change it? ---------------------------------------------------------------------- Comment By: Erik Greenwald (erikgreenwald) Date: 2012-05-07 12:31 Message: please resubmit as a patch file (svn diff > somefile.patch) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514098&group_id=105292 |
From: SourceForge.net <no...@so...> - 2012-05-19 15:17:56
|
Patches item #3514098, was opened at 2012-04-02 03:05 Message generated for change (Settings changed) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514098&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Rejected Priority: 1 Private: No Submitted By: Andrei Popescu (popescuandrei) >Assigned to: Sean Morrison (brlcad) Summary: Removal of global variable bu_strdup_message Initial Comment: I have removed the global variable const char bu_strdup_message[] = "bu_strdup string"; Replaced the global declarations in /src/libbu/globals.c Modified functions ( and files containing the functions) void bu_prmem(const char *str) - /src/libbu/malloc.c and in char * bu_vls_strdup(const struct bu_vls *vp) - /src/libbu/vls.c On the virtual machine provided the source recompiles succesfuly. I attached the 3 modified files. ---------------------------------------------------------------------- >Comment By: Sean Morrison (brlcad) Date: 2012-05-19 08:17 Message: Discussed via IRC. Not worth working on this one right now. Being closed it out in favor of spending time towards unit testing and tpkg. ---------------------------------------------------------------------- Comment By: Sean Morrison (brlcad) Date: 2012-05-18 13:27 Message: Andrei, do you plan to update this patch or should we close it out? ---------------------------------------------------------------------- Comment By: Sean Morrison (brlcad) Date: 2012-05-07 12:58 Message: Plus, the comment in vls.c is unnecessary (and the local no longer needs to exist (and shouldn't be named with a bu_ prefix regardless)). It's also not clear to me what the logic now means in malloc.c... we're checking if the pointer is still the static string, yet can never change it? ---------------------------------------------------------------------- Comment By: Erik Greenwald (erikgreenwald) Date: 2012-05-07 12:31 Message: please resubmit as a patch file (svn diff > somefile.patch) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514098&group_id=105292 |