Thread: [brlcad-tracker] [ brlcad-Patches-2953172 ] Compilation with LDFLAGS="-Wl, --as-needed"
Open Source Solid Modeling CAD
Brought to you by:
brlcad
From: SourceForge.net <no...@so...> - 2010-02-16 23:47:16
|
Patches item #2953172, was opened at 2010-02-17 00:47 Message generated for change (Tracker Item Submitted) made by ctulhu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=2953172&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: hanno boeck (ctulhu) Assigned to: Nobody/Anonymous (nobody) Summary: Compilation with LDFLAGS="-Wl,--as-needed" Initial Comment: ld supports a flag --as-needed, which causes only the libraries needed to be linked in. However, this requires the linking order to be correct. Attached patch fixes this in brlcad at one place, it had misused LDADD for adding libraries, while LIBADD should be used for that. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=2953172&group_id=105292 |
From: SourceForge.net <no...@so...> - 2010-02-17 15:05:27
|
Patches item #2953172, was opened at 2010-02-16 23:47 Message generated for change (Comment added) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=2953172&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: None >Status: Closed >Resolution: Out of Date Priority: 5 Private: No Submitted By: hanno boeck (ctulhu) >Assigned to: Sean Morrison (brlcad) Summary: Compilation with LDFLAGS="-Wl,--as-needed" Initial Comment: ld supports a flag --as-needed, which causes only the libraries needed to be linked in. However, this requires the linking order to be correct. Attached patch fixes this in brlcad at one place, it had misused LDADD for adding libraries, while LIBADD should be used for that. ---------------------------------------------------------------------- >Comment By: Sean Morrison (brlcad) Date: 2010-02-17 15:05 Message: Your patch doesn't seem to change the linking order, it just declared the noinst library's dependencies instead of declaring them on the binary. Am I missing something? The linking order should be correct (and they're all needed). Regardless, head no longer uses a noinst library in that directory as symbols were getting left out of the libtool archive causing static initialization failures. Now they're back to being a slew of sources for the binary. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=2953172&group_id=105292 |
From: SourceForge.net <no...@so...> - 2010-02-19 13:26:39
|
Patches item #2953172, was opened at 2010-02-17 00:47 Message generated for change (Comment added) made by dgp85 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=2953172&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: None Status: Closed Resolution: Out of Date Priority: 5 Private: No Submitted By: hanno boeck (ctulhu) Assigned to: Sean Morrison (brlcad) Summary: Compilation with LDFLAGS="-Wl,--as-needed" Initial Comment: ld supports a flag --as-needed, which causes only the libraries needed to be linked in. However, this requires the linking order to be correct. Attached patch fixes this in brlcad at one place, it had misused LDADD for adding libraries, while LIBADD should be used for that. ---------------------------------------------------------------------- Comment By: Diego E. Pettenò (dgp85) Date: 2010-02-19 13:41 Message: Yup, rather than changing the order this is taking a step further and declare the dependencies for the noinst archive, which is the right thing to do anyway, given that there are no sources defined for step_g target. Since you said you've stopped using the noinst convenience library you should be fine without this patch for head, so you might just consider this for branch if you plan on releasing point-versions from this. ---------------------------------------------------------------------- Comment By: Sean Morrison (brlcad) Date: 2010-02-17 16:05 Message: Your patch doesn't seem to change the linking order, it just declared the noinst library's dependencies instead of declaring them on the binary. Am I missing something? The linking order should be correct (and they're all needed). Regardless, head no longer uses a noinst library in that directory as symbols were getting left out of the libtool archive causing static initialization failures. Now they're back to being a slew of sources for the binary. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=2953172&group_id=105292 |