#118 Address with a Null First and Last Name is created and added to the database

[Azhar Iqbal]

Summary:

The code does not check if the names passed into an 'Address' are 'null'

Environment:

This is a code issue, therefore is not isolated to any specific OS.

Priority:

Low

Detailed description of problem:

The Address and AddressModel classes does not check if the passed in parameters are null. This leads to the creation of Addresses with 'null' parameters.
This error goes against requirement REQ-11: "In order for an entry to be added the First and Last name have to be inserted."

Steps to reproduce:

-To start off with, make sure that there are no Addresses in the DB
-Create a new address 'ad' (Address ad = new Address();)
-Set the first name of 'ad' to 'null' (ad.setFirstName(null);)
-Attempt to save 'ad' to the database - This should not succeed as per the requirements
-Assert that the address was not added to the database. This fails, and shows that the address was infact added to the database.

OR

Run the attached JUnit test class.

Possible fixes:

Check if the passed parameters are 'null' in the Address class. Specifically, add some checks in the 'setter' methods on the Address class.