#101 Regression: snapshot 20150705 misdecodes vorbis

[AX Redneck 34noff]

to reproduce:
1. download, install and run http://sourceforge.net/projects/bonkenc/files/snapshots/20150705/freac-20150705-linux-x64.tar.gz/download
2. open any vorbis file, e.g. https://db.tt/fnYNWqzS (file created using fre:ac, free for download and redistribution)
3. play it in fre:ac, or transcode it to something and open result with Your favourite player
4. listen to piggy grunts and squeals
5. do the same steps with previous http://sourceforge.net/projects/bonkenc/files/snapshots/20141005/freac-20141005-linux-x64.tar.gz/download and listen to normal music

[AX Redneck 34noff]

workaround: replace /codecs/vorbis.so with one from snapshot 20141005

[Robert Kausch]

Thank you for reporting this!

The problem was with the Lancer SSE patch I applied to the Vorbis codec for the 20150705 release. The original author used the C long type in some structures.

Unfortunately, on non-Windows x64 systems, long is 64 bit while the code assumes that the values inside the structures are 32 bit.

Consequently, this bug occurs on all non-Windows x64 platforms, i.e. Linux, FreeBSD and OS X x64.

I'll publish a new snapshot release with that problem fixed in a few days.

[Robert Kausch]

A new snapshot release fixing this issue is now available at freac.org. Please try it!

This ticket will be closed in 2 weeks.

[AX Redneck 34noff]

Fixed. Thanks!

[AX Redneck 34noff]

...but this snapshot creates too large .ogg and .opus files.

[Robert Kausch]

OK, I can confirm that for Ogg Vorbis, but not for Opus.

For Vorbis it looks like it's another 64 bit long type bug introduced by the Lancer patches. I'll investigate it.

Opus seems just fine here across all platforms. Please check your configuration. Maybe you have some cover art that gets written to the tags?

[Robert Kausch]

The Vorbis file size issue should be fixed now. x64 packages for Linux, FreeBSD and OS X have been replaced.

Please download the package again and retry.

Sorry for not catching this at first try!

[AX Redneck 34noff]

Now it's truly fixed!

Opus seems just fine here across all platforms. Please check your configuration.

Yes, it was a problem with my settings of Opus. So excuse me please.