Thread: [Boa Constr] [Fwd: Re: [wxPython-users] import string]
Status: Beta
Brought to you by:
riaan
From: Marius T. <ma...@it...> - 2003-01-24 10:48:08
|
I got start crash running Boa with wxPyhton 2.4.0.2. Apparently string module is not imported any more by wxPython, causing Boa to issue: File "/home/marius/boa/boa_0.1.5/boa/Models/Controllers.py", line 273, in >identifyFilename > lext = string.lower(ext) >NameError: global name 'string' is not defined Somebody from wxPython list replyed me with something that could make sense. Here it is: -------- Original Message -------- Subject: Re: [wxPython-users] import string Date: Fri, 24 Jan 2003 11:37:54 +0100 From: Magnus Lycka <ma...@th...> Reply-To: wxP...@li... To: wxP...@li... References: <3E3...@er...> At 10:34 2003-01-24 -0500, Marius Trestioreanu wrote: >After I installed wxPython 2.4.0.2, Boa will crash complaining about >string name: > >File "/home/marius/boa/boa_0.1.5/boa/Models/Controllers.py", line 273, in >identifyFilename > lext = string.lower(ext) >NameError: global name 'string' is not defined Do I understand correctly that Controllers.py, which is part of Boa, relies on "from import *" do put the string module in its namespace? Hm... Another example of why "from X import *" is unhealthy. Surely it's bad practice to rely on a third party library to import a standard library module for you. I assume this is a mistake by a Boa developer. They wrote string.lower(ext) and forgot to add "import string" in the beginning of the file. It worked anyway (by accident) since it was imported by someone else. Unless I completely misunderstood what this was about, the reasonable solution is to add "import string" to the beginning of Controllers.py, or even better, unless support for python 1.5.2 or older is needed, to change it to ext.lower(). -- Magnus Lycka, Thinkware AB Alvans vag 99, SE-907 50 UMEA, SWEDEN phone: int+46 70 582 80 65, fax: int+46 70 612 80 65 http://www.thinkware.se/ mailto:ma...@th... --------------------------------------------------------------------- To unsubscribe, e-mail: wxP...@li... For additional commands, e-mail: wxP...@li... -- Marius Trestioreanu |
From: Riaan B. <riaan@e.co.za> - 2003-01-24 16:48:10
|
Hi Marius, > I got start crash running Boa with wxPyhton 2.4.0.2. Apparently string > module is not imported any more by wxPython, causing Boa to issue: Correct. To fix this issue is trivial, just add 'import string' to the top of the modules that complain. So far they are: About.py PropEdit/PropertyEditors.py Model/Controllers.py Views/StyledTextCtrls.py There may be more. When my SSH setup works again, I will check in the changes. I hope to release Boa 0.2.1 in a week or two that addresses this and the other issues that have popped up. So everybody please report issues asap. Thanks, Riaan. |