Menu

#8 param support is broken

closed
nobody
flash (8)
5
2002-01-27
2001-12-20
No

[bug and patch refers to current code in cvs]

param_block.c doesn't include <arch.h> which means
that PARAM_START is never defined in that compilation
unit and thus parse_ptags never gets a useful
definition.

parse_ptags also has a reference to PARAM_LEN. that
either needs to be defined explicitly or, as i have
done, converted to PARAM_FLASH_LEN.

[n.b., at least one of the ports (shannon) defines
PARAM_START as PARAM_RAM_BASE -- this can't be right
as main.c never moves the params from flash to ram.
setting PARAM_START to PARAM_FLASH_BASE does work.]

Discussion

  • Christopher Hoover

    patch for params

     
  • Christopher Hoover

    • status: open --> closed
     
  • Christopher Hoover

    Logged In: YES
    user_id=9590

    this has been fixed.

     

Log in to post a comment.