Menu

#3 add _timeStamps in pageTimings

v1.1.3
closed
None
5
2016-04-19
2014-09-23
Kholl
No

with current Firebug 2.0.4 and NetExport 0.9b6 a JsonParseException will be thrown.
In the HAR File is a new Array called _timestamp. This is missing in source code.

Part of HAR File:
{
  "log": {
    "version": "1.1",
    "creator": {
      "name": "Firebug",
      "version": "2.0"
    },
    "browser": {
      "name": "Firefox",
      "version": "32.0"
    },
    "pages": [
      {
        "startedDateTime": "2014-09-23T11:56:35.064+02:00",
        "id": "page_2",
        "title": "Google",
        "pageTimings": {
          "onContentLoad": 83,
          "onLoad": 868,
          "comment": "_timeStamps field contains timing data generated using console.timeStamp() method. See Firebug documentation: http://getfirebug.com/wiki/index.php/Console_API",
          "_timeStamps": [
            {
              "time": 83,
              "label": "\"DOMContentLoaded\" (Ereignis)"
            },
            {
              "time": 868,
              "label": "\"load\" (Ereignis)"
            }
          ]
        }
      }
    ],
    "entries": [
      {
...

Discussion

  • Kholl

    Kholl - 2014-09-23

    do some bug fixing, enjoy…

    HarPageTimings.java

    @line 115
    else if ("_timeStamps".equals(name))
            setTimeStamps(new HarTimeStamps(jp, warnings));
    
    @line 307
      /**
       * Sets the timeStamps value.
       * 
       * @param timeStamps The timeStamps to set.
       */
      public void setTimeStamps(HarTimeStamps timeStamps)
      {
        this.timeStamps = timeStamps;
      }
    
      /**
       * Returns the customFields value.
       * 
       * @return Returns the customFields.
       */
      public HarCustomFields getCustomFields()
      {
        return customFields;
      }
    

    Add HarTimeStamps.java
    Add HarTimeStamp.java

     
  • Emmanuel Cecchet

    Thanks for the patch, will be releasing a new version today including it.

     
  • Emmanuel Cecchet

    • status: open --> accepted
    • assigned_to: Emmanuel Cecchet
     
  • Emmanuel Cecchet

    The support for writing the fields is missing, will mention in the release that only read support is provided for now.

     
  • Kholl

    Kholl - 2014-09-26

    Thanks for using your code!

    But one more thing. It seems I forgot to delete a System.out in HarPageTimings.java at Line 108. Sorry!

     
  • Emmanuel Cecchet

    • status: accepted --> closed
    • Group: v1.0 (example) --> v1.1.3
     
  • Emmanuel Cecchet

    Integrated in 1.1.3

     

Log in to post a comment.