From: Guillaume F. <gf...@lo...> - 2006-06-29 02:07:08
|
Hi Craig, It's been a while. Hope you're doing well! :-) Craig Barratt a écrit : > I'm getting closer to releasing BackupPC 3.0. One of the > several remaining steps is updating the language files. Ok, did that for fr.pm. Any French speaker is welcomed to take a look at my translations to make sure they're ok. Checking in fr.pm; /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/fr.pm,v <-- fr.pm new revision: 1.45; previous revision: 1.44 done While at it, I did some testing and found a couple bugs: 1) I saw that you missed a string in EditConfig.pm : diff -r1.6 EditConfig.pm 1130c1130 < New key: <input type="text" name="addVarKey_$varName" size="20" maxlength="256" value=""> --- > $Lang->{CfgEdit_Button_New_Key}: <input type="text" name="addVarKey_$varName" size="20" maxlength="256" value=""> I added that to all the languages files so hopefully the translators will pick this new version. Checking in lib/BackupPC/CGI/EditConfig.pm; /cvsroot/backuppc/BackupPC/lib/BackupPC/CGI/EditConfig.pm,v <-- EditConfig.pm new revision: 1.7; previous revision: 1.6 done Checking in lib/BackupPC/Lang/de.pm; /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/de.pm,v <-- de.pm new revision: 1.23; previous revision: 1.22 done Checking in lib/BackupPC/Lang/en.pm; /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/en.pm,v <-- en.pm new revision: 1.35; previous revision: 1.34 done Checking in lib/BackupPC/Lang/es.pm; /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/es.pm,v <-- es.pm new revision: 1.22; previous revision: 1.21 done Checking in lib/BackupPC/Lang/fr.pm; /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/fr.pm,v <-- fr.pm new revision: 1.44; previous revision: 1.43 done Checking in lib/BackupPC/Lang/it.pm; /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/it.pm,v <-- it.pm new revision: 1.17; previous revision: 1.16 done Checking in lib/BackupPC/Lang/nl.pm; /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/nl.pm,v <-- nl.pm new revision: 1.10; previous revision: 1.9 done Checking in lib/BackupPC/Lang/pt_br.pm; /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/pt_br.pm,v <-- pt_br.pm new revision: 1.6; previous revision: 1.5 done 2) If I try to do an actual modification using the CGI Editor, I get this error: Insecure dependency in eval while running setuid at /home/backuppc/program//lib/BackupPC/CGI/EditConfig.pm line 1472. The action is actually executed, it's the eval of the language string that's causing the problem. 3) There's also a problem caused by utf8: I don't get anything when I click on "Start Complete Backup", "Start Incr Backup" or "Stop/Dequeue Backup" in a localized host page. It sends me to: BackupPC_Admin?host=delta&action=D%C3%A9marrer+la+sauvegarde+compl%C3%A8te The utf8 accented chars are encoded with two entities (é=%C3%A9, è=%C3%A8) and it seems like perl doesn't recognize that. I'm not sure on how to solve this problem, I see two ways: a) Use/Write a utf8 decoder for URL strings. Module Encode on CPAN is supposed to do that, but I don't have time to find out how. This might help: http://twiki.org/cgi-bin/view/TWiki/AppendixEncodeURLsWithUTF8 b) Don't use accented chars in the action field. This is not as simple as it sounds, since you're using several submit buttons. One way to do it would be with javascript, but I usually try to avoid javascript especially for such simple tasks. <form> <input type="button" value="$Lang->{Start_Full_Backup}" onClick="parent.location='BackupPC_Admin?host=$host&action=Start_Full_Backup'" /> <input type="button" value="$Lang->{Start_Incr_Backup}" onClick="parent.location='BackupPC_Admin?host=$host&action=Start_Incr_Backup'" /> <input type="button" value="$Lang->{Stop_Dequeue_Backup}" onClick="parent.location='BackupPC_Admin?host=$host&action=Stop_Dequeue_Backup'" /> </form> Gotta go, keep up the good work! :-) GFK's -- Guillaume Filion, ing. jr Logidac Tech., Beaumont, Québec, Canada - http://logidac.com/ PGP Key and more: http://guillaume.filion.org/ |
From: Rodrigo R. <rr...@uc...> - 2006-06-29 13:53:16
Attachments:
pt_br.pm_patch
|
Guillaume Filion <gf...@lo...> writes: Hi Guillaume and Craig I did some modifications in the pt-br language file and translated most of the new things. I am sending you a patch as an attachment. Rodrigo > Hi Craig, > > It's been a while. Hope you're doing well! :-) > > Craig Barratt a =E9crit : >> I'm getting closer to releasing BackupPC 3.0. One of the >> several remaining steps is updating the language files. > > Ok, did that for fr.pm. Any French speaker is welcomed to take a look at > my translations to make sure they're ok. > > Checking in fr.pm; > /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/fr.pm,v <-- fr.pm > new revision: 1.45; previous revision: 1.44 > done > > > While at it, I did some testing and found a couple bugs: > > 1) I saw that you missed a string in EditConfig.pm : > diff -r1.6 EditConfig.pm > 1130c1130 > < New key: <input type=3D"text" name=3D"addVarKey_$varName" size=3D"20" > maxlength=3D"256" value=3D""> > --- >> $Lang->{CfgEdit_Button_New_Key}: <input type=3D"text" > name=3D"addVarKey_$varName" size=3D"20" maxlength=3D"256" value=3D""> > > I added that to all the languages files so hopefully the translators > will pick this new version. > Checking in lib/BackupPC/CGI/EditConfig.pm; > /cvsroot/backuppc/BackupPC/lib/BackupPC/CGI/EditConfig.pm,v <-- > EditConfig.pm > new revision: 1.7; previous revision: 1.6 > done > Checking in lib/BackupPC/Lang/de.pm; > /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/de.pm,v <-- de.pm > new revision: 1.23; previous revision: 1.22 > done > Checking in lib/BackupPC/Lang/en.pm; > /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/en.pm,v <-- en.pm > new revision: 1.35; previous revision: 1.34 > done > Checking in lib/BackupPC/Lang/es.pm; > /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/es.pm,v <-- es.pm > new revision: 1.22; previous revision: 1.21 > done > Checking in lib/BackupPC/Lang/fr.pm; > /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/fr.pm,v <-- fr.pm > new revision: 1.44; previous revision: 1.43 > done > Checking in lib/BackupPC/Lang/it.pm; > /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/it.pm,v <-- it.pm > new revision: 1.17; previous revision: 1.16 > done > Checking in lib/BackupPC/Lang/nl.pm; > /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/nl.pm,v <-- nl.pm > new revision: 1.10; previous revision: 1.9 > done > Checking in lib/BackupPC/Lang/pt_br.pm; > /cvsroot/backuppc/BackupPC/lib/BackupPC/Lang/pt_br.pm,v <-- pt_br.pm > new revision: 1.6; previous revision: 1.5 > done > > > 2) If I try to do an actual modification using the CGI Editor, I get > this error: > Insecure dependency in eval while running setuid at > /home/backuppc/program//lib/BackupPC/CGI/EditConfig.pm line 1472. > The action is actually executed, it's the eval of the language string > that's causing the problem. > > 3) There's also a problem caused by utf8: I don't get anything when I > click on "Start Complete Backup", "Start Incr Backup" or "Stop/Dequeue > Backup" in a localized host page. > > It sends me to: > BackupPC_Admin?host=3Ddelta&action=3DD%C3%A9marrer+la+sauvegarde+compl%C3= %A8te > > The utf8 accented chars are encoded with two entities (=E9=3D%C3%A9, > =E8=3D%C3%A8) and it seems like perl doesn't recognize that. > > I'm not sure on how to solve this problem, I see two ways: > a) Use/Write a utf8 decoder for URL strings. Module Encode on CPAN is > supposed to do that, but I don't have time to find out how. This might > help: http://twiki.org/cgi-bin/view/TWiki/AppendixEncodeURLsWithUTF8 > > b) Don't use accented chars in the action field. This is not as simple > as it sounds, since you're using several submit buttons. One way to do > it would be with javascript, but I usually try to avoid javascript > especially for such simple tasks. > > <form> > <input type=3D"button" value=3D"$Lang->{Start_Full_Backup}" > onClick=3D"parent.location=3D'BackupPC_Admin?host=3D$host&action=3DStart_= Full_Backup'" > /> > <input type=3D"button" value=3D"$Lang->{Start_Incr_Backup}" > onClick=3D"parent.location=3D'BackupPC_Admin?host=3D$host&action=3DStart_= Incr_Backup'" > /> > <input type=3D"button" value=3D"$Lang->{Stop_Dequeue_Backup}" > onClick=3D"parent.location=3D'BackupPC_Admin?host=3D$host&action=3DStop_D= equeue_Backup'" > /> > </form> > > Gotta go, keep up the good work! :-) > GFK's > --=20 > Guillaume Filion, ing. jr > Logidac Tech., Beaumont, Qu=E9bec, Canada - http://logidac.com/ > PGP Key and more: http://guillaume.filion.org/ > > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job ea= sier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat= =3D121642 > _______________________________________________ > BackupPC-devel mailing list > Bac...@li... > https://lists.sourceforge.net/lists/listinfo/backuppc-devel > http://backuppc.sourceforge.net/ |
From: Craig B. <cba...@us...> - 2006-06-29 07:05:37
|
GFK, Thanks for the comments and update to the strings. I'll look at the insecure dependency. I have taint mode off and that is the default for new installations, so I don't see this error. Craig |