From: Tim T. <tt...@mi...> - 2008-04-16 22:26:44
Attachments:
BackupPC-userSpecifiedTopDir.patch
|
First I want to thank the developers of BackupPC for creating such a effective and easy to use backup solution. I just started using the 3.1.0 version, was very impressed. However, after a while, I wanted to move to location where the backup data was stored to a larger partition, I found what I believe to be a bug in the tool. The 2 pool directories are assigned values based on either the default value of topDir, or the value passed into the new method of BackupPC::Lib, but before the config.pl file is read. When I edited config.pl to change the location of TopDir, the values of the pool directories never got changed, but the other key directories did. The result is that the individual machine backups ended up on a different physical partition than the pools, so the link step failed dramatically, generated thousands of messages of the form: BackupPC_link got error -4 when calling MakeFileLink(<file_path>, <hash>, 1) The attached patch for the BackupPC/lib/BackupPC/Lib.pm file fixes the problem by moving the assignment of $bpc->{PoolDir} and $bpc->{CPoolDir} to after config.pl is read and TopDir is reassigned. Thanks again for a great tool! - Tim |