amavisd-milter-users Mailing List for amavisd-milter
Brought to you by:
reho
This list is closed, nobody may subscribe to it.
2005 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
(3) |
Jul
(9) |
Aug
(7) |
Sep
(2) |
Oct
|
Nov
(4) |
Dec
|
---|---|---|---|---|---|---|---|---|---|---|---|---|
2006 |
Jan
(12) |
Feb
|
Mar
(10) |
Apr
(10) |
May
(15) |
Jun
|
Jul
(11) |
Aug
|
Sep
|
Oct
(25) |
Nov
(3) |
Dec
(31) |
2007 |
Jan
(15) |
Feb
(5) |
Mar
(3) |
Apr
(10) |
May
|
Jun
|
Jul
(5) |
Aug
(2) |
Sep
(25) |
Oct
|
Nov
|
Dec
|
2008 |
Jan
(7) |
Feb
(4) |
Mar
|
Apr
|
May
|
Jun
|
Jul
(4) |
Aug
|
Sep
|
Oct
(8) |
Nov
|
Dec
(5) |
2009 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
(20) |
Jul
(14) |
Aug
(7) |
Sep
|
Oct
(14) |
Nov
|
Dec
|
2010 |
Jan
(6) |
Feb
|
Mar
(1) |
Apr
|
May
(2) |
Jun
(1) |
Jul
|
Aug
|
Sep
(12) |
Oct
(1) |
Nov
(9) |
Dec
|
2011 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(1) |
Dec
|
2013 |
Jan
(4) |
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2015 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
2016 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2017 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
2018 |
Jan
|
Feb
|
Mar
(1) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2019 |
Jan
(3) |
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2020 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
From: Matus U. - f. <uh...@fa...> - 2020-05-11 12:30:22
|
On 20.04.20 19:56, Matus UHLAR - fantomas wrote: >I use amavisd-milter on Debian machines with amavis 2.10 and 2.11 > >I recently found out that nearly all messages hit ALL_TRUSTED Now, on >one server I see 79 mails without ALL_TRUSTED and 9700 without. > >messages received via LMTP don't have this probem. > >it seems that this problem is amavisd-new dependent, since Debian 10 with >amavisd-milter 1.5.0 and amavisd-new 2.11.0 does have that problem, but >Debian 8 with amavisd-milter 1.5.0 and amavisd-new 2.10.1 does not. > >however, the solution probably can lie in amavisd-milter, or at least >amavisd-milter may be suspect so I post here FYI: It's bug in amavisd-new documented here: https://gitlab.com/amavis/amavis/-/issues/61 patched amavisd-new works properly -- Matus UHLAR - fantomas, uh...@fa... ; http://www.fantomas.sk/ Warning: I wish NOT to receive e-mail advertising to this address. Varovanie: na tuto adresu chcem NEDOSTAVAT akukolvek reklamnu postu. Windows found: (R)emove, (E)rase, (D)elete |
From: Matus U. - f. <uh...@fa...> - 2020-04-20 17:56:37
|
Hello, I use amavisd-milter on Debian machines with amavis 2.10 and 2.11 I recently found out that nearly all messages hit ALL_TRUSTED Now, on one server I see 79 mails without ALL_TRUSTED and 9700 without. messages received via LMTP don't have this probem. it seems that this problem is amavisd-new dependent, since Debian 10 with amavisd-milter 1.5.0 and amavisd-new 2.11.0 does have that problem, but Debian 8 with amavisd-milter 1.5.0 and amavisd-new 2.10.1 does not. however, the solution probably can lie in amavisd-milter, or at least amavisd-milter may be suspect so I post here -- Matus UHLAR - fantomas, uh...@fa... ; http://www.fantomas.sk/ Warning: I wish NOT to receive e-mail advertising to this address. Varovanie: na tuto adresu chcem NEDOSTAVAT akukolvek reklamnu postu. "One World. One Web. One Program." - Microsoft promotional advertisement "Ein Volk, ein Reich, ein Fuhrer!" - Adolf Hitler |
From: Matus U. - f. <uh...@fa...> - 2019-04-16 10:43:46
|
On 17.01.19 00:01, Petr Řehoř wrote: >amavisd-milter has been moved to https://github.com/prehor/amavisd-milter by the way, it would be nice if the SF page could link to github: http://amavisd-milter.sourceforge.net/ this page still shows as first in web searches -- Matus UHLAR - fantomas, uh...@fa... ; http://www.fantomas.sk/ Warning: I wish NOT to receive e-mail advertising to this address. Varovanie: na tuto adresu chcem NEDOSTAVAT akukolvek reklamnu postu. Quantum mechanics: The dreams stuff is made of. |
From: Petr Ř. <pr...@gm...> - 2019-01-16 23:02:16
|
amavisd-milter has been moved to https://github.com/prehor/amavisd-milter P. |
From: Matus U. - f. <uh...@fa...> - 2019-01-04 16:15:38
|
On 04.01.19 15:29, Matus UHLAR - fantomas wrote: >amavisd-milter 1.6.1 does daemonize, and opens milter socket after that, >exiting if it returns error > >We want to change the socket permissions after daemon is started, and this >order of commands makes it problematic, e.g. debian bug 854180 >(https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854180) > >the daemon() should be called after calling smfi_opensocket(). > >This would also make possible to return error in case of impossibility to create >socket, so the caller knows it failed. this patch moves the daemonising section after opening socket. I have tried with amavisd-milter 1.6.1 and 1.5.0, works nicely. you can find it at test.fantomas.sk/amavisd-milter-main.c.patch --- main.c.orig 2013-04-22 02:36:12.000000000 +0200 +++ main.c 2019-01-04 15:35:29.486854008 +0100 @@ -379,17 +379,6 @@ } } - /* Run in the background */ - if (daemonize) { - if (daemon(1, 1) != -1) { - daemonized = 1; - } else { - logmsg(LOG_ERR, "could not fork daemon process: %s", - strerror(errno)); - exit(EX_OSERR); - } - } - /* Connect to milter socket */ #ifdef HAVE_SMFI_SETBACKLOG if (mlfi_socket_backlog > 0) { @@ -406,6 +395,17 @@ } #endif + /* Run in the background */ + if (daemonize) { + if (daemon(1, 1) != -1) { + daemonized = 1; + } else { + logmsg(LOG_ERR, "could not fork daemon process: %s", + strerror(errno)); + exit(EX_OSERR); + } + } + /* Greetings message */ logmsg(LOG_WARNING, "starting %s %s on socket %s", progname, VERSION, mlfi_socket); -- Matus UHLAR - fantomas, uh...@fa... ; http://www.fantomas.sk/ Warning: I wish NOT to receive e-mail advertising to this address. Varovanie: na tuto adresu chcem NEDOSTAVAT akukolvek reklamnu postu. If Barbie is so popular, why do you have to buy her friends? |
From: Matus U. - f. <uh...@fa...> - 2019-01-04 14:45:07
|
Hello, amavisd-milter 1.6.1 does daemonize, and opens milter socket after that, exiting if it returns error We want to change the socket permissions after daemon is started, and this order of commands makes it problematic, e.g. debian bug 854180 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854180) the daemon() should be called after calling smfi_opensocket(). This would also make possible to return error in case of impossibility to create socket, so the caller knows it failed. -- Matus UHLAR - fantomas, uh...@fa... ; http://www.fantomas.sk/ Warning: I wish NOT to receive e-mail advertising to this address. Varovanie: na tuto adresu chcem NEDOSTAVAT akukolvek reklamnu postu. Atheism is a non-prophet organization. |
From: Florian P. <blu...@xi...> - 2018-03-04 03:13:12
|
On 16.12.2017 00:16, Florian Pritz via amavisd-milter-users wrote: > Spamassassin's RDNS_NONE check tests if the rdns field in the Received header > is empty or "unknown". Postfix sets the client_name macro to "unknown" when the > FcrDNS check fails, but the hostname passed to xxfi_connect is set to the IP > address which means that RDNS_NONE will never trigger. Fix this by using > client_name if available and only fall back to the hostname parameter > otherwise. Is anybody still reading this ML? I'd love to get this merged. Florian |
From: Florian P. <blu...@xi...> - 2017-12-15 23:35:26
|
Spamassassin's RDNS_NONE check tests if the rdns field in the Received header is empty or "unknown". Postfix sets the client_name macro to "unknown" when the FcrDNS check fails, but the hostname passed to xxfi_connect is set to the IP address which means that RDNS_NONE will never trigger. Fix this by using client_name if available and only fall back to the hostname parameter otherwise. diff -ur src/amavisd-milter-1.6.1/amavisd-milter/mlfi.c src-mod/amavisd-milter-1.6.1/amavisd-milter/mlfi.c --- src/amavisd-milter-1.6.1/amavisd-milter/mlfi.c 2015-05-24 20:59:19.000000000 +0200 +++ src-mod/amavisd-milter-1.6.1/amavisd-milter/mlfi.c 2017-12-15 18:08:15.007525175 +0100 @@ -315,6 +315,7 @@ const void *addr; const char *prefix; const char *daemon_name; + const char *client_host; int len, plen; logmsg(LOG_DEBUG, "%s: CONNECT", hostname); @@ -331,8 +332,20 @@ (void) memset(mlfi, '\0', sizeof(*mlfi)); mlfi->mlfi_amasd = -1; + /* Try to get client_name from macros */ + if ((client_host = smfi_getsymval(ctx, "{client_name}")) != NULL) { + logqidmsg(mlfi, LOG_INFO, "client_name: %s", client_host); + if ((mlfi->mlfi_client_host = strdup(client_host)) == NULL) { + logqidmsg(mlfi, LOG_ERR, "could not allocate memory"); + mlfi_setreply_tempfail(ctx); + return SMFIS_TEMPFAIL; + } + } else { + logqidmsg(mlfi, LOG_INFO, "{client_name} undefined at connect time! Falling back to libmilter value."); + } + /* Save connection informations */ - if (hostname != NULL && *hostname != '\0') { + if (hostname != NULL && *hostname != '\0' && mlfi->mlfi_client_host == NULL) { if ((mlfi->mlfi_client_host = strdup(hostname)) == NULL) { logmsg(LOG_ERR, "%s: could not allocate memory", hostname); mlfi_setreply_tempfail(ctx); |
From: Hamy <per...@ya...> - 2016-04-16 10:04:24
|
Hi, Even though the latest release is 1.6.1 , released in 2015, the latest provided Debian/Ubuntu package, is 1.5.0 which is for 2010. I am not quite sure how the package updating procedure should take place but It's been suggested that i contact the developers. could you please take a look at this? Thanks https://launchpad.net/ubuntu/+source/amavisd-milter https://packages.debian.org/source/sid/amavisd-milter |
From: jan h. p. <jh...@jh...> - 2015-12-10 00:03:14
|
Hi everyone, I have a Centos 6 server with sendmail. On this server I use Milter-Greylist in combination with Amavisd-new and Amavisd-milter. This works fine except for one thing. When users authenticate to sendmail using smtp_auth (saslauthd) milter greylist sees this perfectly and skips all greylisting, but amavisd-new doesn't seem to receive the SMTP_AUTH policy bank through the amavisd-milter. I have added the following lines to amavisd-new to make the policy_bank available: $policy_bank{'SMTP_AUTH'} = { protocol => 'AM.PDP', originating => 1, bypass_banned_checks_maps => [1], bypass_spam_checks_maps => [1], os_fingerprint_method => undef, spam_lovers_maps => [1], banned_files_lovers_maps => [1], }; In sendmail.mc I have the following lines to support milter-greylist and amavisd-milter. define('MILTER', `1') INPUT_MAIL_FILTER(`greylist',`S=local:/var/lib/milter-greylist/milter-greylist.sock') define(`confMILTER_MACROS_CONNECT', `j, {if_addr}') define(`confMILTER_MACROS_HELO', `{verify}, {cert_subject}') define(`confMILTER_MACROS_ENVFROM', `r, b, i, {auth_authen}') define(`confMILTER_LOG_LEVEL',`10') define(`confMILTER_MACROS_ENVRCPT', `{greylist}') INPUT_MAIL_FILTER(`milter-amavis', `S=local:/var/spool/amavisd/amavisd-milter.sock, F=T, T=S:10m;R:10m;E:10m') TRUST_AUTH_MECH(`PLAIN GSSAPI KERBEROS_V4 DIGEST-MD5 CRAM-MD5 LOGIN') DAEMON_OPTIONS(`port=smtp,Name=MTA,Family=inet6,InputMailFilters=greylist;milter-amavis') DAEMON_OPTIONS(`port=smtps,Name=TLSMTA,Family=inet6,InputMailFilters=greylist;milter-amavis,M=s') I start amavisd-milter with the following options: /usr/sbin/amavisd-milter -p /var/run/amavisd/milter.pid -w /var/spool/amavisd -s local:/var/spool/amavisd/amavisd-milter.sock -S /var/spool/amavisd/amavisd.sock -m 50 -B -d 3 A few questions: Does anyone have a working config, or maybe some pointers to where I need to look to get this fixed? Everything like virus scanning and spamscanning etc works just fine. The only problem I have is that I want to skip spam scanning when someone authenticates using SMTP_AUTH. The version of Amavisd-milter is 1.6.1. Thanks, Jan Hugo Prins |
From: Petr R. <pr...@gm...> - 2015-05-24 22:18:39
|
Bug and compatibility fixies: - Fixed bug when creating amavisd-new policy bank names. P. |
From: Petr R. <pr...@gm...> - 2013-05-19 21:42:01
|
New features: - Added new amavisd-milter option -B which pases value of {daemon_name} milter macro as amavisd-new policy bank name. Bug and compatibility fixies: - Added amavisd-milter.spec for compilation with rpmbuild. - Fixed typo which prevents using LDFLAGS on Debian. - Fixed missing definition of true and false in libmilter/mfapi.h. P. |
From: Simon H. <li...@th...> - 2013-01-31 16:05:17
|
Jo Rhett wrote: >First, I found that all of the published recipes for spam containment with postfix are bogus. > They either create back-scatter, or they drop messages which hit the filter instead of rejecting them > in the SMTP session like they are supposed to. So if something is a false positive, the far side will never > know it happened. Yep, nearly all the howtos etc use after-queue scanning. >So I've done some testing and work, and I currently have postfix using amavisd-milter as a before-queue > spam test, which properly rejects spam during the SMTP session. This solves both of the previous > problems and brings postfix users closer to being a proper mail gateway. I believe very strongly that this > recipe should replace the existing documentation, to avoid sending new users out to become backscatters. Yes, it works very nicely. I've been running this setup for a couple of years now. It was made a lot easier when the amavisd-milterpackage appeared in Debian. I agree the setup could do with being made more prominent. The main downside, as the various docs that discuss it mention, is that you can end up needing significant processing capability to deal with peak influx of email. I've also added Policyd (aka Cluebringer), http://www.policyd.org, which rather nicely handles per-SASL-login quotas/throttling of outbound traffic (we provide the servers for customers to use as a relay as well). Just last wekk we shoved a customer on that sends bulk mails out to several thousand people at a time, and several times a week - it was nice to see Policyd just throttling them down to a sane message rate rather than swamping the system as happened on the older box I run. >I'm still working out a few details: namely, how to get the permissions right on the amavisd-milter socket. As soon as that is sorted I'll provide documentation. >Hint: there's no mystery here. I installed amavisd-milter as documented and pointed postfix at it :-) I can't remember now if I had to modify anything, but in the init script in Debian I see it has : if [ "$MILTERSOCKETTYPE" = "pipe" ]; then if [ "$MILTERSOCKETOWNER" ]; then chown "$MILTERSOCKETOWNER" "$MILTERSOCKET" fi if [ "$MILTERSOCKETMODE" ]; then chmod "$MILTERSOCKETMODE" "$MILTERSOCKET" fi fi And in /etc/default/amavisd-milter it has : # Set these two options if you want the socket to have # special permissions (usefull mainly for postfix). MILTERSOCKETOWNER="postfix:postfix" MILTERSOCKETMODE="0660" I set this up initially under Debian Squeeze, it's now running Wheezy. |
From: Simon H. <li...@th...> - 2013-01-31 10:24:14
|
Jo Rhett wrote: >First, I found that all of the published recipes for spam containment with postfix are bogus. > They either create back-scatter, or they drop messages which hit the filter instead of rejecting them > in the SMTP session like they are supposed to. So if something is a false positive, the far side will never > know it happened. Yep, nearly all the howtos etc use after-queue scanning. >So I've done some testing and work, and I currently have postfix using amavisd-milter as a before-queue > spam test, which properly rejects spam during the SMTP session. This solves both of the previous > problems and brings postfix users closer to being a proper mail gateway. I believe very strongly that this > recipe should replace the existing documentation, to avoid sending new users out to become backscatters. Yes, it works very nicely. I've been running this setup for a couple of years now. It was made a lot easier when the amavisd-milterpackage appeared in Debian. I agree the setup could do with being made more prominent. The main downside, as the various docs that discuss it mention, is that you can end up needing significant processing capability to deal with peak influx of email. I've also added Policyd (aka Cluebringer), http://www.policyd.org, which rather nicely handles per-SASL-login quotas/throttling of outbound traffic (we provide the servers for customers to use as a relay as well). Just last wekk we shoved a customer on that sends bulk mails out to several thousand people at a time, and several times a week - it was nice to see Policyd just throttling them down to a sane message rate rather than swamping the system as happened on the older box I run. >I'm still working out a few details: namely, how to get the permissions right on the amavisd-milter socket. As soon as that is sorted I'll provide documentation. >Hint: there's no mystery here. I installed amavisd-milter as documented and pointed postfix at it :-) I can't remember now if I had to modify anything, but in the init script in Debian I see it has : if [ "$MILTERSOCKETTYPE" = "pipe" ]; then if [ "$MILTERSOCKETOWNER" ]; then chown "$MILTERSOCKETOWNER" "$MILTERSOCKET" fi if [ "$MILTERSOCKETMODE" ]; then chmod "$MILTERSOCKETMODE" "$MILTERSOCKET" fi fi And in /etc/default/amavisd-milter it has : # Set these two options if you want the socket to have # special permissions (usefull mainly for postfix). MILTERSOCKETOWNER="postfix:postfix" MILTERSOCKETMODE="0660" I set this up initially under Debian Squeeze, it's now running Wheezy. |
From: Jo R. <jr...@ne...> - 2013-01-31 06:05:02
|
So I've been a sendmail admin for 20+ years and never saw any need for postfix. I was very happy with sendmail and amavisd-milter and amavisd. However, when rebuilding my colo box I decided to go ahead and learn postfix, just so I can see how the other half lives ;-) First, I found that all of the published recipes for spam containment with postfix are bogus. They either create back-scatter, or they drop messages which hit the filter instead of rejecting them in the SMTP session like they are supposed to. So if something is a false positive, the far side will never know it happened. Neither of these situations is playing fair to other parties. So I've done some testing and work, and I currently have postfix using amavisd-milter as a before-queue spam test, which properly rejects spam during the SMTP session. This solves both of the previous problems and brings postfix users closer to being a proper mail gateway. I believe very strongly that this recipe should replace the existing documentation, to avoid sending new users out to become backscatters. I'm still working out a few details: namely, how to get the permissions right on the amavisd-milter socket. As soon as that is sorted I'll provide documentation. Hint: there's no mystery here. I installed amavisd-milter as documented and pointed postfix at it :-) -- Jo Rhett Net Consonance : net philanthropy to improve open source and internet projects. |
From: Jo R. <jr...@ne...> - 2013-01-21 00:15:55
|
Petr, if you were to include this spec file in the tarfile, RHEL and variants would be able to build RPMs of your software like so: rpmbuild -tb amavisd-milter-1.5.0.tar.gz I'm willing to send you patches for new versions, but the likely only change will be to change the version string at the top unless you change the command line options. |
From: Cristian S. <cs...@ik...> - 2011-11-16 11:05:55
|
Hi, I'm having trouble configuring amavisd-milter-1.5.0, Postfix 2.6.6 and amavisd-new 2.7.0. Amavisd-milter can't open socket to Amavisd even though the socket file exists and permissions should be ok. The error message is yyy.fi: grab amavisd connection 1 yyy.fi: could not connect to amavisd socket unix:/var/amavis/tmp/amavisd.sock: No such file or directory yyy.fi: set reply 451 4.6.0 Content scanner malfunction I'm using Amavisd-milter command line: su - amavis -s /bin/sh -c "amavisd-milter -w /var/amavis/tmp -m 2 -M 540 -p /var/amavis/var/amavisd-milter.pid -s inet:10029@localhost -S unix:/var/amavis/tmp/amavisd.sock -d9 -f" Clips from amavisd.conf: $MYHOME = '/var/amavis'; $TEMPBASE = "$MYHOME/tmp"; $ENV{TMPDIR} = $TEMPBASE; $unix_socketname = "$TEMPBASE/amavisd.sock"; $interface_policy{'SOCK'} = 'AM.PDP-SOCK'; $policy_bank{'AM.PDP-SOCK'} = { protocol => 'AM.PDP', auth_required_release => 0, }; Permission tree: drwxr-x--- 6 root amavis 4096 Sep 23 16:08 /var/amavis/ drwxr-x--- 2 amavis amavis 4096 Nov 15 14:59 /var/amavis/tmp/ srwxr-x--- 1 amavis amavis 0 Nov 15 13:16 amavisd.sock I also tried to debug manually: - created an email in /var/amavis/tmp/xyz123/email.txt - su -s /bin/bash amavis - socat - UNIX-CONNECT:/var/amavis/tmp/amavisd.sock request=AM.PDP sender=<ro...@yy...> recipient=<cri...@xx...> protocol_name=ESMTP client_address=127.0.0.1 tempdir=/var/amavis/tmp/xyz123 version_server=2 log_id=19796 setreply=250 2.5.0 Ok,%20id=19796,%20continue%20delivery insheader=0 X-Virus-Scanned amavisd-new%20at%20xxx.yyy.fi return_value=continue exit_code=0 Can anyone explain, what's the problem? Why Amavisd-milter can't connect to Amavisd socket even though socket seems to work fine manually. Platform is CentOS 6.0, SELinux is switched off. Thanks in advance, Best Regards, -- Cristian Seres |
From: Petr R. <pr...@gm...> - 2010-11-04 23:50:17
|
On Thu, Nov 4, 2010 at 8:27 AM, Harald Jenny <ha...@a-...> wrote: > On Wed, Nov 03, 2010 at 09:12:35PM +0100, Petr Rehor wrote: > Hmmm maybe I'm wrong but searching in aclocal/ax_path_milter.m4 gives me two > occurences - please see attached patch Thanks for noticing. Commited. > Replacing the two occurences in configure finally gives me: > I: running CONFIG_SHELL=/bin/bash /bin/bash ./configure --build=i486-linux-gnu --includedir=${prefix}/include --infodir=${prefix}/share/info --localstatedir=/var --libexecdir=${prefix}/lib/amavisd-milter --disable-maintainer-mode --disable-dependency-tracking --prefix=/usr --mandir=${prefix}/share/man --sysconfdir=/etc --localstatedir=/var/lib/amavis --with-working-dir=/var/lib/amavis/tmp CFLAGS= -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security LDFLAGS= -fPIE -pie -Wl,-z,relro -Wl,-z,now build_alias=i486-linux-gnu --no-create --no-recursion > and > I: gcc -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -L/usr/lib/libmilter -fPIE -pie -Wl,-z,relro -Wl,-z,now -o amavisd-milter amavisd_milter-amavisd.o amavisd_milter-log.o amavisd_milter-main.o amavisd_milter-mlfi.o ../compat/libcompat.a -lmilter -lrt > > So it seems to me that this fixes the issue at hand :-). Thanks very much for > your help! Great. I release new version on the weekend. P. |
From: Harald J. <ha...@a-...> - 2010-11-04 07:27:29
|
On Wed, Nov 03, 2010 at 09:12:35PM +0100, Petr Rehor wrote: > Bugfix introduce new bugs :-( No problem proved this yesterday to myself too ;-) > > Here is right stuff: Thanks > > Index: aclocal/ax_path_milter.m4 > =================================================================== > RCS file: /cvsroot/amavisd-milter/amavisd-milter/aclocal/ax_path_milter.m4,v > retrieving revision 1.3 > diff -u -r1.3 ax_path_milter.m4 > --- aclocal/ax_path_milter.m4 1 Jun 2009 18:51:52 -0000 1.3 > +++ aclocal/ax_path_milter.m4 3 Nov 2010 20:08:40 -0000 > @@ -130,7 +130,7 @@ > # Debian use for libmilter.a /usr/lib/libmilter instead of /usr/lib > if test "$ax_path_milter_ok" = "no" ; then > unset ac_cv_lib_milter_smfi_main > - ac_milter_save_LDFLAGS="$LDLFAGS" > + ac_milter_save_LDFLAGS="$LDFLAGS" > MILTER_LDFLAGS="-L/usr/lib/libmilter" > LDFLAGS="$MILTER_LDFLAGS $LDFLAGS" > AC_CHECK_HEADER([libmilter/mfapi.h],[ > > For testing replace all occurences of LDLFAGS in configure with LDFLAGS. Hmmm maybe I'm wrong but searching in aclocal/ax_path_milter.m4 gives me two occurences - please see attached patch Replacing the two occurences in configure finally gives me: I: running CONFIG_SHELL=/bin/bash /bin/bash ./configure --build=i486-linux-gnu --includedir=${prefix}/include --infodir=${prefix}/share/info --localstatedir=/var --libexecdir=${prefix}/lib/amavisd-milter --disable-maintainer-mode --disable-dependency-tracking --prefix=/usr --mandir=${prefix}/share/man --sysconfdir=/etc --localstatedir=/var/lib/amavis --with-working-dir=/var/lib/amavis/tmp CFLAGS= -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security LDFLAGS= -fPIE -pie -Wl,-z,relro -Wl,-z,now build_alias=i486-linux-gnu --no-create --no-recursion and I: gcc -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -L/usr/lib/libmilter -fPIE -pie -Wl,-z,relro -Wl,-z,now -o amavisd-milter amavisd_milter-amavisd.o amavisd_milter-log.o amavisd_milter-main.o amavisd_milter-mlfi.o ../compat/libcompat.a -lmilter -lrt So it seems to me that this fixes the issue at hand :-). Thanks very much for your help! > > P. Kind regards Harald |
From: Harald J. <ha...@a-...> - 2010-11-04 07:16:12
|
On Wed, Nov 03, 2010 at 09:02:58PM +0100, Petr Rehor wrote: > Sorry, I forgot to add you on Cc. P. No problem, from time to timeI also take a look at the web based archives ;-) > > On Wed, Nov 3, 2010 at 9:00 PM, Petr Rehor <pr...@gm...> wrote: > > On Wed, Nov 3, 2010 at 1:33 AM, Harald Jenny > > <ha...@a-...> wrote: > >> On Tue, Nov 02, 2010 at 11:58:21PM +0100, Petr Rehor wrote: > >>> On Tue, Nov 2, 2010 at 8:10 PM, Harald Jenny > >>> <ha...@a-...> wrote: > >>> > On Tue, Nov 02, 2010 at 06:34:32PM +0100, Petr Rehor wrote: > >>> >> configure --help says, that you can use environment variables CFLAGS > >>> >> and LDFLAG to override choices made by configure. When I used bellow > >>> >> command on my FreeBSD box with tcsh, LDFLAGS is written permanently to > >>> >> Makefile. > >>> >> > >>> >> env " LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" ./configure > >>> > > >>> > Please look at the logfile - am I making something wrong? > >>> > >>> Please try separate steps and check if it works: > >>> > >>> 1) Set environment variables > >>> > >>> tcsh: > >>> > >>> setenv LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" > >>> setenv CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat > >>> -Wformat-security" > >>> > >>> or bash: > >>> > >>> export LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" > >>> export CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat > >>> -Wformat-security" > >>> > >>> and check environment variables. > >> > >> export LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" > >> export CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security" > >> > >> env|grep FLAGS > >> LDFLAGS=-fPIE -pie -Wl,-z,relro -Wl,-z,now > >> CFLAGS=-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security > >> > >>> > >>> 2) Run configure > >>> > >>> ./configure --prefix=/usr --mandir=$/share/man --sysconfdir=/etc > >>> --localstatedir=/var/lib/amavis --with-working-dir=/var/lib/amavis/tmp > >>> > >>> and check if Makefile contains expected LDFLAGS and CFLAGS definitions > >> > >> ./configure --prefix=/usr --mandir=$/share/man --sysconfdir=/etc --localstatedir=/var/lib/amavis --with-working-dir=/var/lib/amavis/tmp > >> > >> grep "FLAGS =" Makefile > >> CFLAGS = -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread > >> CPPFLAGS = > >> LDFLAGS = -L/usr/lib/libmilter > >> MILTER_CPPFLAGS = > >> MILTER_LDFLAGS = -L/usr/lib/libmilter > >> PTHREAD_CFLAGS = -pthread > > > > There is a problem - LDFLAGS has been rewritten. I found bug in > > aclocal/ax_path_milter.m4 Ah ok good to hear it wasn't wrong use by me. > > > > --- aclocal/ax_path_milter.m4.orig 2010-11-03 20:45:34.877393265 +0100 > > +++ aclocal/ax_path_milter.m4 2010-11-03 20:54:40.927262407 +0100 > > @@ -130,7 +130,7 @@ > > # Debian use for libmilter.a /usr/lib/libmilter instead of /usr/lib > > if test "$ax_path_milter_ok" = "no" ; then > > unset ac_cv_lib_milter_smfi_main > > - ac_milter_save_LDFLAGS="$LDLFAGS" > > + ac_milter_save_LDFLAGS="$LDFAGS" > > MILTER_LDFLAGS="-L/usr/lib/libmilter" > > LDFLAGS="$MILTER_LDFLAGS $LDFLAGS" > > AC_CHECK_HEADER([libmilter/mfapi.h],[ > > > > If it helps I commit this fix and release new version. Hmmm you don't like the combination of Debian and LDFAGS ähm LDFLAGS don't you ;-)? > > > > P. > > Thanks for your help and sorry for being so noisy Kind regards Harald |
From: Petr R. <pr...@gm...> - 2010-11-03 20:13:04
|
Bugfix introduce new bugs :-( Here is right stuff: Index: aclocal/ax_path_milter.m4 =================================================================== RCS file: /cvsroot/amavisd-milter/amavisd-milter/aclocal/ax_path_milter.m4,v retrieving revision 1.3 diff -u -r1.3 ax_path_milter.m4 --- aclocal/ax_path_milter.m4 1 Jun 2009 18:51:52 -0000 1.3 +++ aclocal/ax_path_milter.m4 3 Nov 2010 20:08:40 -0000 @@ -130,7 +130,7 @@ # Debian use for libmilter.a /usr/lib/libmilter instead of /usr/lib if test "$ax_path_milter_ok" = "no" ; then unset ac_cv_lib_milter_smfi_main - ac_milter_save_LDFLAGS="$LDLFAGS" + ac_milter_save_LDFLAGS="$LDFLAGS" MILTER_LDFLAGS="-L/usr/lib/libmilter" LDFLAGS="$MILTER_LDFLAGS $LDFLAGS" AC_CHECK_HEADER([libmilter/mfapi.h],[ For testing replace all occurences of LDLFAGS in configure with LDFLAGS. P. |
From: Petr R. <pr...@gm...> - 2010-11-03 20:00:57
|
On Wed, Nov 3, 2010 at 1:33 AM, Harald Jenny <ha...@a-...> wrote: > On Tue, Nov 02, 2010 at 11:58:21PM +0100, Petr Rehor wrote: >> On Tue, Nov 2, 2010 at 8:10 PM, Harald Jenny >> <ha...@a-...> wrote: >> > On Tue, Nov 02, 2010 at 06:34:32PM +0100, Petr Rehor wrote: >> >> configure --help says, that you can use environment variables CFLAGS >> >> and LDFLAG to override choices made by configure. When I used bellow >> >> command on my FreeBSD box with tcsh, LDFLAGS is written permanently to >> >> Makefile. >> >> >> >> env " LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" ./configure >> > >> > Please look at the logfile - am I making something wrong? >> >> Please try separate steps and check if it works: >> >> 1) Set environment variables >> >> tcsh: >> >> setenv LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" >> setenv CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat >> -Wformat-security" >> >> or bash: >> >> export LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" >> export CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat >> -Wformat-security" >> >> and check environment variables. > > export LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" > export CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security" > > env|grep FLAGS > LDFLAGS=-fPIE -pie -Wl,-z,relro -Wl,-z,now > CFLAGS=-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security > >> >> 2) Run configure >> >> ./configure --prefix=/usr --mandir=$/share/man --sysconfdir=/etc >> --localstatedir=/var/lib/amavis --with-working-dir=/var/lib/amavis/tmp >> >> and check if Makefile contains expected LDFLAGS and CFLAGS definitions > > ./configure --prefix=/usr --mandir=$/share/man --sysconfdir=/etc --localstatedir=/var/lib/amavis --with-working-dir=/var/lib/amavis/tmp > > grep "FLAGS =" Makefile > CFLAGS = -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread > CPPFLAGS = > LDFLAGS = -L/usr/lib/libmilter > MILTER_CPPFLAGS = > MILTER_LDFLAGS = -L/usr/lib/libmilter > PTHREAD_CFLAGS = -pthread There is a problem - LDFLAGS has been rewritten. I found bug in aclocal/ax_path_milter.m4 --- aclocal/ax_path_milter.m4.orig 2010-11-03 20:45:34.877393265 +0100 +++ aclocal/ax_path_milter.m4 2010-11-03 20:54:40.927262407 +0100 @@ -130,7 +130,7 @@ # Debian use for libmilter.a /usr/lib/libmilter instead of /usr/lib if test "$ax_path_milter_ok" = "no" ; then unset ac_cv_lib_milter_smfi_main - ac_milter_save_LDFLAGS="$LDLFAGS" + ac_milter_save_LDFLAGS="$LDFAGS" MILTER_LDFLAGS="-L/usr/lib/libmilter" LDFLAGS="$MILTER_LDFLAGS $LDFLAGS" AC_CHECK_HEADER([libmilter/mfapi.h],[ If it helps I commit this fix and release new version. P. |
From: Harald J. <ha...@a-...> - 2010-11-03 00:33:45
|
On Tue, Nov 02, 2010 at 11:58:21PM +0100, Petr Rehor wrote: > On Tue, Nov 2, 2010 at 8:10 PM, Harald Jenny > <ha...@a-...> wrote: > > On Tue, Nov 02, 2010 at 06:34:32PM +0100, Petr Rehor wrote: > >> configure --help says, that you can use environment variables CFLAGS > >> and LDFLAG to override choices made by configure. When I used bellow > >> command on my FreeBSD box with tcsh, LDFLAGS is written permanently to > >> Makefile. > >> > >> env " LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" ./configure > > > > Please look at the logfile - am I making something wrong? > > Please try separate steps and check if it works: > > 1) Set environment variables > > tcsh: > > setenv LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" > setenv CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat > -Wformat-security" > > or bash: > > export LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" > export CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat > -Wformat-security" > > and check environment variables. export LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" export CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security" env|grep FLAGS LDFLAGS=-fPIE -pie -Wl,-z,relro -Wl,-z,now CFLAGS=-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security > > 2) Run configure > > ./configure --prefix=/usr --mandir=$/share/man --sysconfdir=/etc > --localstatedir=/var/lib/amavis --with-working-dir=/var/lib/amavis/tmp > > and check if Makefile contains expected LDFLAGS and CFLAGS definitions ./configure --prefix=/usr --mandir=$/share/man --sysconfdir=/etc --localstatedir=/var/lib/amavis --with-working-dir=/var/lib/amavis/tmp grep "FLAGS =" Makefile CFLAGS = -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread CPPFLAGS = LDFLAGS = -L/usr/lib/libmilter MILTER_CPPFLAGS = MILTER_LDFLAGS = -L/usr/lib/libmilter PTHREAD_CFLAGS = -pthread > > 3) Run make and check gcc parameters. make make all-recursive make[1]: Entering directory `/tmp/amavisd-milter' Making all in compat make[2]: Entering directory `/tmp/amavisd-milter/compat' gcc -DHAVE_CONFIG_H -I. -I.. -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -MT read_sock.o -MD -MP -MF .deps/read_sock.Tpo -c -o read_sock.o read_sock.c mv -f .deps/read_sock.Tpo .deps/read_sock.Po gcc -DHAVE_CONFIG_H -I. -I.. -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -MT write_sock.o -MD -MP -MF .deps/write_sock.Tpo -c -o write_sock.o write_sock.c mv -f .deps/write_sock.Tpo .deps/write_sock.Po gcc -DHAVE_CONFIG_H -I. -I.. -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -MT strlcpy.o -MD -MP -MF .deps/strlcpy.Tpo -c -o strlcpy.o strlcpy.c mv -f .deps/strlcpy.Tpo .deps/strlcpy.Po rm -f libcompat.a ar cru libcompat.a read_sock.o write_sock.o strlcpy.o ranlib libcompat.a make[2]: Leaving directory `/tmp/amavisd-milter/compat' Making all in amavisd-milter make[2]: Entering directory `/tmp/amavisd-milter/amavisd-milter' gcc -DHAVE_CONFIG_H -I. -I.. -I../compat -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -MT amavisd_milter-amavisd.o -MD -MP -MF .deps/amavisd_milter-amavisd.Tpo -c -o amavisd_milter-amavisd.o `test -f 'amavisd.c' || echo './'`amavisd.c mv -f .deps/amavisd_milter-amavisd.Tpo .deps/amavisd_milter-amavisd.Po gcc -DHAVE_CONFIG_H -I. -I.. -I../compat -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -MT amavisd_milter-log.o -MD -MP -MF .deps/amavisd_milter-log.Tpo -c -o amavisd_milter-log.o `test -f 'log.c' || echo './'`log.c mv -f .deps/amavisd_milter-log.Tpo .deps/amavisd_milter-log.Po gcc -DHAVE_CONFIG_H -I. -I.. -I../compat -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -MT amavisd_milter-main.o -MD -MP -MF .deps/amavisd_milter-main.Tpo -c -o amavisd_milter-main.o `test -f 'main.c' || echo './'`main.c main.c: In function 'main': main.c:360: warning: passing argument 1 of 'smfi_setconn' discards qualifiers from pointer target type /usr/include/libmilter/mfapi.h:171: note: expected 'char *' but argument is of type 'const char *' mv -f .deps/amavisd_milter-main.Tpo .deps/amavisd_milter-main.Po gcc -DHAVE_CONFIG_H -I. -I.. -I../compat -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -MT amavisd_milter-mlfi.o -MD -MP -MF .deps/amavisd_milter-mlfi.Tpo -c -o amavisd_milter-mlfi.o `test -f 'mlfi.c' || echo './'`mlfi.c mlfi.c: In function 'mlfi_setreply_tempfail': mlfi.c:296: warning: passing argument 2 of 'smfi_setreply' discards qualifiers from pointer target type /usr/include/libmilter/mfapi.h:415: note: expected 'char *' but argument is of type 'const char *' mlfi.c:296: warning: passing argument 3 of 'smfi_setreply' discards qualifiers from pointer target type /usr/include/libmilter/mfapi.h:415: note: expected 'char *' but argument is of type 'const char *' mlfi.c:296: warning: passing argument 4 of 'smfi_setreply' discards qualifiers from pointer target type /usr/include/libmilter/mfapi.h:415: note: expected 'char *' but argument is of type 'const char *' mv -f .deps/amavisd_milter-mlfi.Tpo .deps/amavisd_milter-mlfi.Po gcc -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -L/usr/lib/libmilter -o amavisd-milter amavisd_milter-amavisd.o amavisd_milter-log.o amavisd_milter-main.o amavisd_milter-mlfi.o ../compat/libcompat.a -lmilter -lrt make[2]: Leaving directory `/tmp/amavisd-milter/amavisd-milter' make[2]: Entering directory `/tmp/amavisd-milter' make[2]: Leaving directory `/tmp/amavisd-milter' make[1]: Leaving directory `/tmp/amavisd-milter' > > Best regards > P. Kind regards Harald P.S: Sorry to spam you... |
From: Petr R. <pr...@gm...> - 2010-11-02 22:58:47
|
On Tue, Nov 2, 2010 at 8:10 PM, Harald Jenny <ha...@a-...> wrote: > On Tue, Nov 02, 2010 at 06:34:32PM +0100, Petr Rehor wrote: >> configure --help says, that you can use environment variables CFLAGS >> and LDFLAG to override choices made by configure. When I used bellow >> command on my FreeBSD box with tcsh, LDFLAGS is written permanently to >> Makefile. >> >> env " LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" ./configure > > Please look at the logfile - am I making something wrong? Please try separate steps and check if it works: 1) Set environment variables tcsh: setenv LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" setenv CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security" or bash: export LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" export CFLAGS="-fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security" and check environment variables. 2) Run configure ./configure --prefix=/usr --mandir=$/share/man --sysconfdir=/etc --localstatedir=/var/lib/amavis --with-working-dir=/var/lib/amavis/tmp and check if Makefile contains expected LDFLAGS and CFLAGS definitions 3) Run make and check gcc parameters. Best regards P. |
From: Harald J. <ha...@a-...> - 2010-11-02 19:11:19
|
On Tue, Nov 02, 2010 at 06:34:32PM +0100, Petr Rehor wrote: > On Mon, Sep 20, 2010 at 4:58 PM, Harald Jenny > <ha...@a-...> wrote: > > On Mon, Sep 20, 2010 at 12:34:34AM +0200, Petr Rehor wrote: > >> On Sun, Aug 8, 2010 at 7:30 PM, Harald Jenny <ha...@a-...> wrote: > >> > >> > I am currently trying to pass LDFLAGS to configure but it seems the fix for > >> > Debian placing milter library in /usr/lib/milter prohibts this? Maybe you > >> > could take a short look at it? > >> > >> amavisd-milter building vehicle has to preserve LDFLAGS. > >> Relevant part for Debian change is: > > > > Ok sounds reasonable but why does configure with LDFLAGS not work? > > > > I: dh_auto_configure -- --prefix=/usr --mandir=\${prefix}/share/man \ > > I: --sysconfdir=/etc --localstatedir=/var/lib/amavis \ > > I: --with-working-dir=/var/lib/amavis/tmp \ > > I: CFLAGS=" -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security " LDFLAGS=" -fPIE -pie -Wl,-z,relro -Wl,-z,now " \ > > > > I: gcc -O2 -DNDEBUG -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -pthread -L/usr/lib/libmilter -o amavisd-milter amavisd_milter-amavisd.o amavisd_milter-log.o amavisd_milter-main.o amavisd_milter-mlfi.o ../compat/libcompat.a -lmilter -lrt > > > > Only specifying LDFLAGS in Makefile directly after configure is effective. > > configure --help says, that you can use environment variables CFLAGS > and LDFLAG to override choices made by configure. When I used bellow > command on my FreeBSD box with tcsh, LDFLAGS is written permanently to > Makefile. > > env " LDFLAGS="-fPIE -pie -Wl,-z,relro -Wl,-z,now" ./configure Please look at the logfile - am I making something wrong? > > Best regards > P. Kind regards Harald |