Thread: [aKregator-devel] [Bug 119724] New: automatically select next item after delete
Brought to you by:
lippel
From: jason f. <jas...@sb...> - 2006-01-08 05:50:45
|
------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=119724 Summary: automatically select next item after delete Product: akregator Version: unspecified Platform: Gentoo Packages OS/Version: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general AssignedTo: akregator-devel lists sourceforge net ReportedBy: jasonfuchs sbcglobal net Version: (using KDE KDE 3.5.0) Installed from: Gentoo Packages When viewing the article list, deleting an item automatically displays the next feed item in the preview window, but the feed item itself is not *selected*, so the user must click on the item to delete it. For example, browsing the article list, you click on one, see the summary/preview, decide to delete it, you press delete, the next item is displayed, but if you also want to delete this one without reading, you have to click on it in the list, instead of just pressing delete key again. |
From: Eckhart Wör. <kd...@ew...> - 2006-01-08 12:44:05
|
------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=119724 kde ewsoftware de changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW everconfirmed|0 |1 |
From: Frank O. <fra...@kd...> - 2006-01-10 11:41:17
|
------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=119724 frank.osterfeld kdemail net changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|wishlist |normal ------- Additional Comments From frank.osterfeld kdemail net 2006-01-10 12:41 ------- Classifying as (usability) bug instead wishlist. |
From: Frank O. <fra...@kd...> - 2006-01-10 12:01:49
|
------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=119724 frank.osterfeld kdemail net changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Additional Comments From frank.osterfeld kdemail net 2006-01-10 13:01 ------- SVN commit 496329 by osterfeld: select the next article in the article list when deleting the only selected article (doesn't apply when deleting multiple articles) BUG: 119724 M +2 -0 ChangeLog M +48 -1 src/articlelistview.cpp --- branches/KDE/3.5/kdepim/akregator/ChangeLog #496328:496329 @ -7,6 +7,8 @ Bug fixes: + 2006/01/10 Select next item in article list when deleting the selected article + (single selection mode only) (#119724) -fo 2006/01/10 Fix item handling in the feed list, avoid crashes as happening after moving a folder and deleting a subitem afterwards (#118659) -fo --- branches/KDE/3.5/kdepim/akregator/src/articlelistview.cpp #496328:496329 @ -368,6 +368,12 @ { setUpdatesEnabled(false); + // if only one item is selected and this selected item + // is deleted, we will select the next item in the list + bool singleSelected = selectedArticles().count() == 1; + + QListViewItem* next = 0; // the item to select if a selected item is deleted + for (QValueList<Article>::ConstIterator it = list.begin(); it != list.end(); ++it) { @ -375,8 +381,16 @ { ArticleItem* ali = d->articleMap[*it]; - if ((*it).isDeleted()) // if article was set to deleted, delete item + if (ali && (*it).isDeleted()) // if article was set to deleted, delete item { + if (singleSelected && ali->isSelected()) + { + if (ali->itemBelow()) + next = ali->itemBelow(); + else if (ali->itemAbove()) + next = ali->itemAbove(); + } + d->articleMap.remove(*it); delete ali; } @ -390,22 +404,55 @ } } + // if the only selected item was deleted, select + // an item next to it + if (singleSelected && next != 0) + { + setSelected(next, true); + setCurrentItem(next); + } + setUpdatesEnabled(true); triggerUpdate(); } void ArticleListView::slotArticlesRemoved(TreeNode* /*node*/, const QValueList<Article>& list) { + // if only one item is selected and this selected item + // is deleted, we will select the next item in the list + bool singleSelected = selectedArticles().count() == 1; + + QListViewItem* next = 0; // the item to select if a selected item is deleted + setUpdatesEnabled(false); + for (QValueList<Article>::ConstIterator it = list.begin(); it != list.end(); ++it) { if (d->articleMap.contains(*it)) { ArticleItem* ali = d->articleMap[*it]; d->articleMap.remove(*it); + + if (singleSelected && ali->isSelected()) + { + if (ali->itemBelow()) + next = ali->itemBelow(); + else if (ali->itemAbove()) + next = ali->itemAbove(); + } + delete ali; } } + + // if the only selected item was deleted, select + // an item next to it + if (singleSelected && next != 0) + { + setSelected(next, true); + setCurrentItem(next); + } + setUpdatesEnabled(true); triggerUpdate(); } |
From: <ow...@bu...> - 2006-01-16 00:49:45
|
------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=119724 frank.osterfeld kdemail net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas pietzowski de ------- Additional Comments From frank.osterfeld kdemail net 2006-01-16 01:49 ------- *** Bug 118229 has been marked as a duplicate of this bug. *** |
From: Dotan C. <kd...@do...> - 2008-07-09 21:52:21
|
------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=119724 kde-2 dotancohen com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | ------- Additional Comments From kde-2 dotancohen com 2008-07-09 23:52 ------- This bug seems to have cropped up again in Akregator 1.2.50 on KDE 4.1 beta 2. Should I start a new bug, or reopen this one? To clarify, when deleting an entry, the next entry shows in the view pane, however, it is not selected. Therefore, the entry cannot be scrolled nor deleted. |