Thread: [aKregator-devel] Re: librss signals
Brought to you by:
lippel
From: Frerich R. <fr...@he...> - 2004-12-16 02:26:44
|
Moin, yes, it's possible to change the signal declarations in librss to explicitely mention the namespace, i.e. change Loader::loadingComplete( Loader *, Document, Status ) into Loader::loadingComplete( RSS::Loader *, RSS::Document, RSS:Status ) but please note that from moc's point of view, those are two entirely different signals, since moc isn't aware of the type but does a simple string-based comparison. As a consequence, every slot which you connect to such a signal must also have the namespace mentioned explicitely, which means that such a change will break source compatibility. I do not think that this is an issue for librss though (I'm only aware of two projects outside of KDE CVS which use librss, and one of them already asked for the same feature). IMHO, having to explicitely type 'RSS::' is still better than having to import a symbol using 'using RSS::Document;', especially given how generic the names in the RSS namespace are (Document, Article, Image, Status etc.). Hence I'm fine with this change. - Frerich P.S.: If you start hacking on either kdenetwork's librss or aKregator's librss, it would be most excellent if you could keep the other copy in sync as far as possible. That will make merging easier later. |