Menu

#32 Custom headers not implemented in upgrade.php

AKKAR_2.4
open-wont-fix
1
2006-12-05
2006-10-09
No

As of 2.4.0, you can define your own headers and
footers to replace mainheader.php and mainfooter.php.
However, upgrade.php does not implement this behaviour,
even though it uses whatever style is defined in the
main configuration.

Discussion

  • Helge Lund Kolstad

    Logged In: YES
    user_id=1188544

    Since upgrade.php does not use the standard mainheader.php
    and mainfooter.php, this will be difficult to fix.

     
  • Helge Lund Kolstad

    • summary: New style definitions not implemented in upgrade.php --> Custom headers not implemented in upgrade.php
     
  • Roy W. Andersen

    Roy W. Andersen - 2006-10-11

    Logged In: YES
    user_id=1181036

    This is actually intentional. Upgrade.php isn't something
    you run very often, and it was therefore decided to leave it
    as-is rather than trying to make it use the custom header
    and footer. The way custom headers and footers are
    implemented is more of a hack than anything else anyway
    (also intentional - a more sophisticated approach will be
    used in 3.0).

    I wouldn't bother with this one, but feel free to "fix" it
    if you really want to ;)

     
  • Helge Lund Kolstad

    Logged In: YES
    user_id=1188544

    Er, no. You'd have to do a diff between the standard
    mainheader.php and the one from the style, and likewise with
    mainfooter.php... and even then, you'd have no guarantees
    that you were inserting the thusly extracted lines in the
    proper places. I'll file this under "more trouble that it's
    worth" and leave it open for reference.

     
  • Helge Lund Kolstad

    • status: open --> open-wont-fix
     
  • Helge Lund Kolstad

    • priority: 3 --> 1
     

Log in to post a comment.