ADempiere ERP Business Suite / Bugs / #1883 No check of Actual, Budget, Statistical attribute

Bayu Cahya P - 2009-05-09

MJournal.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bayu Cahya P - 2009-05-09

migration_script_oracle.sql

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bayu Cahya P - 2009-05-09

migration_script_postgresql.sql

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bayu Cahya P - 2009-05-09

status: open --> open-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bayu Cahya P - 2009-05-09

Propose fixing this bug.

I am adding additional ad_message here. Since I have no rights to get dictionary id yet, I am proposing this patch and migration scripts.

Carlos, am I eligible to have a rights to get dictionary id?

regards
Bayu

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carlos Ruiz - 2009-05-09

Hi Bayu,

> Carlos, am I eligible to have a rights to get dictionary id?

Sent the password via e-mail. This is a service open for ALL developers and implementors.

BTW, when contributing a patch or solution for a tracker please set the Resolution in Remind meanwhile it's integrated - when integrated it will be changed to Accepted.

I checked the code and it seems ok.

Regards,

Carlos Ruiz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carlos Ruiz - 2009-05-09

status: open-works-for-me --> open-remind
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bayu Cahya P - 2009-05-10

Revision: 9233
Author: bayucahya
Date: 3:30:53 PM, Sunday, May 10, 2009
Message:
BF 2789319 No check of Actual, Budget, Statistical attribute (GL Journal)
----
Modified : /branches/adempiere343/base/src/org/compiere/model/MJournal.java
Added : /branches/adempiere343/migration/342s-trunk/445_BF_2789319_NocheckofActualBudgetStatisticalattribute_ora.sql
Added : /branches/adempiere343/migration/342s-trunk/postgresql/445_BF_2789319_NocheckofActualBudgetStatisticalattribute_pg.sql

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bayu Cahya P - 2009-05-10

status: open-remind --> pending-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carlos Ruiz - 2009-05-10

status: pending-fixed --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carlos Ruiz - 2009-05-10

Hi Bayu,

I appreciate you're working and helping to improve 343 - but this is not the proper way.
It's great to have more people helping Heng Sin and me to maintain 343.

Now, about revision 9233 - it's not right.

Nothing must go to 343 branch unless it has passed first (or at the same time in case of bug fixing) into trunk.

NOTE: Changing this rule would mean that 343 is a fork - what is a matter of a different discussion (I'm not saying that we can't fork - maybe if we fail in stabilizing trunk we can think on a stable fork, but it needs to be discussed a lot before)

Now, mostly I *prefer* to avoid adding migration scripts to 343 - this is to maintain the patches.jar easier.
If every patches.jar is accompanied by migration scripts - then the patching will be really hard for non-technicals.

So, I just release migration scripts for bug fixing.
When I need to add a message (like your case) - then I add the messages in trunk - and in 343 program I write the message plain in english.

That's what I'm used to do currently - it doesn't mean that we must stick to that - if you have better ideas I'm open to discuss them. For example possibility of releasing a 344 with the migration scripts for those messages, but as this is not strictly necessary, I prefer to follow KISS principle.
Summarizing:
- Everything must be contributed in trunk first
- The trunk work can be integrated in 343 - preferably avoiding migration scripts (that's a stopper to contribute new functionalities, that's why mostly 343 just receive bug fixing)

Regards,

Carlos Ruiz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bayu Cahya P - 2009-05-11

Hi Carlos,

> - Everything must be contributed in trunk first

I am just thinking to include this one to trunk also. Just needing some times to perform this one.

>- The trunk work can be integrated in 343 - preferably avoiding migration
scripts (that's a stopper to contribute new functionalities, that's why
mostly 343 just receive bug fixing)

If this is a best practice, we will following the rule. This is happen because of our lack of information about how to doing a contribution both to trunk or branches like 343.

For the ad_message itself, we are just following the writing method of the codes. While we wrote @DocControlledError@ for the previous message and the other one using plain English text, is it look good for the 343 codes?

Anyway, I am not in the positioning to against the rules. We will do our contribution with your guidance.

Thank you
Bayu Cahya P

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bayu Cahya P - 2009-05-11

Revision: 9236
Author: bayucahya
Date: 11:21:29 AM, Monday, May 11, 2009
Message:
Altering Revision: 9233
Fixing without create migration scripts.
Thanks Carlos for guiding me
----
Modified : /branches/adempiere343/base/src/org/compiere/model/MJournal.java
Deleted : /branches/adempiere343/migration/342s-trunk/445_BF_2789319_NocheckofActualBudgetStatisticalattribute_ora.sql
Deleted : /branches/adempiere343/migration/342s-trunk/postgresql/445_BF_2789319_NocheckofActualBudgetStatisticalattribute_pg.sql

Revision: 9237
Author: bayucahya
Date: 2:24:42 PM, Monday, May 11, 2009
Message:
BF [2789319] No check of Actual, Budget, Statistical attribute
----
Modified : /trunk/base/src/org/compiere/model/MJournal.java
Added : /trunk/migration/353a-trunk/oracle/464_BF2789319.sql
Added : /trunk/migration/353a-trunk/postgresql/464_BF2789319.sql

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bayu Cahya P - 2009-05-11

status: open-fixed --> pending-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

SourceForge Robot - 2009-05-26

status: pending-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

SourceForge Robot - 2009-05-26

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

No check of Actual, Budget, Statistical attribute

A full ERP system - moved to GitHub. See full description for details.

Group

Searches

Help

#1883 No check of Actual, Budget, Statistical attribute

Discussion