dbunit-developer Mailing List for dbUnit

Jeff this is awesome, thanks for being patient with me as i worked over 
the issues. It's great to see it's finally release.

On 1/25/25 10:16 PM, Jeff Jensen wrote:
> Thanks to the multiple contributors we have a new release with new 
> features, updates, and fixes.  Please refer to the changes report for 
> details:
> http://dbunit.sourceforge.net/dbunit/changes-report.html
>
> Note the big change in this release warranting a major version bump - 
> dbUnit now supports JUnit 5!  Thanks to Ed for all the detailed work 
> to make this happen.
>
> Changes in this version include:
>
> New features:
> o Add 'actual is null' and 'actual is not null' constants to 
> ValueComparers class  Issue: 250. Thanks to jeffjensen.
> o Add TableDecoratorDataSet and GeneratedColumnFilterSupport enabling 
> column filtering from datasets, such as computed columns  Issue: 232. 
> Thanks to rcd.
> o Configure Maven Wrapper for dbUnit builds.  Issue: 258. Thanks to 
> jeffjensen.
>
> Fixed Bugs:
> o Mark postgresql dependency as provided scope  Issue: 443. Thanks to 
> jeffjensen.
> o Fix NoClassDefFoundError for IOUtils  Issue: 445. Thanks to jeffjensen.
> o In PostgreSQLOidDataType.setSqlValue(), use connection.unwrap() to 
> get PGConnection.  Issue: 451. Thanks to wbiller.
> o In OracleNClobDataType.setSqlValue() and 
> OracleXMLTypeDataType.setSqlValue(), use connection.unwrap() to get 
> statement or resultset.  Issue: 444. Thanks to wbiller.
>
> Changes:
> o Upgrade dbUnit from JUnit 4 to JUnit 5  Issue: 222. Thanks to emann.
> o Update code for Modernizer plugin violations  Issue: 248. Thanks to 
> ajohnson.
>
>
>
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer

Thanks to the multiple contributors we have a new release with new
features, updates, and fixes.  Please refer to the changes report for
details:
http://dbunit.sourceforge.net/dbunit/changes-report.html

Note the big change in this release warranting a major version bump -
dbUnit now supports JUnit 5!  Thanks to Ed for all the detailed work to
make this happen.

Changes in this version include:

New features:
o Add 'actual is null' and 'actual is not null' constants to ValueComparers
class  Issue: 250. Thanks to jeffjensen.
o Add TableDecoratorDataSet and GeneratedColumnFilterSupport enabling
column filtering from datasets, such as computed columns  Issue: 232.
Thanks to rcd.
o Configure Maven Wrapper for dbUnit builds.  Issue: 258. Thanks to
jeffjensen.

Fixed Bugs:
o Mark postgresql dependency as provided scope  Issue: 443. Thanks to
jeffjensen.
o Fix NoClassDefFoundError for IOUtils  Issue: 445. Thanks to jeffjensen.
o In PostgreSQLOidDataType.setSqlValue(), use connection.unwrap() to get
PGConnection.  Issue: 451. Thanks to wbiller.
o In OracleNClobDataType.setSqlValue() and
OracleXMLTypeDataType.setSqlValue(), use connection.unwrap() to get
statement or resultset.  Issue: 444. Thanks to wbiller.

Changes:
o Upgrade dbUnit from JUnit 4 to JUnit 5  Issue: 222. Thanks to emann.
o Update code for Modernizer plugin violations  Issue: 248. Thanks to
ajohnson.

Thanks for reviewing them and reviving them, Ed!  Some comments in case
they help:

https://sourceforge.net/p/dbunit/code.git/merge-requests/3/

This is an old one. Is it even needed?

My last comment on it was on design/implementation notes.  I don't think we
should merge it as is.


https://sourceforge.net/p/dbunit/code.git/merge-requests/39/

Has some tests that failed in the past. I have not looked at the code yet.

No bug/feature SF ticket exists for it that I know of.  The MR has a test
but we should verify it's valid and it fixes a problem.  Last comment from
Andrew trying to process it shows a failed build.


https://sourceforge.net/p/dbunit/code.git/merge-requests/46/
> Looks like this was close Jeff commented a lot on it.

Yes, Luc was diligently working on refactoring with me but I failed to
continue in a timely manner.  IIRC, these improvements are good design
refactoring starts and needs more - it's not completed work and therefore
I'm not sure it's ready for merge(?).  I'm not sure that the next key
refactoring we've discussed will affect this.  We should discuss further
tho.


https://sourceforge.net/p/dbunit/code.git/merge-requests/50/
> I already sent a message on this one. I'm willing to help get this one
> merged and finished.

If wanting to continue this one, we can build locally, push to the GitLab
CI to see those results, code review, and consider it/update as needed.


Additionally, this branch has a performance improvement for
high-column-count tables:
https://sourceforge.net/p/dbunit/code.git/ci/jkearns-perf-impr/tree
Regretfully the Oracle tests failed with it; I was awaiting discussion/fix
replies but that didnt happen.
Notes on this bug issue: https://sourceforge.net/p/dbunit/bugs/401
I subsequently created this one too, to highlight needed action items:
https://sourceforge.net/p/dbunit/feature-requests/242


Lastly, more things to consider before the refactoring plans are some
feature and bug tickets with attached patches.  Usually these are small
file changes so perhaps we could quickly apply some.


On Thu, Jul 4, 2024 at 12:35 PM Edward Mann <e....@ed...> wrote:

> We have several merge requests that have been open for a long time. So i
> want to know which ones we want to keep and which ones anyone else is
> willing to work on to get over the finish line.
>
> I will work the merge requests or with other developers to get the
> requests we want merged. There are some plans for big refactoring coming
> up, so getting these in before will be best.
>
> https://sourceforge.net/p/dbunit/code.git/merge-requests/3/
>
> This is an old one. Is it even needed?
>
> https://sourceforge.net/p/dbunit/code.git/merge-requests/39/
>
> Has some tests that failed in the past. I have not looked at the code yet.
>
> https://sourceforge.net/p/dbunit/code.git/merge-requests/46/
>
> Looks like this was close Jeff commented allot on it.
>
> https://sourceforge.net/p/dbunit/code.git/merge-requests/50/
>
> I already sent a message on this one. I'm willing to help get this one
> merged and finished.
>
>
>
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>

We have several merge requests that have been open for a long time. So i 
want to know which ones we want to keep and which ones anyone else is 
willing to work on to get over the finish line.

I will work the merge requests or with other developers to get the 
requests we want merged. There are some plans for big refactoring coming 
up, so getting these in before will be best.

https://sourceforge.net/p/dbunit/code.git/merge-requests/3/

This is an old one. Is it even needed?

https://sourceforge.net/p/dbunit/code.git/merge-requests/39/

Has some tests that failed in the past. I have not looked at the code yet.

https://sourceforge.net/p/dbunit/code.git/merge-requests/46/

Looks like this was close Jeff commented allot on it.

https://sourceforge.net/p/dbunit/code.git/merge-requests/50/

I already sent a message on this one. I'm willing to help get this one 
merged and finished.

We have a new release with a single new feature:
o Add support for YAML dataset format  Issue: 244. Thanks to bjornbeskow.

Please refer to the changes report for details:
http://dbunit.sourceforge.net/dbunit/changes-report.html

Hi Björn,
Wondering if you have any further plans for this new feature and what
additional things you would like to work on?  I'm happy to help, please let
me know!


On Wed, Oct 11, 2023 at 10:44 PM Jeff Jensen <jj...@ap...> wrote:

> Your MR looks good (after you squash!).
>
> Congratulations, you now have committer privs.  You can commit the YAML
> feature when you are ready.
>
> Let's start a new thread and discuss what next items you want to work on.
>
> For our work, please always commit only on branches and have another
> person (mainly me these days) review before merge to master.
>
>
> On Sun, Oct 8, 2023 at 9:01 PM Jeff Jensen <jj...@ap...> wrote:
>
>> Hi Björn,
>>
>> I commented on the MR.  Not sure if you receive notifications from the
>> site or not, so also emailing you.  Please process those and let me know!
>>
>>
>> On Mon, Sep 25, 2023 at 2:15 PM Jeff Jensen <jj...@ap...> wrote:
>>
>>> Hi Björn,
>>>
>>> I fully appreciate the fact that you all probably have very limited time
>>>> for dbunit work
>>>
>>> Yes, multiple life events have prevented my prior level of dbUnit work
>>> :-( .  I assume that I will resume some dbUnit work again in some
>>> rather-future months, just not for the next few.
>>>
>>> I would gladly participate actively in dbunit maintenance
>>>
>>> Thank you for asking about this.  Most of the help that I trusted and
>>> added in the recent years have faded from continuing to help (as often
>>> happens in OS), so it remains with me.  It is a challenge to find trusted
>>> and interested developers!   You successfully completed a prior feature
>>> improvement to dbUnit.  Your interest is welcomed and I'm sure we'll move
>>> ahead with it.
>>>
>>> My first action would then of course be to incorporate the yaml dataset
>>>> support and release a new version.
>>>
>>> I have no personal interest in maintaining a YAML implementation or
>>> using it in dbUnit.  I recognize others such as yourself would like to have
>>> that feature.  Yes, granting you committer status implies that you would
>>> merge it! lol  And maintain it, of course!
>>>
>>> Working with the Moderniser plugin violations would be the obvious next
>>>> step.
>>>
>>> Continuing to modernize dbUnit further is a great requirement to do;
>>> plenty of tasks to discuss and do for that after cleaning up Moderniser.
>>> Of higher concern, some recent merge requests/updates/bug reports exist
>>> that need processing, probably best to process them first.
>>>
>>> > Let me know what you think!
>>> Hopefully I've answered what you are looking for in the above, please
>>> let me know your further questions and suggestions.
>>>
>>> Next, I will review your YAML MR in depth, then finalize committer
>>> decision.  Please allow me this next week to accomplish.
>>>
>>>
>>>  On Thu, Sep 21, 2023 at 5:37 AM Björn Beskow <bb...@gm...> wrote:
>>>
>>>> Hi all,
>>>>
>>>> I’ve been using DBUnit for very many years, in recent years mostly via
>>>> dbRider (https://github.com/database-rider/database-rider) since using
>>>> Yaml datasets has been a requirement.
>>>>
>>>> In my current assignment, I work with the Karate test framework, and
>>>> need to be able to work with Yaml datasets. I would like to use DBUnit
>>>> directly in this situation (without the extra dependencies to dbRider).
>>>> Hence I would really need the yaml dataset support, for which I have
>>>> submitted a pull request to dbunit some years ago.
>>>>
>>>> I fully appreciate the fact that you all probably have very limited
>>>> time for dbunit work. nnnnn My first action would then of course be to
>>>> incorporate the yaml dataset support and release a new version. Working
>>>> with the Moderniser plugin violations would be the obvious next step.
>>>>
>>>> Let me know what you think!
>>>>
>>>> Best regards
>>>> /Björn
>>>> _______________________________________________
>>>> dbunit-developer mailing list
>>>> dbu...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>>>>
>>>

I'm not sure if you receive notifications for comments on your MR, so I'm
ensuring you know with this email that I commented on it until I know you
receive MR notifications.  Let's continue the merge discussion on the MR.


On Tue, Feb 6, 2024 at 9:26 PM Jeff Jensen <jj...@ap...> wrote:

> Thank you for splitting them to separate deliveries; separates as we go
> are easier on reviewing and safer too.  We'll process the JUnit 5 changes
> first and then the others. I will review its MR soon and let you know!
>
> It seems you've progressed well, please let me know if you have any
> outstanding questions.
>
> Lastly, ensuring you've seen all the notes on this page:
> https://dbunit.sourceforge.net/dbunit/devguide.html
>
>
> On Tue, Jan 30, 2024 at 11:50 AM Edward Mann <e....@ed...> wrote:
>
>> I did a squash and a merge request just for the junit 5 test suite
>> update. It's allot of changes. I might need to run formatting again.
>>
>> I imported the java-codestyle-formatter.xml, but maybe because i'm on a
>> newer version of Eclipse format options are changed and it's causing
>> issues? Or it could be PEBKAC.
>>
>> I have the type parameters done as well. It's in my fork and once the
>> junit 5 changes are approved, i can create a merge request for that.
>> On 1/23/24 11:09, Edward Mann wrote:
>>
>>
>> On 1/22/24 22:11, Jeff Jensen wrote:
>>
>> Fantastic!!  Thank you very much for working on this migration effort!
>> Great to receive your email with progress info.
>>
>> I have used dbunit for years and want to continue to use it.
>>
>> That's great!  Thank you!  These are very useful changes you have in
>> progress.
>>
>> I don't have access to push to the SF repo
>>
>> Fork dbUnit master to your own SF account repo and do the commits there.
>> We'll need that for the final delivery merge to the dbUnit repos.
>>
>> Well look there... if i spent a little more time poking around i would
>> have found fork.. So i did fork it and pushed my changes there.
>>
>> https://sourceforge.net/u/emann/dbunit/ci/master/tree/
>>
>>
>> use assertj
>>
>> using mockito
>>
>> Those are fine choices.  assertj vs hamcrest is the main decision point.
>> Good to ask on and discuss needed decisions first to avoid any rework.
>>
>> If it's decided that assertj is not wanted but a different one, feel free
>> to change it. Won't hurt my feelings. It should be easy to write regex to
>> do the change. I wrote a set of them to help me with the initial conversion.
>>
>> Help: So in DbUnitAssertIT.java ...
>>
>> What help are you looking for?  Seems it's working for you but I may
>> misunderstand your point.
>>
>> Just wanted clarification that the expected output before has changed and
>> i should update tests to match. I did add "<" and ">" to the response. But
>> i'm thinking i should not do that just leave the message that
>> AssertionFailedError produces as-is and update tests "expected"
>>
>> See:
>> https://sourceforge.net/u/emann/dbunit/ci/dbunit-5/tree/src/main/java/org/dbunit/assertion/JUnitFailureFactory.java
>>
>>
>>
>> So far you've mentioned changes for JUnit 5 and Java 17.  Is it feasible
>> to keep this work as separate deliveries - basically separate commits, one
>> commit for each (and any additional for diff isolation, e.g. formatting,
>> renames, cleanup).  Good to not relate them if reasonably possible.  Can
>> deliver and merge one before finishing the other one.
>>
>> Junit package names have changed, so i already broke that when i removed
>> the junit dependency and went to junit 5.
>>
>> See:
>> https://sourceforge.net/u/emann/dbunit/ci/dbunit-5/tree/src/main/java/org/dbunit/assertion/comparer/value/ConditionalSelectorMultiValueComparer.java
>>
>> But other than that i can keep them separate.  Alpha 2 will only be Java
>> 17 updates. I was planning on making Beta-1 the actual junit-5 changes.
>>
>> Squashing the commits to as few as meaningful (e.g. removing intermittent
>> steps) will greatly help code reviews.  How soon are you ready to squash?
>>
>> Right now the changes are the test suite is all updated. I did start to
>> work on updating assertThrows to assertThatThrownBy. But now i'm thinking i
>> will leave it as a future task. As if i am ever in working in that test
>> suite again update it. It works and is updated and i have limited time.
>>
>> If you want a MR on the test suite update i can squash and submit that?
>>
>>
>> Are you also updating the dbUnit Maven plugin as needed to work with 17?
>>
>> I will put this in Alpha-2 as well. I saw it when i was looking up stuff.
>> I just didn't write it down on my list to update.
>>
>>
>> On Mon, Jan 22, 2024 at 8:21 PM Edward Mann <e....@ed...> wrote:
>>
>>> TLDR; I am updating dbunit to Junit5 see my progress here ->
>>> https://gitlab.com/ed_mann/dbunit
>>>
>>>
>>> I don't have access to push to the SF repo, so i am syncing my changes
>>> to gitlab.com for the time being.
>>>
>>> Progress so far
>>>
>>> Alpha-1 - 99% complete
>>>
>>> I have updated all the unit tests to Junit 5 and Java 17. I took the
>>> liberty to use assertj.
>>>
>>> I know i need to fix the assertThrows changes to using assertJ i will do
>>> that tonight. I tried to keep the code as close to original with
>>> messages as possible. All of the try/catch were converted to
>>> assertThrows if i missed one let me know. I think i got them all.
>>>
>>> The mock tests i updated to using mockito. Again i took the liberty to
>>> just choose a library to use. I feel no matter what i do, someone won't
>>> like it.
>>>
>>> The tests pass on my local... so please anyone feel free to try it out.
>>> Not much of the "production" code was updated. I did however add some
>>> type parameters and fixed a few instanceof, but i tried to keep it to a
>>> minimum. Allot of deprecated java code was updated. Like new Integer(12)
>>> and family was updated to Integer.valueOf(12); I have not run the tests
>>> against the container images. I will get that going on my local Jenkins
>>> instance.
>>>
>>> I am now working on Alpha-2 - 2 weeks of work i think
>>>
>>> This is going to be finishing up "production code" by getting all the
>>> type parameters in place, updating any warnings to be compliant with
>>> Java 17. Some of the code has been updated as i needed to while updating
>>> tests. Any deprecated java or dbunit code i will remove/update.
>>>
>>> Then off to Beta-1 Add last code changes for junit 5 support, update
>>> documentation on how to use dbunit in Junit 5. I would like by this time
>>> that a member of the dbunit team has reached out to me. I would like to
>>> have code review and releases done to maven central for others to be
>>> able to use. If anything i can change artifact to my domain and push a
>>> release. I really don't want to do that.
>>>
>>> Help: So in DbUnitAssertIT.java the older junit had a
>>> ComparisonCompactor that would enclose diffs in brackets. [o], but that
>>> is no longer the case.
>>> So i updated tests after searching for a way to turn that back on, but
>>> what i was finding was this is not doing that anymore on purpose to
>>> allow the IDE's to render the diff. I could be wrong.
>>>
>>>
>>> Please give feedback. I have used dbunit for years and want to continue
>>> to use it.
>>>
>>>
>>> Thanks for reading this far.
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> dbunit-developer mailing list
>>> dbu...@li...
>>> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>>>
>>
>>
>> _______________________________________________
>> dbunit-developer mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>>
>>
>>
>> _______________________________________________
>> dbunit-developer mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>>
>> _______________________________________________
>> dbunit-developer mailing list
>> dbu...@li...
>> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>>
>

Thank you for splitting them to separate deliveries; separates as we go are
easier on reviewing and safer too.  We'll process the JUnit 5 changes first
and then the others. I will review its MR soon and let you know!

It seems you've progressed well, please let me know if you have any
outstanding questions.

Lastly, ensuring you've seen all the notes on this page:
https://dbunit.sourceforge.net/dbunit/devguide.html


On Tue, Jan 30, 2024 at 11:50 AM Edward Mann <e....@ed...> wrote:

> I did a squash and a merge request just for the junit 5 test suite update.
> It's allot of changes. I might need to run formatting again.
>
> I imported the java-codestyle-formatter.xml, but maybe because i'm on a
> newer version of Eclipse format options are changed and it's causing
> issues? Or it could be PEBKAC.
>
> I have the type parameters done as well. It's in my fork and once the
> junit 5 changes are approved, i can create a merge request for that.
> On 1/23/24 11:09, Edward Mann wrote:
>
>
> On 1/22/24 22:11, Jeff Jensen wrote:
>
> Fantastic!!  Thank you very much for working on this migration effort!
> Great to receive your email with progress info.
>
> I have used dbunit for years and want to continue to use it.
>
> That's great!  Thank you!  These are very useful changes you have in
> progress.
>
> I don't have access to push to the SF repo
>
> Fork dbUnit master to your own SF account repo and do the commits there.
> We'll need that for the final delivery merge to the dbUnit repos.
>
> Well look there... if i spent a little more time poking around i would
> have found fork.. So i did fork it and pushed my changes there.
>
> https://sourceforge.net/u/emann/dbunit/ci/master/tree/
>
>
> use assertj
>
> using mockito
>
> Those are fine choices.  assertj vs hamcrest is the main decision point.
> Good to ask on and discuss needed decisions first to avoid any rework.
>
> If it's decided that assertj is not wanted but a different one, feel free
> to change it. Won't hurt my feelings. It should be easy to write regex to
> do the change. I wrote a set of them to help me with the initial conversion.
>
> Help: So in DbUnitAssertIT.java ...
>
> What help are you looking for?  Seems it's working for you but I may
> misunderstand your point.
>
> Just wanted clarification that the expected output before has changed and
> i should update tests to match. I did add "<" and ">" to the response. But
> i'm thinking i should not do that just leave the message that
> AssertionFailedError produces as-is and update tests "expected"
>
> See:
> https://sourceforge.net/u/emann/dbunit/ci/dbunit-5/tree/src/main/java/org/dbunit/assertion/JUnitFailureFactory.java
>
>
>
> So far you've mentioned changes for JUnit 5 and Java 17.  Is it feasible
> to keep this work as separate deliveries - basically separate commits, one
> commit for each (and any additional for diff isolation, e.g. formatting,
> renames, cleanup).  Good to not relate them if reasonably possible.  Can
> deliver and merge one before finishing the other one.
>
> Junit package names have changed, so i already broke that when i removed
> the junit dependency and went to junit 5.
>
> See:
> https://sourceforge.net/u/emann/dbunit/ci/dbunit-5/tree/src/main/java/org/dbunit/assertion/comparer/value/ConditionalSelectorMultiValueComparer.java
>
> But other than that i can keep them separate.  Alpha 2 will only be Java
> 17 updates. I was planning on making Beta-1 the actual junit-5 changes.
>
> Squashing the commits to as few as meaningful (e.g. removing intermittent
> steps) will greatly help code reviews.  How soon are you ready to squash?
>
> Right now the changes are the test suite is all updated. I did start to
> work on updating assertThrows to assertThatThrownBy. But now i'm thinking i
> will leave it as a future task. As if i am ever in working in that test
> suite again update it. It works and is updated and i have limited time.
>
> If you want a MR on the test suite update i can squash and submit that?
>
>
> Are you also updating the dbUnit Maven plugin as needed to work with 17?
>
> I will put this in Alpha-2 as well. I saw it when i was looking up stuff.
> I just didn't write it down on my list to update.
>
>
> On Mon, Jan 22, 2024 at 8:21 PM Edward Mann <e....@ed...> wrote:
>
>> TLDR; I am updating dbunit to Junit5 see my progress here ->
>> https://gitlab.com/ed_mann/dbunit
>>
>>
>> I don't have access to push to the SF repo, so i am syncing my changes
>> to gitlab.com for the time being.
>>
>> Progress so far
>>
>> Alpha-1 - 99% complete
>>
>> I have updated all the unit tests to Junit 5 and Java 17. I took the
>> liberty to use assertj.
>>
>> I know i need to fix the assertThrows changes to using assertJ i will do
>> that tonight. I tried to keep the code as close to original with
>> messages as possible. All of the try/catch were converted to
>> assertThrows if i missed one let me know. I think i got them all.
>>
>> The mock tests i updated to using mockito. Again i took the liberty to
>> just choose a library to use. I feel no matter what i do, someone won't
>> like it.
>>
>> The tests pass on my local... so please anyone feel free to try it out.
>> Not much of the "production" code was updated. I did however add some
>> type parameters and fixed a few instanceof, but i tried to keep it to a
>> minimum. Allot of deprecated java code was updated. Like new Integer(12)
>> and family was updated to Integer.valueOf(12); I have not run the tests
>> against the container images. I will get that going on my local Jenkins
>> instance.
>>
>> I am now working on Alpha-2 - 2 weeks of work i think
>>
>> This is going to be finishing up "production code" by getting all the
>> type parameters in place, updating any warnings to be compliant with
>> Java 17. Some of the code has been updated as i needed to while updating
>> tests. Any deprecated java or dbunit code i will remove/update.
>>
>> Then off to Beta-1 Add last code changes for junit 5 support, update
>> documentation on how to use dbunit in Junit 5. I would like by this time
>> that a member of the dbunit team has reached out to me. I would like to
>> have code review and releases done to maven central for others to be
>> able to use. If anything i can change artifact to my domain and push a
>> release. I really don't want to do that.
>>
>> Help: So in DbUnitAssertIT.java the older junit had a
>> ComparisonCompactor that would enclose diffs in brackets. [o], but that
>> is no longer the case.
>> So i updated tests after searching for a way to turn that back on, but
>> what i was finding was this is not doing that anymore on purpose to
>> allow the IDE's to render the diff. I could be wrong.
>>
>>
>> Please give feedback. I have used dbunit for years and want to continue
>> to use it.
>>
>>
>> Thanks for reading this far.
>>
>>
>>
>>
>> _______________________________________________
>> dbunit-developer mailing list
>> dbu...@li...
>> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>>
>
>
> _______________________________________________
> dbunit-developer mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>
>
>
> _______________________________________________
> dbunit-developer mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>

I did a squash and a merge request just for the junit 5 test suite 
update. It's allot of changes. I might need to run formatting again.

I imported the java-codestyle-formatter.xml, but maybe because i'm on a 
newer version of Eclipse format options are changed and it's causing 
issues? Or it could be PEBKAC.

I have the type parameters done as well. It's in my fork and once the 
junit 5 changes are approved, i can create a merge request for that.

On 1/23/24 11:09, Edward Mann wrote:
>
>
> On 1/22/24 22:11, Jeff Jensen wrote:
>> Fantastic!!  Thank you very much for working on this migration 
>> effort!  Great to receive your email with progress info.
>>
>>     I have used dbunit for years and want to continue to use it.
>>
>> That's great!  Thank you!  These are very useful changes you have in 
>> progress.
>>
>>     I don't have access to push to the SF repo
>>
>> Fork dbUnit master to your own SF account repo and do the commits 
>> there.  We'll need that for the final delivery merge to the dbUnit repos.
>
> Well look there... if i spent a little more time poking around i would 
> have found fork.. So i did fork it and pushed my changes there.
>
> https://sourceforge.net/u/emann/dbunit/ci/master/tree/
>
>>
>>     use assertj
>>
>>     using mockito
>>
>> Those are fine choices.  assertj vs hamcrest is the main decision 
>> point.  Good to ask on and discuss needed decisions first to avoid 
>> any rework.
>>
> If it's decided that assertj is not wanted but a different one, feel 
> free to change it. Won't hurt my feelings. It should be easy to write 
> regex to do the change. I wrote a set of them to help me with the 
> initial conversion.
>>
>>     Help: So in DbUnitAssertIT.java ...
>>
>> What help are you looking for?  Seems it's working for you but I may 
>> misunderstand your point.
>>
> Just wanted clarification that the expected output before has changed 
> and i should update tests to match. I did add "<" and ">" to the 
> response. But i'm thinking i should not do that just leave the message 
> that AssertionFailedError produces as-is and update tests "expected"
>
> See: 
> https://sourceforge.net/u/emann/dbunit/ci/dbunit-5/tree/src/main/java/org/dbunit/assertion/JUnitFailureFactory.java
>
>
>>
>> So far you've mentioned changes for JUnit 5 and Java 17.  Is it 
>> feasible to keep this work as separate deliveries - basically 
>> separate commits, one commit for each (and any additional for diff 
>> isolation, e.g. formatting, renames, cleanup).  Good to not relate 
>> them if reasonably possible. Can deliver and merge one before 
>> finishing the other one.
>>
> Junit package names have changed, so i already broke that when i 
> removed the junit dependency and went to junit 5.
>
> See: 
> https://sourceforge.net/u/emann/dbunit/ci/dbunit-5/tree/src/main/java/org/dbunit/assertion/comparer/value/ConditionalSelectorMultiValueComparer.java
>
> But other than that i can keep them separate.  Alpha 2 will only be 
> Java 17 updates. I was planning on making Beta-1 the actual junit-5 
> changes.
>
>> Squashing the commits to as few as meaningful (e.g. removing 
>> intermittent steps) will greatly help code reviews.  How soon are you 
>> ready to squash?
>>
> Right now the changes are the test suite is all updated. I did start 
> to work on updating assertThrows to assertThatThrownBy. But now i'm 
> thinking i will leave it as a future task. As if i am ever in working 
> in that test suite again update it. It works and is updated and i have 
> limited time.
>
> If you want a MR on the test suite update i can squash and submit that?
>
>>
>> Are you also updating the dbUnit Maven plugin as needed to work with 17?
>>
> I will put this in Alpha-2 as well. I saw it when i was looking up 
> stuff. I just didn't write it down on my list to update.
>>
>> On Mon, Jan 22, 2024 at 8:21 PM Edward Mann <e....@ed...> wrote:
>>
>>     TLDR; I am updating dbunit to Junit5 see my progress here ->
>>     https://gitlab.com/ed_mann/dbunit
>>
>>
>>     I don't have access to push to the SF repo, so i am syncing my
>>     changes
>>     to gitlab.com <http://gitlab.com> for the time being.
>>
>>     Progress so far
>>
>>     Alpha-1 - 99% complete
>>
>>     I have updated all the unit tests to Junit 5 and Java 17. I took the
>>     liberty to use assertj.
>>
>>     I know i need to fix the assertThrows changes to using assertJ i
>>     will do
>>     that tonight. I tried to keep the code as close to original with
>>     messages as possible. All of the try/catch were converted to
>>     assertThrows if i missed one let me know. I think i got them all.
>>
>>     The mock tests i updated to using mockito. Again i took the
>>     liberty to
>>     just choose a library to use. I feel no matter what i do, someone
>>     won't
>>     like it.
>>
>>     The tests pass on my local... so please anyone feel free to try
>>     it out.
>>     Not much of the "production" code was updated. I did however add
>>     some
>>     type parameters and fixed a few instanceof, but i tried to keep
>>     it to a
>>     minimum. Allot of deprecated java code was updated. Like new
>>     Integer(12)
>>     and family was updated to Integer.valueOf(12); I have not run the
>>     tests
>>     against the container images. I will get that going on my local
>>     Jenkins
>>     instance.
>>
>>     I am now working on Alpha-2 - 2 weeks of work i think
>>
>>     This is going to be finishing up "production code" by getting all
>>     the
>>     type parameters in place, updating any warnings to be compliant with
>>     Java 17. Some of the code has been updated as i needed to while
>>     updating
>>     tests. Any deprecated java or dbunit code i will remove/update.
>>
>>     Then off to Beta-1 Add last code changes for junit 5 support, update
>>     documentation on how to use dbunit in Junit 5. I would like by
>>     this time
>>     that a member of the dbunit team has reached out to me. I would
>>     like to
>>     have code review and releases done to maven central for others to be
>>     able to use. If anything i can change artifact to my domain and
>>     push a
>>     release. I really don't want to do that.
>>
>>     Help: So in DbUnitAssertIT.java the older junit had a
>>     ComparisonCompactor that would enclose diffs in brackets. [o],
>>     but that
>>     is no longer the case.
>>     So i updated tests after searching for a way to turn that back
>>     on, but
>>     what i was finding was this is not doing that anymore on purpose to
>>     allow the IDE's to render the diff. I could be wrong.
>>
>>
>>     Please give feedback. I have used dbunit for years and want to
>>     continue
>>     to use it.
>>
>>
>>     Thanks for reading this far.
>>
>>
>>
>>
>>     _______________________________________________
>>     dbunit-developer mailing list
>>     dbu...@li...
>>     https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>>
>>
>>
>> _______________________________________________
>> dbunit-developer mailing list
>> dbu...@li...
>> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>
>
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer

On 1/22/24 22:11, Jeff Jensen wrote:
> Fantastic!!  Thank you very much for working on this migration 
> effort!  Great to receive your email with progress info.
>
>     I have used dbunit for years and want to continue to use it.
>
> That's great!  Thank you!  These are very useful changes you have in 
> progress.
>
>     I don't have access to push to the SF repo
>
> Fork dbUnit master to your own SF account repo and do the commits 
> there.  We'll need that for the final delivery merge to the dbUnit repos.

Well look there... if i spent a little more time poking around i would 
have found fork.. So i did fork it and pushed my changes there.

https://sourceforge.net/u/emann/dbunit/ci/master/tree/

>
>     use assertj
>
>     using mockito
>
> Those are fine choices.  assertj vs hamcrest is the main decision 
> point.  Good to ask on and discuss needed decisions first to avoid any 
> rework.
>
If it's decided that assertj is not wanted but a different one, feel 
free to change it. Won't hurt my feelings. It should be easy to write 
regex to do the change. I wrote a set of them to help me with the 
initial conversion.
>
>     Help: So in DbUnitAssertIT.java ...
>
> What help are you looking for?  Seems it's working for you but I may 
> misunderstand your point.
>
Just wanted clarification that the expected output before has changed 
and i should update tests to match. I did add "<" and ">" to the 
response. But i'm thinking i should not do that just leave the message 
that AssertionFailedError produces as-is and update tests "expected"

See: 
https://sourceforge.net/u/emann/dbunit/ci/dbunit-5/tree/src/main/java/org/dbunit/assertion/JUnitFailureFactory.java


>
> So far you've mentioned changes for JUnit 5 and Java 17.  Is it 
> feasible to keep this work as separate deliveries - basically separate 
> commits, one commit for each (and any additional for diff isolation, 
> e.g. formatting, renames, cleanup).  Good to not relate them if 
> reasonably possible. Can deliver and merge one before finishing the 
> other one.
>
Junit package names have changed, so i already broke that when i removed 
the junit dependency and went to junit 5.

See: 
https://sourceforge.net/u/emann/dbunit/ci/dbunit-5/tree/src/main/java/org/dbunit/assertion/comparer/value/ConditionalSelectorMultiValueComparer.java

But other than that i can keep them separate.  Alpha 2 will only be Java 
17 updates. I was planning on making Beta-1 the actual junit-5 changes.

> Squashing the commits to as few as meaningful (e.g. removing 
> intermittent steps) will greatly help code reviews.  How soon are you 
> ready to squash?
>
Right now the changes are the test suite is all updated. I did start to 
work on updating assertThrows to assertThatThrownBy. But now i'm 
thinking i will leave it as a future task. As if i am ever in working in 
that test suite again update it. It works and is updated and i have 
limited time.

If you want a MR on the test suite update i can squash and submit that?

>
> Are you also updating the dbUnit Maven plugin as needed to work with 17?
>
I will put this in Alpha-2 as well. I saw it when i was looking up 
stuff. I just didn't write it down on my list to update.
>
> On Mon, Jan 22, 2024 at 8:21 PM Edward Mann <e....@ed...> wrote:
>
>     TLDR; I am updating dbunit to Junit5 see my progress here ->
>     https://gitlab.com/ed_mann/dbunit
>
>
>     I don't have access to push to the SF repo, so i am syncing my
>     changes
>     to gitlab.com <http://gitlab.com> for the time being.
>
>     Progress so far
>
>     Alpha-1 - 99% complete
>
>     I have updated all the unit tests to Junit 5 and Java 17. I took the
>     liberty to use assertj.
>
>     I know i need to fix the assertThrows changes to using assertJ i
>     will do
>     that tonight. I tried to keep the code as close to original with
>     messages as possible. All of the try/catch were converted to
>     assertThrows if i missed one let me know. I think i got them all.
>
>     The mock tests i updated to using mockito. Again i took the
>     liberty to
>     just choose a library to use. I feel no matter what i do, someone
>     won't
>     like it.
>
>     The tests pass on my local... so please anyone feel free to try it
>     out.
>     Not much of the "production" code was updated. I did however add some
>     type parameters and fixed a few instanceof, but i tried to keep it
>     to a
>     minimum. Allot of deprecated java code was updated. Like new
>     Integer(12)
>     and family was updated to Integer.valueOf(12); I have not run the
>     tests
>     against the container images. I will get that going on my local
>     Jenkins
>     instance.
>
>     I am now working on Alpha-2 - 2 weeks of work i think
>
>     This is going to be finishing up "production code" by getting all the
>     type parameters in place, updating any warnings to be compliant with
>     Java 17. Some of the code has been updated as i needed to while
>     updating
>     tests. Any deprecated java or dbunit code i will remove/update.
>
>     Then off to Beta-1 Add last code changes for junit 5 support, update
>     documentation on how to use dbunit in Junit 5. I would like by
>     this time
>     that a member of the dbunit team has reached out to me. I would
>     like to
>     have code review and releases done to maven central for others to be
>     able to use. If anything i can change artifact to my domain and
>     push a
>     release. I really don't want to do that.
>
>     Help: So in DbUnitAssertIT.java the older junit had a
>     ComparisonCompactor that would enclose diffs in brackets. [o], but
>     that
>     is no longer the case.
>     So i updated tests after searching for a way to turn that back on,
>     but
>     what i was finding was this is not doing that anymore on purpose to
>     allow the IDE's to render the diff. I could be wrong.
>
>
>     Please give feedback. I have used dbunit for years and want to
>     continue
>     to use it.
>
>
>     Thanks for reading this far.
>
>
>
>
>     _______________________________________________
>     dbunit-developer mailing list
>     dbu...@li...
>     https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>
>
>
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer

Fantastic!!  Thank you very much for working on this migration effort!
Great to receive your email with progress info.

I have used dbunit for years and want to continue to use it.

That's great!  Thank you!  These are very useful changes you have in
progress.

I don't have access to push to the SF repo

Fork dbUnit master to your own SF account repo and do the commits there.
We'll need that for the final delivery merge to the dbUnit repos.

use assertj

using mockito

Those are fine choices.  assertj vs hamcrest is the main decision point.
Good to ask on and discuss needed decisions first to avoid any rework.

Help: So in DbUnitAssertIT.java ...

What help are you looking for?  Seems it's working for you but I may
misunderstand your point.


So far you've mentioned changes for JUnit 5 and Java 17.  Is it feasible to
keep this work as separate deliveries - basically separate commits, one
commit for each (and any additional for diff isolation, e.g. formatting,
renames, cleanup).  Good to not relate them if reasonably possible.  Can
deliver and merge one before finishing the other one.

Squashing the commits to as few as meaningful (e.g. removing intermittent
steps) will greatly help code reviews.  How soon are you ready to squash?


Are you also updating the dbUnit Maven plugin as needed to work with 17?


On Mon, Jan 22, 2024 at 8:21 PM Edward Mann <e....@ed...> wrote:

> TLDR; I am updating dbunit to Junit5 see my progress here ->
> https://gitlab.com/ed_mann/dbunit
>
>
> I don't have access to push to the SF repo, so i am syncing my changes
> to gitlab.com for the time being.
>
> Progress so far
>
> Alpha-1 - 99% complete
>
> I have updated all the unit tests to Junit 5 and Java 17. I took the
> liberty to use assertj.
>
> I know i need to fix the assertThrows changes to using assertJ i will do
> that tonight. I tried to keep the code as close to original with
> messages as possible. All of the try/catch were converted to
> assertThrows if i missed one let me know. I think i got them all.
>
> The mock tests i updated to using mockito. Again i took the liberty to
> just choose a library to use. I feel no matter what i do, someone won't
> like it.
>
> The tests pass on my local... so please anyone feel free to try it out.
> Not much of the "production" code was updated. I did however add some
> type parameters and fixed a few instanceof, but i tried to keep it to a
> minimum. Allot of deprecated java code was updated. Like new Integer(12)
> and family was updated to Integer.valueOf(12); I have not run the tests
> against the container images. I will get that going on my local Jenkins
> instance.
>
> I am now working on Alpha-2 - 2 weeks of work i think
>
> This is going to be finishing up "production code" by getting all the
> type parameters in place, updating any warnings to be compliant with
> Java 17. Some of the code has been updated as i needed to while updating
> tests. Any deprecated java or dbunit code i will remove/update.
>
> Then off to Beta-1 Add last code changes for junit 5 support, update
> documentation on how to use dbunit in Junit 5. I would like by this time
> that a member of the dbunit team has reached out to me. I would like to
> have code review and releases done to maven central for others to be
> able to use. If anything i can change artifact to my domain and push a
> release. I really don't want to do that.
>
> Help: So in DbUnitAssertIT.java the older junit had a
> ComparisonCompactor that would enclose diffs in brackets. [o], but that
> is no longer the case.
> So i updated tests after searching for a way to turn that back on, but
> what i was finding was this is not doing that anymore on purpose to
> allow the IDE's to render the diff. I could be wrong.
>
>
> Please give feedback. I have used dbunit for years and want to continue
> to use it.
>
>
> Thanks for reading this far.
>
>
>
>
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>

TLDR; I am updating dbunit to Junit5 see my progress here -> 
https://gitlab.com/ed_mann/dbunit


I don't have access to push to the SF repo, so i am syncing my changes 
to gitlab.com for the time being.

Progress so far

Alpha-1 - 99% complete

I have updated all the unit tests to Junit 5 and Java 17. I took the 
liberty to use assertj.

I know i need to fix the assertThrows changes to using assertJ i will do 
that tonight. I tried to keep the code as close to original with 
messages as possible. All of the try/catch were converted to 
assertThrows if i missed one let me know. I think i got them all.

The mock tests i updated to using mockito. Again i took the liberty to 
just choose a library to use. I feel no matter what i do, someone won't 
like it.

The tests pass on my local... so please anyone feel free to try it out. 
Not much of the "production" code was updated. I did however add some 
type parameters and fixed a few instanceof, but i tried to keep it to a 
minimum. Allot of deprecated java code was updated. Like new Integer(12) 
and family was updated to Integer.valueOf(12); I have not run the tests 
against the container images. I will get that going on my local Jenkins 
instance.

I am now working on Alpha-2 - 2 weeks of work i think

This is going to be finishing up "production code" by getting all the 
type parameters in place, updating any warnings to be compliant with 
Java 17. Some of the code has been updated as i needed to while updating 
tests. Any deprecated java or dbunit code i will remove/update.

Then off to Beta-1 Add last code changes for junit 5 support, update 
documentation on how to use dbunit in Junit 5. I would like by this time 
that a member of the dbunit team has reached out to me. I would like to 
have code review and releases done to maven central for others to be 
able to use. If anything i can change artifact to my domain and push a 
release. I really don't want to do that.

Help: So in DbUnitAssertIT.java the older junit had a 
ComparisonCompactor that would enclose diffs in brackets. [o], but that 
is no longer the case.
So i updated tests after searching for a way to turn that back on, but 
what i was finding was this is not doing that anymore on purpose to 
allow the IDE's to render the diff. I could be wrong.


Please give feedback. I have used dbunit for years and want to continue 
to use it.


Thanks for reading this far.

Your MR looks good (after you squash!).

Congratulations, you now have committer privs.  You can commit the YAML
feature when you are ready.

Let's start a new thread and discuss what next items you want to work on.

For our work, please always commit only on branches and have another person
(mainly me these days) review before merge to master.


On Sun, Oct 8, 2023 at 9:01 PM Jeff Jensen <jj...@ap...> wrote:

> Hi Björn,
>
> I commented on the MR.  Not sure if you receive notifications from the
> site or not, so also emailing you.  Please process those and let me know!
>
>
> On Mon, Sep 25, 2023 at 2:15 PM Jeff Jensen <jj...@ap...> wrote:
>
>> Hi Björn,
>>
>> I fully appreciate the fact that you all probably have very limited time
>>> for dbunit work
>>
>> Yes, multiple life events have prevented my prior level of dbUnit work
>> :-( .  I assume that I will resume some dbUnit work again in some
>> rather-future months, just not for the next few.
>>
>> I would gladly participate actively in dbunit maintenance
>>
>> Thank you for asking about this.  Most of the help that I trusted and
>> added in the recent years have faded from continuing to help (as often
>> happens in OS), so it remains with me.  It is a challenge to find trusted
>> and interested developers!   You successfully completed a prior feature
>> improvement to dbUnit.  Your interest is welcomed and I'm sure we'll move
>> ahead with it.
>>
>> My first action would then of course be to incorporate the yaml dataset
>>> support and release a new version.
>>
>> I have no personal interest in maintaining a YAML implementation or using
>> it in dbUnit.  I recognize others such as yourself would like to have that
>> feature.  Yes, granting you committer status implies that you would merge
>> it! lol  And maintain it, of course!
>>
>> Working with the Moderniser plugin violations would be the obvious next
>>> step.
>>
>> Continuing to modernize dbUnit further is a great requirement to do;
>> plenty of tasks to discuss and do for that after cleaning up Moderniser.
>> Of higher concern, some recent merge requests/updates/bug reports exist
>> that need processing, probably best to process them first.
>>
>> > Let me know what you think!
>> Hopefully I've answered what you are looking for in the above, please let
>> me know your further questions and suggestions.
>>
>> Next, I will review your YAML MR in depth, then finalize committer
>> decision.  Please allow me this next week to accomplish.
>>
>>
>>  On Thu, Sep 21, 2023 at 5:37 AM Björn Beskow <bb...@gm...> wrote:
>>
>>> Hi all,
>>>
>>> I’ve been using DBUnit for very many years, in recent years mostly via
>>> dbRider (https://github.com/database-rider/database-rider) since using
>>> Yaml datasets has been a requirement.
>>>
>>> In my current assignment, I work with the Karate test framework, and
>>> need to be able to work with Yaml datasets. I would like to use DBUnit
>>> directly in this situation (without the extra dependencies to dbRider).
>>> Hence I would really need the yaml dataset support, for which I have
>>> submitted a pull request to dbunit some years ago.
>>>
>>> I fully appreciate the fact that you all probably have very limited time
>>> for dbunit work. I would gladly participate actively in dbunit maintenance,
>>> if you would allow me. My first action would then of course be to
>>> incorporate the yaml dataset support and release a new version. Working
>>> with the Moderniser plugin violations would be the obvious next step.
>>>
>>> Let me know what you think!
>>>
>>> Best regards
>>> /Björn
>>> _______________________________________________
>>> dbunit-developer mailing list
>>> dbu...@li...
>>> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>>>
>>

Hi Björn,

I commented on the MR.  Not sure if you receive notifications from the site
or not, so also emailing you.  Please process those and let me know!


On Mon, Sep 25, 2023 at 2:15 PM Jeff Jensen <jj...@ap...> wrote:

> Hi Björn,
>
> I fully appreciate the fact that you all probably have very limited time
>> for dbunit work
>
> Yes, multiple life events have prevented my prior level of dbUnit work :-(
> .  I assume that I will resume some dbUnit work again in some rather-future
> months, just not for the next few.
>
> I would gladly participate actively in dbunit maintenance
>
> Thank you for asking about this.  Most of the help that I trusted and
> added in the recent years have faded from continuing to help (as often
> happens in OS), so it remains with me.  It is a challenge to find trusted
> and interested developers!   You successfully completed a prior feature
> improvement to dbUnit.  Your interest is welcomed and I'm sure we'll move
> ahead with it.
>
> My first action would then of course be to incorporate the yaml dataset
>> support and release a new version.
>
> I have no personal interest in maintaining a YAML implementation or using
> it in dbUnit.  I recognize others such as yourself would like to have that
> feature.  Yes, granting you committer status implies that you would merge
> it! lol  And maintain it, of course!
>
> Working with the Moderniser plugin violations would be the obvious next
>> step.
>
> Continuing to modernize dbUnit further is a great requirement to do;
> plenty of tasks to discuss and do for that after cleaning up Moderniser.
> Of higher concern, some recent merge requests/updates/bug reports exist
> that need processing, probably best to process them first.
>
> > Let me know what you think!
> Hopefully I've answered what you are looking for in the above, please let
> me know your further questions and suggestions.
>
> Next, I will review your YAML MR in depth, then finalize committer
> decision.  Please allow me this next week to accomplish.
>
>
>  On Thu, Sep 21, 2023 at 5:37 AM Björn Beskow <bb...@gm...> wrote:
>
>> Hi all,
>>
>> I’ve been using DBUnit for very many years, in recent years mostly via
>> dbRider (https://github.com/database-rider/database-rider) since using
>> Yaml datasets has been a requirement.
>>
>> In my current assignment, I work with the Karate test framework, and need
>> to be able to work with Yaml datasets. I would like to use DBUnit directly
>> in this situation (without the extra dependencies to dbRider). Hence I
>> would really need the yaml dataset support, for which I have submitted a
>> pull request to dbunit some years ago.
>>
>> I fully appreciate the fact that you all probably have very limited time
>> for dbunit work. I would gladly participate actively in dbunit maintenance,
>> if you would allow me. My first action would then of course be to
>> incorporate the yaml dataset support and release a new version. Working
>> with the Moderniser plugin violations would be the obvious next step.
>>
>> Let me know what you think!
>>
>> Best regards
>> /Björn
>> _______________________________________________
>> dbunit-developer mailing list
>> dbu...@li...
>> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>>
>

Hi Björn,

I fully appreciate the fact that you all probably have very limited time
> for dbunit work

Yes, multiple life events have prevented my prior level of dbUnit work :-(
.  I assume that I will resume some dbUnit work again in some rather-future
months, just not for the next few.

I would gladly participate actively in dbunit maintenance

Thank you for asking about this.  Most of the help that I trusted and added
in the recent years have faded from continuing to help (as often happens in
OS), so it remains with me.  It is a challenge to find trusted and
interested developers!   You successfully completed a prior feature
improvement to dbUnit.  Your interest is welcomed and I'm sure we'll move
ahead with it.

My first action would then of course be to incorporate the yaml dataset
> support and release a new version.

I have no personal interest in maintaining a YAML implementation or using
it in dbUnit.  I recognize others such as yourself would like to have that
feature.  Yes, granting you committer status implies that you would merge
it! lol  And maintain it, of course!

Working with the Moderniser plugin violations would be the obvious next
> step.

Continuing to modernize dbUnit further is a great requirement to do; plenty
of tasks to discuss and do for that after cleaning up Moderniser.  Of
higher concern, some recent merge requests/updates/bug reports exist that
need processing, probably best to process them first.

> Let me know what you think!
Hopefully I've answered what you are looking for in the above, please let
me know your further questions and suggestions.

Next, I will review your YAML MR in depth, then finalize committer
decision.  Please allow me this next week to accomplish.


 On Thu, Sep 21, 2023 at 5:37 AM Björn Beskow <bb...@gm...> wrote:

> Hi all,
>
> I’ve been using DBUnit for very many years, in recent years mostly via
> dbRider (https://github.com/database-rider/database-rider) since using
> Yaml datasets has been a requirement.
>
> In my current assignment, I work with the Karate test framework, and need
> to be able to work with Yaml datasets. I would like to use DBUnit directly
> in this situation (without the extra dependencies to dbRider). Hence I
> would really need the yaml dataset support, for which I have submitted a
> pull request to dbunit some years ago.
>
> I fully appreciate the fact that you all probably have very limited time
> for dbunit work. I would gladly participate actively in dbunit maintenance,
> if you would allow me. My first action would then of course be to
> incorporate the yaml dataset support and release a new version. Working
> with the Moderniser plugin violations would be the obvious next step.
>
> Let me know what you think!
>
> Best regards
> /Björn
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>

Hi all,

I’ve been using DBUnit for very many years, in recent years mostly via dbRider (https://github.com/database-rider/database-rider <https://github.com/database-rider/database-rider>) since using Yaml datasets has been a requirement.

In my current assignment, I work with the Karate test framework, and need to be able to work with Yaml datasets. I would like to use DBUnit directly in this situation (without the extra dependencies to dbRider). Hence I would really need the yaml dataset support, for which I have submitted a pull request to dbunit some years ago.

I fully appreciate the fact that you all probably have very limited time for dbunit work. I would gladly participate actively in dbunit maintenance, if you would allow me. My first action would then of course be to incorporate the yaml dataset support and release a new version. Working with the Moderniser plugin violations would be the obvious next step.

Let me know what you think!

Best regards
/Björn

Thanks to Bjorn we have a new release with a new import data set feature.
Please refer to the changes report for details:
http://dbunit.sourceforge.net/dbunit-maven-plugin/changes-report.html

Changes in this version include:

New features:
o Create composite dataset from multiple source files.  Issue: 5. Thanks to
bjornbeskow.

Changes:
o Update dbUnit version to 2.7.3. Thanks to jeffjensen.

Thanks to the multiple contributors we have a new release with new
features, updates, and fixes.  Please refer to the changes report for
details:
http://dbunit.sourceforge.net/dbunit/changes-report.html

Changes in this version include:

New features:
o Enable composing an Operation dataset from multiple source files.  Issue:
5. Thanks to bjornbeskow.
o Add 'actual is null' and 'actual is not null' ValueComparers  Issue: 250.
Thanks to jeffjensen.

Fixed Bugs:
o Nullable UUID column in PostgreSQL caused NPE  Issue: 439. Thanks to
xobotun.
o Timestamp conversion for instants during daylight saving time is off
 Issue: 438. Thanks to jammule.
o Unwrap PGConnection instead of casting to it  Issue: 436. Thanks to
sfranson.

Changes:
o OracleClobDataType: Use non-deprecated CLOB; also prevents
ClassCastException  Issue: 240. Thanks to bambaro.
o Upgrade PostGIS JDBC driver to 2021.1.0  Issue: 251. Thanks to mprins.

patch attached to 
https://sourceforge.net/p/dbunit/feature-requests/251/#c93c

- M

On 20-12-2021 15:40, Jeff Jensen wrote:
> Hi Mark,
> Thanks for reporting.
> Yes, we can update.  Please first create a feature request ticket: 
> https://sourceforge.net/p/dbunit/feature-requests 
> <https://sourceforge.net/p/dbunit/feature-requests>.  Best for faster 
> time-wise if you can create a merge request or attach a patch to the 
> ticket that has a clean build.  Then you can locally verify it works 
> with your apps to help ensure no other issues.
> Note on the changes.xml, commits, testing: 
> http://dbunit.sourceforge.net/dbunit/devguide.html 
> <http://dbunit.sourceforge.net/dbunit/devguide.html>
> 

created https://sourceforge.net/p/dbunit/feature-requests/251/
Will work on a patch or MR

Mark

Hi Mark,
Thanks for reporting.
Yes, we can update.  Please first create a feature request ticket:
https://sourceforge.net/p/dbunit/feature-requests.  Best for faster
time-wise if you can create a merge request or attach a patch to the ticket
that has a clean build.  Then you can locally verify it works with your
apps to help ensure no other issues.
Note on the changes.xml, commits, testing:
http://dbunit.sourceforge.net/dbunit/devguide.html



On Mon, Dec 20, 2021 at 7:00 AM Mark Prins <mc....@gm...> wrote:

> After upgrading the PostGIS drivers (to 2021.1.0) in one of my projects
> I see failing tests (with org.dbunit.dataset.datatype.TypeCastException
> and java.lang.ClassNotFoundException) because DBunit can no longer
> access "org.postgis.PGgeometry"
>
> The PostGIS JDBC project released 2021.1.0 on Aug 5 of this year and has
> changed the package names to become properly modular. see
> https://github.com/postgis/postgis-java/releases/tag/v2021.1.0
>
> problematic build / stack trace:
>
> https://github.com/B3Partners/brmo/runs/4581591644?check_suite_focus=true#step:16:75
>
> Any chance we can have DBunit use "net.postgis.PGgeometry" in the next
> release?
>
> I checked the main pom file, but it seems PostGIS dependencies are not
> even declared..
>
> thanks, Mark
>
>
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>

After upgrading the PostGIS drivers (to 2021.1.0) in one of my projects 
I see failing tests (with org.dbunit.dataset.datatype.TypeCastException 
and java.lang.ClassNotFoundException) because DBunit can no longer 
access "org.postgis.PGgeometry"

The PostGIS JDBC project released 2021.1.0 on Aug 5 of this year and has 
changed the package names to become properly modular. see 
https://github.com/postgis/postgis-java/releases/tag/v2021.1.0

problematic build / stack trace: 
https://github.com/B3Partners/brmo/runs/4581591644?check_suite_focus=true#step:16:75

Any chance we can have DBunit use "net.postgis.PGgeometry" in the next 
release?

I checked the main pom file, but it seems PostGIS dependencies are not 
even declared..

thanks, Mark

Great news, thank you for sharing!


On Tue, Nov 2, 2021 at 4:04 AM Mark Prins <mc....@gm...> wrote:

> On 30-10-2021 21:06, Jeff Jensen wrote:
> > Four changes merged to 2.7.3-SNAPSHOT and published.  Thank you to the
> > contributors!
> > http://dbunit.sourceforge.net/dbunit/changes-report.html#a2.7.3-SNAPSHOT
> > <
> http://dbunit.sourceforge.net/dbunit/changes-report.html#a2.7.3-SNAPSHOT>
> >
> > Please test and let us know if it works and of any issues, thank you!
> >
>
> I've created a branch/PR [0] with the new snapshot and all our test pass
> (against Oracle XE/PostgreSQL and MS SQL Server)
>
> [0] https://github.com/B3Partners/brmo/pull/1201
>
> - M
>
>
> _______________________________________________
> dbunit-developer mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbunit-developer
>

On 30-10-2021 21:06, Jeff Jensen wrote:
> Four changes merged to 2.7.3-SNAPSHOT and published.  Thank you to the 
> contributors!
> http://dbunit.sourceforge.net/dbunit/changes-report.html#a2.7.3-SNAPSHOT 
> <http://dbunit.sourceforge.net/dbunit/changes-report.html#a2.7.3-SNAPSHOT>
> 
> Please test and let us know if it works and of any issues, thank you!
> 

I've created a branch/PR [0] with the new snapshot and all our test pass 
(against Oracle XE/PostgreSQL and MS SQL Server)

[0] https://github.com/B3Partners/brmo/pull/1201

- M

Four changes merged to 2.7.3-SNAPSHOT and published.  Thank you to the
contributors!
http://dbunit.sourceforge.net/dbunit/changes-report.html#a2.7.3-SNAPSHOT

Please test and let us know if it works and of any issues, thank you!