Analysis failed (simplifyEnum)

[amaigil2]

The attached code returns Analysis failed. If the code is valid then please report this failure.

However it is valid code.

[amaigil2]

Example code

[danielmarjamaki]

thank you for reducing your code and reporting it. I'll try to fix it

[amaigil2]

Replying to danielmarjamaki:

thank you for reducing your code and reporting it. I'll try to fix it

BTW, I think that is a regression since short time. That code probably didn't change on my side, and cppcheck never worried about it.

[danielmarjamaki]

This seems to be too complicated to fix now.

[danielmarjamaki]

This seems to be too complicated to fix now.

I can fix it now.. but I fail to reproduce with latest git head.

[danielmarjamaki]

I can reproduce with cppcheck-1.55. So I assume that this is fixed.

[amaigil2]

I can confirm the fix!

[amaigil2]

Unfortunately today I see the same problem again :-(

[danielmarjamaki]

I guess this is fixed by the new enum handling.

I reverted the new enum handling with:
0254344df53d543359d1dfac4f1c35a3070842a3

and then the "analysis failed" came back.

I intend to re-add the new enum handling later.

[iobyte]

Please add the scope tracking code from simplifyTypedef before doing anything else to simplifyEnum. It should be pretty much cut and paste since simplifyEnum started out as a cut and pasted simplifyTypedef. Unfortunately simplifyEnum didn't get the scope tracking code when it was added to simplifyTypedef.

That should fix code like this:

struct Fred {
    enum { X = 5 };
    int foo();
};

int Fred::Foo() {
    return X;
}

from being tokenized like this:

1: struct Fred {
2:
3: int foo ( ) ;
4: } ;
5:
6: int Fred :: Foo ( ) {
7: return X ;
8: }

Class enum support is really broken now so that should be fixed first before any optimizations are added back that further diverge simplifyEnum from simplifyTypedef.

[iobyte]

Here is a better scope test:

namespace N {
    class C {
    public:
        struct Fred {
            enum { X = 5 };
            int foo();
        };
    };
}

int N::C::Fred::foo() {
    return X;
}

[iobyte]

Fixing the scope problem should also fix #4025 which should be reopened until a proper scope tracking fix is introduced.

[pkeus]

#4025 is fixed and I think, it should remain closed.

[danielmarjamaki]

Please add the scope tracking code from simplifyTypedef before doing anything else to simplifyEnum. It should be pretty much cut and paste since simplifyEnum started out as a cut and pasted simplifyTypedef.

sounds good. if you have the time.. it would be nice with a patch.

[iobyte]

Here is a patch for the TODO test.

[danielmarjamaki]

I am not really sure this is a simplifyEnum bug after all.

I reduced your code to:

a<(b>c)> d;

That gives a "Analysis failed" message both with latest git head and 1.56.

[amai]

Talking about the initial example, after PKEuS's https://github.com/danmar/cppcheck/commit/d44f10fc0147b8d7c6506ebe420e6d666c62ab47 the error is gone!