Activity for William Cohen
-
William Cohen posted a comment on merge request #4
I overlooked the previous configure setting.
-
Remove non-Posix use of FTW_ACTIONRETVAL
-
Going to close this because oprofile, commit 5ed9bda8baf7465172a99ff86ed7f46397b06c7f addresses this.
-
The limitation to this approach is that builds are only repeatable if they are built in the same day. Maybe something like https://reproducible-builds.org/docs/source-date-epoch/ would provide more reproducible builds. Also reproducible is spelled as "reproducidle" in 0e4969.
-
Sorry. I didn't see this pull request until now. A similar patch was submitted and has been merged into oprofile, commit 5ed9bda8baf7465172a99ff86ed7f46397b06c7f .
-
ocount leaves orphan process on error
-
Does not build with binutils-gdb master.
-
Does not build with binutils-gdb master.
-
Could you try the current master branch of oprofile and verify that this fixes the reported problem?
-
There are still a number of distributions that have older bersions of binutils. This needs to be conditional so oprofile can be compiled with the older binutils. Should have a set of wrapper defines in another header file and have a a test in configure.ac to select the correct wrappers. I have put a patch that does that on https://sourceforge.net/p/oprofile/oprofile/ci/bfd234/tree/ The patch allow oprofile to build on fedora 30 (binutils 2.31) and fedora rawhide (binutils 2.34). If the patch looks...
-
What does the strace output look like for the oprofile-1.1.0 operf? Does the oprofile-1.1.0 build have any patches in it? Or is it the completely stock oprofile-1.1.0?
-
It doesn't look like "Operation not support" is coming from operf. The message doesn't seem to be in the oprofile source code. could you do a "which operf" to check to see which operf is being run? Could you give more destails on how oprofile-1.3.0 was built and installed on the machine? Where is oprofile installed on the machine? You might try to use the full path to make sure that the desired one is being used. Is it possible run "strace operf --version" to get a better idea when and where things...
-
ocount leaves orphan process on error
-
I massaged the patch as it wasn't formatted quite right and didn't apply with a "git am". The logic seems reasonable and I verified that the patch fixed the stated problem. It is now in the upstrem oprofile git repository. Thanks.
-
Could you separate the the test and the actual fix in the patch into two separate patches? Right now they are all combined and done want that for the actual commit. The logic looks reasonable but would like to test thing a bit with the split patches.
-
Power8: a few event misspellings with ophelp
-
Fixed by the following patch that is in oprofile-1.2.0: commit 6fcd5aa57482a58fcb0166982fed517fbf7040fb Author: Carl E. Love cel@us.ibm.com Date: Thu Mar 17 13:49:41 2016 -0700 POWER 8 processor event spelling fixes Will: Here is a patch to fix the spelling errors in the Power 8 events. See OProfile bugzilla number 281. This patch corrects the spelling errors. Carl Love ------------------------------------------------------------ POWER 8 processor event spelling fixes. Fixed the spelling of six of...
-
remove unsupported POWER8 PMU events from OProfile/libpfm4
-
No manpage for opjitconv binary
-
A man for opjitconv added with git commit 51f2b9495971
-
-
Rather than disabling the gcc truncation check maybe have something like the attached patch to check the return values of snprintf to see if they are in the expected range.
-
I think in the future that you can use an interactive rebase as described in the following URL to massage the patch to cleanly include the revisions: https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
-
This looks like it has been merged in already. Sholdn't this be closed?
-
Should add some checks in tests/valide_arm64.c to check that some of the thunderx 2 events are there.
-
Is there a pointer to documentation describing the events? If that is available, it would be good to mention that in the comments of file with the events.
-
In include/perfmon/pfmlib.h new processor enumerations are suppose to be placed right before: /* MUST ADD NEW PMU MODELS HERE */ This is to avoid changing the existing enum values between versions. As a sanity check diffed arm_cortex_a53_events.h and arm_cavium_tx2_events.h to see if anything was way off on the common events. Looks cortex a53 might need to update some of the name and descriptions. Also checked the names against the kernel perf tool entries in armv8-recommended.json. BUS_ACCESS_LD...
-
According to https://wiki.debian.org/ReproducibleBuilds/TimestampsFromCPPMacros The DATE and TIME defines are already addressed by a patch to gcc.
-
A similar change is needed in libutil/op_version.c replacing the c preprocessor DATE and TIME defines. There was some earlier discussion on the mailing list on this, should revise that work to use the DATE from the configure.
-
make build reproducible
-
oprofile fails to build with --enable-pch and gcc-6.2
-
Fixed in oprofile-1.2.0
-
Fixed in oprofile-1.2.0
-
Compilation error: left shift of negative value
-
Compilation error: left shift of negative value
-
oprofile fails to build with --enable-pch and gcc-6.2
-
commit a22dd3c3a609ea4dfe570cd2d830b91ce094301b should address this issue.
-
The suggested change looks fine. What should I use for name and email address for...
-
You haven't stated what distribution the host system is running. That would decide...
-
Whether oprofile works on a guest vm depends on the hosts support of performance...
-
Thanks for the report. The fix has been pushed into the upstrem oprofile git rep...
-
The following patch has been checked in to address this issue commit 6fcd5aa57482a58fcb0166982fed517fbf7040fb...
-
Power8: a few event misspellings with ophelp
-
Is the availability of these events affected by the kernel being used? Or are these...
-
oprofile-1.0.0 fails to recognize AMD Athlon-XP CPU
-
Missing <time.h> include
-
This can replicated on x86_64 fedora 21 with: $ CPPFLAGS=-D_GLIBCXX_DEBUG ./configure...
-
This should be fixed by commit b27bc6dab22b1dea5950e31d9286ba449bdc2a5c in oprofile-tests...
-
Oprofile-tests fix mode scalling tests to run only on arch that support mode scaling.
-
oprofile-1.0.0 fails to recognize AMD Athlon-XP CPU
-
Added parenthesis to the patch to ensure that newer compilers do not complain about...
-
opreport: incorrect event info when using named unit mask
-
The patch was commit to the oprofile git repository 2013-01-28. Did a check to verify...
-
Count discrepancy in ia64 assembly annotation
-
Given that oprofile has only had ia64 support through the userspace oprofile daemon...
-
Missing <time.h> include
-
Oprofile does affinitize past 1024 cpus.
-
All the code in daemon directory was removed by commit 0c142c3a096d3e9ec42cc9b0ddad994fea60d135...
-
This patch looks good and has been added to the git repository.
-
If you are using the Ubuntu release of oprofile, you should also file an Ubuntu bug...
-
Use libunwind for more accurate callgraph profiling
1