Activity for Mike Frysinger
-
Mike Frysinger posted a comment on ticket #48
thanks, i thought the loop always wrote out 6 bytes followed by the NUL, but didn't read it closely enough.
-
increasing buffer to 9 bytes is insufficient. the sprintf call can write up to 10 bytes. i = ((ptr[6] & 0x1E) >> 1); can be 2 digits which means the sprintf will write 4 bytes and since it always does it at offset 6, we need 10. would be good to simplify the sprintf code a little too while at it. - sprintf(&buff[strlen(buff)], "-%d", i); + sprintf(buff + 6, "-%d", i);
-
Bug solved ! Increasing buff[] size by one solved the issue while keeping -O2 optimize compile option that is probably over optimizing strlen ! Here is diff file : --- a/lib/ax25.c 2023-06-29 11:16:10.000000000 +0200 +++ b/lib/ax25.c 2024-08-30 12:40:37.989684153 +0200 @@ -49,7 +49,7 @@ extern struct aftype ax25_aftype; static const char *AX25_print(const char *ptr) { - static char buff[8]; + static char buff[9]; int i; for (i = 0; i < 6; i++) { By the way : Linux Ubuntu-2404 6.8.0-41-generic #41-Ubuntu...
-
Hi, In bug submission it is recommanded to provide application version. This is what is shown when command line - -version is : ./ifconfig --version net-tools 3.14-alpha
-
Where : (gdb) where #0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:44 #1 __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 #2 __GI___pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ./nptl/pthread_kill.c:89 #3 0x00007ffff7c4526e in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 #4 0x00007ffff7c288ff in __GI_abort () at ./stdlib/abort.c:79 #5 0x00007ffff7c297b6 in __libc_message_impl...
-
enable https for cdemu vhost
-
fwiw, with current versions, you can now do: $ curlftpfs -o "custom_list=LIST -aL,..." ... no patching needed
-
--- a/ftpfs.c +++ b/ftpfs.c @@ -1654,9 +1654,7 @@ } if (ftpfs.no_verify_hostname) { - /* The default is 2 which verifies even the host string. This sets to 1 - * which means verify the host but not the string. */ - curl_easy_setopt_or_die(easy, CURLOPT_SSL_VERIFYHOST, 1); + curl_easy_setopt_or_die(easy, CURLOPT_SSL_VERIFYHOST, 0); } curl_easy_setopt_or_die(easy, CURLOPT_INTERFACE, ftpfs.interface);
-
patches are easier to review. can you just use normal git diff or git am output ? process-wise, i would expect this target to be something developers have to invoke manually, not something that would be automatic. that way it wouldn't show up for random non-net-tools developers, just people trying to e.g. build from git. some sort of make update-translations or something. and we'd update our release docs to include that step before doing a final release.
-
that one makes sense though i think. it's a diff tool provided by a diff project with diff command line options. afaik, they maintain their own translations too. that would be a good argument for keeping translations of hostname man pages in net-tools itself. which i guess would extrapolate to all man pages we have (and intend on "keeping" vs moving to the man-pages project).
-
is /etc/ethers used by anything other than the net-tools arp daemons ? i wasn't sure if it was really generic enough to consider shifting to the upstream man-pages project.
-
if the canonical ethers(5) is maintained in net-tools, then it makes sense to include translations in here too
-
not everyone agrees that pure web interfaces are better than mailing lists
-
we have a mailing list already if you want to discuss things
-
Please migrate git repo to gitlab/github
-
Please migrate git repo to gitlab/githun
-
Hello, I maintain a clone of it o GitHub here: https://github.com/ecki/net-tools Gruss Bernd
-
Flags short form not uniq in interface output
-
okiedokie, pushed that fix https://sourceforge.net/p/net-tools/code/ci/4030929bb6f3ee6f465c76869d7a49424df45d9e
-
Can’t remember I think I was inspired by BSD tools but not sure. I would agree to change pointtopoint, because PROMISC might be more security critical (even when the linked patch modified it from M to P …)
-
this bug has been around for over 21 years ;). added via https://sourceforge.net/p/net-tools/code/ci/942d4debc340b0ea039483301088ff5e667009bf i don't know how the short flags were picked and whether they're related to anything else (like a command line option). if they're not, easiest thing is prob to change pointtopoint to lowercase p. i can't find any such relationship in the tree ...
-
Flags short form not uniq in interface output
-
RMT - extend 's' command should consume '\n'?
-
glad you were able to figure it out
-
implement POSIX getline & getdelim
-
entry Iptab not sorted
-
thanks, merged in commit dfc41e0675179912d4425672b90cac8e45b3dab4!
-
thanks, merged in commit dfc41e0675179912d4425672b90cac8e45b3dab4!
-
thanks, merged!
-
patch looks fine, but can you provide your name & e-mail address for credit ?
-
update for 0.4 version
-
cleanup code comments
-
refresh build tools
-
strip leading space from ChangeLog
-
rework -Werror handling into a dedicated configure option
-
update changelog for 0.3 release
-
Fix error when autotools cannot find README file
-
fix undefined behavior with va_arg on 16-bit value
-
github: enable build+test CI action
-
liblzw-config: drop old config script
-
migrate to github
-
set homepage in build tools
-
drop custom big endian unpacking
-
-
ar & ranlib tools should be dynamically detected
-
no new release for long time
-
net-tools-2.10 is now available!
-
netlink support for netstat
-
netstat -agn limits output to 10 chars with longer interface names
-
i don't have IGMP on my system to double check, but the patch looks good, and the table is already set up to output to 15 cols. merged, thanks! https://sourceforge.net/p/net-tools/code/ci/86908d4ecfd51b9357e42103f7ac92e3586d82e7
-
mii-tool uses the wrong phy index when watching
-
this has been fixed here: https://sourceforge.net/p/net-tools/code/ci/038ed39acb9eb62196809f2dcc2940bedee46cb7
-
hostname -i on IPv4/IPv6 dual stack systems
-
rename Estonian translation file name from et_EE to et
-
i think you have the reasoning inverted. the et_EE locale is the Estonian language (et) spoken in Estonia (EE), so renaming et_EE to et is about providing a default Estonian language translation regardless of country. if we assume that there is a baseline Estonian language that is mutually intelligible across the world (which, iiuc, is accurate), then using et makes sense. should be renamed now: https://sourceforge.net/p/net-tools/code/ci/8dcf2425f8f3409c4ed38e2fa3e28caf7e1b7302
-
i don't feel strongly either way. i figured we'd build an array of pointers and run qsort on it either way, and having the callback to qsort parse arbitrary keys didn't seem too much more work on top of it. but omitting that and hardcoding metric (at least to start with) is also pretty easy. and we can always add later if people really want more.
-
Fix SCTP connections handle by netstat tool
-
i had to update the first patch as there's been a rework of the SCTP code since, but wasn't too hard. please check for me. https://sourceforge.net/p/net-tools/code/ci/da0b11708357c0cf1b30c73d8661810919194d3e for your 2nd patch, can you reevaluate the latest git version and see if it's still needed ? and if so, post an updated version ? i don't use SCTP so i'm not really familiar with it.
-
netstat: explain the meaning of the hyphen under the "Program" column
-
i added a little more detail in the English man page (by providing examples), but my German is way too rusty to try explaining auf Deutsch :p. merged now, thanks! https://sourceforge.net/p/net-tools/code/ci/1a47fe37f6ea3c5b303e44da9fd75bb49163489b
-
ifconfig: doesn't show secondary v4 addresses
-
dupe of https://sourceforge.net/p/net-tools/bugs/12/ i think that Debian bug is also a dupe of https://bugs.debian.org/359676 if you wanted to close it use ip a s in the meantime
-
man: de_DE/fr_FR: outdated references to ipfw and ipchains
-
should be set now: https://sourceforge.net/p/net-tools/code/ci/eb461b71fa5a74fabd9431d6d2e57352c1a2fa7c
-
man: de_DE/fr_FR: outdated references to ipfw and ipchains
-
looks like we fixed this in the English pages a while back: https://sourceforge.net/p/net-tools/code/ci/cb81887c39eb4f1319a17378ccad3203d3f60cf8 but the German/French ones weren't updated at the same time.
-
route: add option to sort results by key (kernel order, metric, iface, etc...)
-
i only just found out/remembered we had a bug tracker ;) that's a good point ... maybe a more general way of looking at it is to provide a sort-by-keys, and the user can select the keys they care about. the default (and fallback if all other keys compare the same) will be "kernel" (as in, the order it returned them), but people can pick other fields (like metric) to sort on instead.
-
i agree we need -4/-6 options. i think the default should be left to the system though. we can't support that with the current gethostbyname/gethostbyname2 APIs. we need to switch to getaddrinfo so we can provide hints.
-
netstat IPv6 handling causes overlapping memcpy
-
thanks, merged! https://sourceforge.net/p/net-tools/code/ci/ebe295a366086c03e5bbb843e38d3b3b774a88a4
-
DDP (AppleTalk) support broken
-
Rename all references to axattach to kissattach.
-
looks like this was merged here: https://sourceforge.net/p/net-tools/code/ci/bfbadfcc5cd288a5af0e6f988fac4bec01210654
-
route: add option to sort results by metric
-
i think the current default of displaying routes based on the order they've been added is pretty well ingrained in expectations of people using this tool adding options to sort the results sounds reasonable. i guess --sort-metric is what you're looking for ? any use in sorting/grouping based on flags or iface or something else ?
-
Duplicate programs named *.old are randomly installed
-
this changes behavior of make update ... it didn't use to backup programs, but now it does that said, this kind of logic is pretty unusual nowadays. i'm just going to delete it. especially since it's been broken since 2011 when i moved ifconfig/route to /bin, and because it hasn't stayed up-to-date with other programs being added. https://sourceforge.net/p/net-tools/code/ci/5484cf9a13a2b1d6f604aad2a4fa41c7f01e1a46
-
mii-tool: automatically enumerate all interfaces by default (like ifconfig)
-
mii-tools has changed to require the iface name be specified: https://sourceforge.net/p/net-tools/code/ci/9dc3a20511a409e1de1a41d715a10028d3bc1b56 i'm not sure we want to bother restoring automatic probing of iface names like ifconfig. but maybe!
-
looks like Bernd handled this in bug #22
-
Wrong exit code in most of the tools in net-tools
-
looks like Bernd handled this in bug #22
-
get_name() in interface.c is out of memory
-
Improved netstat ROSE support
-
thanks, merged! https://sourceforge.net/p/net-tools/code/ci/7c580f7374abb0dcd7d8ec84060aeea12b3db5dd
-
licensing is unrelated to this bug. if you have an issue to bring up, please file a new dedicated bug for it.
-
Update git mirror
-
https://github.com/giftnuss/net-tools is some random person's site repo. we have no control over it. you can ask them to fork Bernd's copy.
-
rename Estonian translation file name from et_EE to et
-
route -6 columns
-
should be fixed by 28d922554b6bf7a38213713ce0ad10fa1b3fed54
-
PATCH: fix typo "Processe" in german translation
-
thanks, merged!
-
masq_info.c: 2 * no checking of input word size ?
-
should be fixed by 839f7607ba1363b126d978084fec08c7c3c03c50 i think
-
mii-tool incorrectly reports half duplex instead of full duplex for gigabit connections
-
seems to be fixed now $ sudo ./mii-tool --verbose eth0 eth0: negotiated 1000baseT-FD flow-control, link ok product info: vendor 00:07:32, model 17 rev 5 basic mode: autonegotiation enabled basic status: autonegotiation complete, link ok capabilities: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD advertising: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control
-
hostname -s fails on resolver problems / inconsitent with debian
-
ifconfig wraps around TX bytes after 4GB
1 >
Gen AI apps are built with MongoDB Atlas
Atlas offers built-in vector search and global availability across 125+ regions. Start building AI apps faster, all in one place.
Try Free →