Thomas Lesne

Thanks Florent for the encoding advice! I should have tested that before. I renamed my FG_HOME directory by adding a "é" character, and retrieved "/sim/fg-home" via telnet: it seems UTF-8 encoded in Flightgear's response. Can you apply the attached patch to your branch?

I just checked using Florent's repo and it works fine for me. If you had to add parentheses for print I think you weren't on the right branch. After cloning the repo you have to checkout to the branch : git checkout telnet-demo-python3

I guess telnet code from python2 did not work 'as is' because of the changes in string handling in python3 : all strings are now unicode. Telnet expects (no pun intended) "binary" strings to send over the wire. That's why I added encode to/decode from ASCII to make things work. I do not know how well it will behave if we have accentuated characters to send/receive. I tested the code with python3: the telnet interface works well in python 3.8. @Huntley can you test if it works for you now? There is...

I guess telnet code from python2 did not work 'as is' because of the changes in string handling in python3 : all strings are now unicode. Telnet expects (no pun intended) "binary" strings to send over the wire. That's why I added encode to/decode from ASCII to make things work. I tested the code with python3: the telnet interface works well in python 3.8. @Huntley can you test if it works for you now? There is one thing I did not fix: the Tk window does not close well, I have to kill it. I may open...

Thanks for your actions Florent. I guess we should merge the branch from your repo. Regarding _heading the variable is not used, I prefixed it with an underscore to mark it "unused" to remove a pylint warning. I totally agree for the readability. I personally use autoformatting as much as possible but it would have made too many changes and I didn't want to make the review difficult to read. Do you want me to make a pass with autopep8 or black[1] to clean up formatting? [1] https://github.com/psf/black...

Everything is now in https://sourceforge.net/p/flightgear/flightgear/merge-requests/224/

Remove python2 compatibility (removes the need for 'future' module), update Tix import, clean all pylint warnings

The changes were automatically generated by "futurize" but I can change the import to minimize changes. People on the devel ML seem OK so far to drop py2 support. I'll make a commit with the suggested change for the import, drop py2 support, and cleaning some pylint warning.