Activity for Templayer
-
Templayer posted a comment on ticket #36
Seeking through the video (while having the seekbar preview feature off) by double clicking a subtitle also causes the GUI to stutter for a few seconds, so the main issue of this Issue will remain, but most excrutiating problems with it can be workarounded with the aforementioned grace time seekbar preview period. (double clicking a subtitle usually means that I intend to play the video, so the system GUI getting hiccups from it isn't as bad as moving the mouse cursor through the seekbar - I'm just...
-
Fun fact - I disabled Seekbar hovering, and while the seekbar preview doesn't occur, the GUI stutter happens anyway. The video has been paused for a few minutes, I move the mouse over the seekbar, the entire system GUI starts stuttering and I can barely move my mouse. There is something finicky happening there.
-
So I tested it and it appears to indeed by the seekbar feature. There is an easy way to solve it WITHOUT turning it off. We need a configurable grace period before the seekbar activates its function to render the preview. Currently, in my testing: 1. Video is not playing. (i.e. the issue itself indeed isn't caused by the playback itself. I just tested it, and as long as I do not cross the seekbar, pausing the playback doesn't trigger GUI "hiccuping") 2. I move the cursor from the video player area...
-
a strange subtitle division bug
-
I won't be testing this. I trust you. :P
-
Batch file conversion - path input fields - cannot use CTRL+A
-
Batch file conversion output file type mismatch
-
Nullpointer reference after batch converting
-
Maybe the issue only occurs when the program is open for the first time after installation? Anyway, this should be addressed in a standalone issue. Make a new Issue and copy everything written in these comments that pertains to it into its description. :) @kameleon Once I can test the release version, and if it works the same as the last preliminary version you have send me, then we should close this issue as done.
-
I tested it last weekend... and then promptly forgot to respond. I hate my memory. It seems to be working as intended.
-
I wish it came with a test weekend. :D :D
-
THANK YOU. I trudged on making subtitles last weekend and it took me approximately one third longer due to this and one additional feature I didn't even know - if a "default length" subtitle is created this way, it forgets the start time. Clicking on the end time won't produce a custom length subtitle if a default length subtitle was created. It was frustrating when I clicked on start time, deleted the surplus created "default length" subtitles, went to find the end time where the actual subtitle...
-
Now it looks perfect, at least to me. See the attached printscreens.
-
It was the one in Subtitle WorkShop 6.2.13_4 Portable.zip
-
Welp, this is going to be hard to use. I have loaded subtitles so that the subtitle editing box is shown together with a subtitle list.
-
Good find, I wouldn't be able to figure that one out (I refuse to have Win8+ on principle, opting for Mint with CinnamonGUI instead). I'll go check.
-
Any way to disable the "Clicking on start subtitle time creates new default-length subtitles" feature?
-
Forgot to attach the screenshot of the label issue.
-
Some of the labels are now seemingly hardcoded for black font and white background in "Light Mode" (which is actually my dark mode because my system theme is dark). Found another issue - XP mode affects the background colour of input fields, such as the Show and Hide subtitle time inputs. It is not occurring again (the labels always do, but not the whitish grey background colour of input fields). I have a strange suspicion that switching Light and Dark Mode with XP mode a lot causes some unexpected...
-
Did some testing and found a slew of issues, BUT! The main problem is gone, and now we have essentially 4 GUI versions where everyone should be able to find at least one version that works for them. See the attached screenshots. Font sizes are now OK. Haven't checked if they are exactly the font size and type set for the application in the settings, but this is enough for me. You should further test it by setting weird fonts that are easy to differentiate, and then with tiny font size versus extremely...
-
Did some testing and found a slew of issues, BUT! The main problem is gone, and now we have essentially 4 GUI versions where everyone should be able to find at least one version that works for them. See the attached screenshots. Font sizes are now OK. Haven't checked if they are exactly the font size and type set for the application in the settings, but this is enough for me. You should further test it by setting weird fonts that are easy to differentiate, and then with tiny font size versus extrenely...
-
No change whatsover. Let's make a brief summary of problems: 1) WinXP mode has wrong colours for context menus (text colour is taken as the foreground value from the system theme, but the background is hardcoded to grey) 2) Normal mode - correct colours, but bad font sizes (and possibly the font itself, I don't know, it's so small I can't tell if it is the one I have set up in the settings) 3) Colour inversion mode - Everything looks correct, more or less. Except... I cannot subjectively use it because...
-
Besides the "System Colour Inversion Mode", you could also add a proper "Dark Mode". Black background, light grey foreground (i.e. strings) for everything.
-
Also, Dark Mode should really be renamed to System Colour Inversion Mode. If somebody will read my previous posts, they are going to be rather confused...
-
Forgot to test Dark Mode. It works well in Dark Mode! (the font, that is) Now I am blind.
-
Welp. It's a little bit better. A little bit.
-
Also: If dark mode is not on then the standard windows behaviour is used, can you test this also? I see some vertical size issues here when the font size is very large, is it the same at your side? If Dark Mode is off then the standard windows behaviour should be used, BUT it should be overridable by the settings. Like for example... the font size.
-
I'll be staying at work late, so I'll either test it in the night or tomorrow.
-
Finally found the issue, but I do not have a proper solution yet. The issue was technically on my side. When I read your changelog, this line stood up for me: "Also the menus have a 'dark' version now provided the XP menus are not active." I was like: "Wait, what do XP menus have to do with colour?" Yes, the XP menus have a hardcoded grey background colour, but take the foreground colour (i.e. text colour) from Windows. Which can lead to a situation where the menus are unreadable in specific cases....
-
Finally found the issue, but I do not have a proper solution yet. The issue was technically on my side. When I read your changelog, this line stood up for me: "Also the menus have a 'dark' version now provided the XP menus are not active." I was like: "Wait, what do XP menus have to do with colour?" Yes, the XP menus have a hardcoded grey background colour, but take the foreground colour (i.e. text colour) from Windows. Which can lead to a situation where the menus are unreadable in specific cases....
-
Actually, that was referring to the text I have quoted, not towards the test version you have provided - I haven't tried that yet. But from what you have just written, it might not make any sense trying it anyway.
-
According to this: http://www.temblast.com/dbplot/color5.htm MenuBar COLOR_MENUBAR Background color of a "flat" menu bar It's possible that just not many context menus use the "flat" menu, as I have it set to 240, 240, 240, which is light grey (for background). I haven't noticed that up until now (and it has been like that for over 5 years now, I think). Which looks eerily similar to the grey in the background of that context menu in the printscreen. This didn't do anything for me, by the way.
-
As in it is affected by the "dark mode" (inverted colours, really) mode? Because I am not using that.
-
I'm using the seekbar feature, so I loathe to turn it off. "Using only one core is asking for problems, I don't recommend it." - I never wrote anything about using just one core. I think you misread what I wrote. I wrote that everything runs on all cores EXCEPT the FIRST core by default, i.e. Subtitle Workshop is running on 7 cores in my 8 core CPU. PotPlayer either uses its own codecs, OR - you can use the system ones if you set it up. PotPlayer has a lot of granular control over things... None...
-
GUI unresponsive - some things need to be offloaded out of the GUI thread
-
Everything seems to be fixed now! Thank you!
-
I'll check it out during the weekend.
-
The 'native' looking dialogs aren't the problem. Them using the legacy 'native' pickers instead of non-legacy 'native' picker is. I hope we understand each other. Hmm. I could try making a video. Or maybe we could actually talk.
-
Also, clicking the Browse button in the batch convert window produces the correct non-legacy native folder picker window. Which also has a legacy and non-legacy variant. For a moment I thought you were going to make your own.
-
Also, clicking the Browse button in the batch convert window produces the correct non-legacy native file picker window. For a moment I thought you were going to make your own.
-
Try comparing this https://sourceforge.net/p/subtitle-workshop-classic/tickets/35/attachment/Legacy%20file%20picker.png with this https://sourceforge.net/p/subtitle-workshop-classic/tickets/_discuss/thread/7f41babc84/c9f3/e69f/attachment/non-legacy%20file%20picker%20dialog.png side by side. Both are native Windows file pickers, but one is legacy and one is newer. Somehow, the application now uses the legacy one after changes after version 6.2.9 test version 4. I haven't tried your fixed version ...
-
I mean that is one way of doing that. I originally meant using non-legacy file picker from Windows. Native. The one that can be configured and stylized, and applies to all dialogs of the same type, no matter the application (as long as the application uses the non-legacy variant, that is). Please note that mine is heavily stylized, and looks like this in multiple applications - the one in the attachment was produced by Firefox. And notice the path bar. This is also how the subtitle loading file picker...
-
I tested multiple other applications that use the non-legacy file picker for opening files, and none of them has been changed to a legacy one, so I do not think that issue is on my side. Could be wrong, of course - as always.
-
The video file picker is now legacy too, but at least it does load videos correctly.
-
I'm planning to test it on Monday.
-
Found a workaround. The file picker is broken, but if I go around it (using the Recent files for example), it works. This gave me an idea - I just drag&dropped the file into Subtitle Workshop and now it works. Voilá! I haven't encountered this behavior before. Other applications still use the non-legacy file picker window, and I have never encountered the "switcharoo" of the types upon returning the result from the file picker window into the application. It's weird. Other than changing my system...
-
Looks like the Settings only allow me to limit the formats in the Save as... dialog window, not the file picker window for loading subtitles. Bollocks. Welp. I'll attach my settings.
-
(the reason why I haven't encountered this that I am always either opening subtitles from Recent, or saving/creating a new one. It's rare for me to open an old subtitle that isn't in Recent)
-
Looks like this is an issue proper. I have used https://gotranscript.com/subtitle-converter to convert it to an srt just in case mine is wrong somehow, and the issue was the same. So I checked and this is a proper issue. The app essentially breaks when it gets the result of the legacy modal file picker. When I select SubViewer 2.0 in the file picker window, and then select a sub file that was created as SubViewer 2.0 file via Subtitle Workshop, it tells me that it isn't a proper SubStation Alpha...
-
(PRIORITY) SRT files broken and the open dialog is now a legacy dialog
-
InfoText and WindowText in HKEY_CURRENT_USER/Control Panel/Colors. At least I hope I had set it up correctly... but it seems to be working fine in other applications. Let me check... it is possible that the issue is on my side. According to this: http://www.temblast.com/dbplot/color5.htm MenuBar COLOR_MENUBAR Background color of a "flat" menu bar It's possible that just not many context menus use the "flat" menu, as I have it set to 240, 240, 240, which is light grey (for background). I haven't noticed...
-
Thank you. ^_^
-
Colour inversion mode perhaps? Hence my question: which version if Windows do you use? Thanks in advance. Answered in the other comment thread.
-
Also this could perhaps help - even stupid shit can be done like inserting coloured elements: https://stackoverflow.com/questions/51935267/howto-create-same-style-of-tmenuitem-with-advanceddrawitem
-
Yup, 6.2.10. What version of windows do you use? Windows 7, the last version that didn't completely suck donkey balls. I was never able myself to adapt the meny colors to light or dark mode settings, but you did somehow something like that... Yup. It was black in the previous version. I have no experience with Delphi. Does the "Update" part of this question help? https://stackoverflow.com/questions/63769656/delphi-change-the-menu-bar-color
-
By the way, I assume this can be tested for easily by downloading a dark Windows theme and using it.
-
The title should read "Context menus use system foreground colour for text, but not the background colour", but I cannot find an edit button to fix the typo.
-
Context menus use system foreground menu for text, but not the background colour
-
That works too. I just hope somebody wasn't using that specific scenario (0 to be considered overlapping in whatever they needed)
-
Newly saved project is not in the Recent files context menu
-
Thank you, much appreciated. I don't know when will be the next time that I will have to manually edit whole batches of subtitles, but not having to manually backup my recent files will become handy eventually.
-
Oh, and by the way, as far as the limitation of recent files remembered, I need to open dozens of files for a one-time change. I just hope that 100 recent files will be enough not to lose the recent files remembered that I want to store... too bad I can't set it to 1000.
-
"Too short pause under" error inspection value bug + inability to check for strict overlaps
-
Excellent. That will force me to finally update from the preliminary version. :P
-
I can, but the split has already been done (albeit manually).
-
Another weird split
-
Also attaching the configuration.
-
Split lines ate the letter "s"
-
Microsoft Access Database Engine Redistributable 32-bit is no longer available
-
when starts When what starts?
-
Yeah, we can reopen it if we encounter it again later. As far as I know, it no longer happens.
-
And thanks you for making the most complex subtitle creation tool even better! And now about that Linux version... :D :D
-
Tested timelines and audio tracks. Two subtitles referencing one video, with two audio tracks and two spots on the timeline per each subtitle file. Opening the other subtitle back and forth moves the position on the timeline correctly AND it also switches the audio track to what the currently-being-opened subtitle was using on the video. It's possible that I am missing something, but it looks like it is working correctly. Great job!
-
What manner of testing do you have in mind? What exactly should I test?
-
Seems to be working correctly. I also tried switching between both subtitles and projects, switching with subtitles that have a different video (video is switched correctly as well) and switching to a subtitle that is connected to a video that is no longer available - I would be expecting for the video to close, but maybe it being kept open in that case might be more useful in fringe cases, so I would leave that one as it is. Good job. What I forgot to test was the timeline seeking - if I switch...
-
The change from this ticket works as it should. The change from the other ticket does not, however. Steps to reproduce the problem: 1. Load a project that will load a subtitle that will also load a video file. 2. Now save as a different subtitle file (I just added TEST at the end). 3. Go to recent and open the original subtitle that you just made a copy of. 4. The video gets closed just to be opened again. 5. Going into recent and clicking on the original subtitle file also reopens the video. Instead...
-
The Save subtitle button shouldn't have three dots, as it doesn't open any modal window or any subsequent part of any kind
-
Mashing F9 works as a workaround for now, but before that I checked the filled subtitle if there weren't any empty rows inside. Which took precious time from me. :p
-
Moving subtitles around doesn't analyze errors in the switched rows, which might lead to faulty error detections
-
Maybe this should be solved together with https://sourceforge.net/p/subtitle-workshop-classic/tickets/22/ Because there should be checks if the video needs to be closed and reloaded.
-
Cancelling the "Load subtitle" modal window reloads the video for some reason
-
It seems to be working now. Nice!
-
The text moves around, but the timestamps stick to the index they are at: https://www.youtube.com/watch?v=QbDqcdLXMl8
-
Doesn't work. Or it has a function that indeed some people might find useful - when I use the buttons to move the subtitles up and down in the subtitle list, the text is moved properly, but the time is not - the moved subtitle will acquire the timing of the subtitle that was previously in the same spot. This might indeed an useful additional feature, but it isn't what I need. :p The time needs to move as well for me. Also - the state bar that shows the current subtitle index and the total number...
-
Yeah, that would work. Except... my problem isn't with overlapping subtitles. My problem is the resulting subtitles being in a wrong order if I add a new one between the splitted ones (by having the first selected). That doesn't automatically mean overlap - I can make the show time of the inserted subtitle be after the hide time of the second splitted subtitle.
-
Yes, I wanted to ask for that too, but I didn't want to pry, as I know you don't like adding settings, and the insertion of subtitle being automatically inserted at the correct spot (showtime-wise) might need one. Because if for whatever reason (or format) it fails, and the user cannot disable that behaviour, then the user would be fucked. They would have to modify the file manually, without a guarantee that it wouldn't get screwed with again. Not that it fails like that while sorting right now (at...
-
That's not what I mean. I wish to keep the times, and only move them in the list. How to explain it. Hmmm... Why I need it - sometimes when I split subtitles, I forget to select the last subtitle that was created by the split. (having an option to automatically select the second resulting subtitle from the split is not an option, as sometimes I need to split the first (and the first result of split) subtitle again) Sometimes I forget to select the second subtitle that was a result from the split....
-
The subtitle that caused that can be seen in the printscreen as well.
-
Yes, if the division dialog used those settings that would be enough. I just tried toggling them off. Not only it doesn't apply for now, I think I also found a new error! Look for the lblLength2 in the attached printscreen. Didn't try confirming that. That could very well result in a crash and right now I need everything as stable as it can be. :P
-
If you switch off "Smart Line Adjust Automatically" in "Settings Advanced" then - Linebreaks will not be replaced by spaces in the divided up parts - No extra line breaks will be inserted if a part is too long Didn't expect the first point ("Linebreaks will not be replaced by spaces in the divided up parts") do occur for that. Maybe that should be a standalone toggle? I see in the code that after a division - dashes etc at the first position are deleted in the parts (unconditionally) - the parts...
-
I'm reporting another form of rogue behavior this results in. I've split this: (notice where the line breaks are) Když nahráváte a editujete a vytváříte finální render je docela důležité ponechat stejnou snímkovací frekvenci. Nebo můžete mít problémy jako interpolované snímky, kde video pak vypadá "duší" - vytváří tzv. "duší" efekt,... ...a v tomto bodě začne velikost výsledného videa bobtnat do nadměrného množství. This resulted in these two subtitles: Když nahráváte a editujete a vytváříte finální...
-
🖒👍
-
So you have duplicated the issue and it is no longer occurring on your end? If that is the case, then I don't think I'll need to test it. I'll trust you on this one. :>
-
It's meant for people that go through here randomly and begin to wonder why my system GUI looks the way it does in the printscreens...
-
By the way, one day, there's going to be a random stranger going through these at a whim and he'll be thinking: "How did he make his system, windows and applications look like that?" Well, "he" hacked the theming dll files to make the system look like what "he" wants. :D
-
Where can I find a log with a stacktrace?
-
Using tab to get into the subtitle list and navigating through the keyboard in the subtitle list has solved the issue. Also it looked like the edit box for subtitles wasn't loaded properly at first.
-
Clicking into the subtitle list produced another nullpointer.
-
Nullpointer on saving
-
And it was replaced with " ".
1 >