BED: Set sensible column widths
BED: Remove initDialog()
BED: Use QStackedLayout
BED: Simplify layout
BED: Move buttons to menu
BED: Add all commands to menu
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
BankEditorDialog: Cleanup
Merge branch 'master' into bug1692-ted
Everything is working great. Before I merge, I want to give BankEditorDialog and MidiProgramsEditor a serious review. This will mean massive changes as usual to bring these two up to standards. So, avoid making any changes to those two while I'm working on this. This will probably take a week or two.
Use QString to avoid gcc warning
Merge remote-tracking branch 'gootector/master'
Remove deprecated std::binary_function
The debug logging that I put in was intended only to determine where a spurious stop or start was originating. Nothing more. Some of this rings a bell. I think we decided that rg would not send a JACK transport stop when rg performed an end-of-composition auto-stop. The reason was that this could cause a fatal stop to a session on another part of the system. E.g. ardour might be recording and needs to capture the rest of the performance. rg only sends JACK transport stop if the user presses the stop...
Add modalias to appdata
Comments
Merge remote-tracking branch 'plcl-gh/MIDI_File_Division_value_configurable'
Shortcut order not respected
Merged as [4f2258]. Please test latest git. I also updated to use the KeyList typedef throughout. See [377198].
bug 1702 fix shortcut oder
The shortcut editor was maintaining the shortcuts in a set so the order from the .rc files was lost. I have moved to using a list to maintain the order. That just means some manual checking for duplicate shortcuts. The menus now show the correct shortcut Please merge
Merge branch 'bug1702'
Use KeyList typedef
TempoView: Sort by time
TempoView: Fix delete not deleting selected items
RMW: Delete TempoView on rg close
TempoView: Improve current item handling
TempoView: Improve list update
TempoView: Cleanup
TempoView: Cleanup
TempoView: Cleanup
TempoView: Cleanup
EditViewBase: Cleanup
Comments
TempoView: Cleanup
TempoView: Cleanup
TempoView: Cleanup
TempoView: Cleanup
TempoView: Cleanup
TempoView: Cleanup
TempoView: Cleanup
TempoView: Cleanup
TempoView: Cleanup
TempoView: Cleanup
Did some testing against [a18c86]. Looks like bank sharing is working fine now. Saves fine. Plays back fine. Looks correct in the MIPP. The main issue appears to be fixed. Found a bug in the bank editor. Deleting a bank clears all the program names in all the other banks on that device. Procedure: Create a new playback device. Click Banks... to open the Manage MIDI Banks and Programs dialog. On the New Device, click Add Bank. Go into that new bank and name two of the programs. Click Add Bank to add...
Re: undo limit, I think the thing to bear in mind is that no one wants to press Ctrl+Z 50 times, let alone 300. It would be best to focus on reducing the number of commands that the bank editor adds to the command history.
The bug1693 logging is not intended to diagnose any issue other than the spurious starts/stops. The wording of the message is imprecise as it was only intended to help figure out where the spurious starts/stops are coming from. It will be issued for all sorts of other situations as well. It's only useful at the moment when a spurious start/stop occurs. Unfortunately it might be so noisy that it is useless at that moment. Hopefully it's good enough. The repeating messages are being caused by JACK....
bug1693 logging
Directory modification date changes when nothing is modified
I've learned over the years not to put too much trust in the directory modification date. Sometimes it is helpful, but usually it is pretty random for various reasons. Can't put the lock file in a different directory. What if there are two files with the same name in two different directories? The lock files have the same name and things are broken. It's a can of worms. We'll leave it as-is. This is how everyone else does it (e.g. LibreOffice).
ListEditView: Push remaining functionality down
ListEditView: Push doc modified/refresh down
ListEditView: Cleanup
Push Segment delete handling down to EventView
ListEditView: Comments
ListEditView: Cleanup
ListEditView: Cleanup
Comment
ListEditView cleanup
ListEditView cleanup
ListEditView cleanup
ListEditView cleanup
ListEditView cleanup
ListEditView cleanup
ListEditView cleanup
Improve editor window titles
This is probably due to the lock file that we create. Unless you have a case where this is causing actual harm, I think this can be rejected.
Chord name ruler
See https://github.com/thanks4opensource/rosegarden-fork for latest.
Feature Requests #504 and #295: Matrix Editor tools rewrite
See https://github.com/thanks4opensource/rosegarden-fork for latest.
Feature Reqest #508: Marker ruler enhancements and fixes
See https://github.com/thanks4opensource/rosegarden-fork for latest.
Looping mode fixes and improvements (Bug #1605)
See https://github.com/thanks4opensource/rosegarden-fork for latest.
Merge Feature Request #507
See https://github.com/thanks4opensource/rosegarden-fork for latest.
Feature Request #503 Matrix Editor note colors
See https://github.com/thanks4opensource/rosegarden-fork for latest.