Activity for Tomasz Babczyński
-
Tomasz Babczyński posted a comment on discussion Open Discussion
Me either. Now I'm working on removing dependency from legacy libraries like prototype, behavior, scriptaculous and very old jQuery. About 80% of the work is done. Next, the google maps migration to leaflet is in my mind. Google analytics... Maybe some day. But not in the near future.
-
Huh, the problem is more serious than it appeared. And I suppose, the leaflet will be affected as well. The problem is in prototype.js library. It is no longer developed and as one gay said "its successors successor is obsoleted now". If I commented out the script calling the library (in js/prototype.js.htm), the maps works again but probably the other things doesn't. To solve the problem, and maybe the others in the future, we should make the audit of the code, find the calls to prototype.js lib...
-
Yes, after sending the message I've noticed the same. In both Firefox and Chrome. The better idea than removing the line is to change it to: Array.from = Array.from || $A for a case of legacy browser without Array.from implementation. Are there such browsers in wild?
-
David, please check whether the file from the following link solves the issue. It is the newest available version of prototype.js file. It is actually file from 2015 but anyway newer than the file in PGV. https://ajax.googleapis.com/ajax/libs/prototype/1.7.3.0/prototype.js @canajun2eh - maybe this proposed bump to 1.7.3 version of prototype helps to solve or or at least workaround the issue until we change google map api to leaflet
-
@GaryT You have my hands. And my phpstorm. And my modest leaflet knowledge. But I refuse to migrate this part of code to anything before deep refactoring and moving all "mapping" code to one-and-the-only place. In my site now, the edit place page and places diagram page display grayed out maps while the personal 'map' card doesn't display map "oops, something went wrong...".
-
Ha, I've caught it. It is not google api issue but the CSS parser. Namely the class includes/classes/class_cssparser.php and the ParseCode(...) function in it. But I don't understand why does it trigger the error. At the end of the function $css var is not empty while it should be... T.
-
Garry, yes, I confirm too. In all themes. But in chrome debugger I have the following warning: "Indicate whether to send a cookie in a cross-site request by specifying its SameSite attribute" Because a cookie’s SameSite attribute was not set or is invalid, it defaults to SameSite=Lax, which prevents the cookie from being sent in a cross-site request. This behavior protects user data from accidentally leaking to third parties and cross-site request forgery. Resolve this issue by updating the attributes...
-
Gerry, it is a surprise to me, because I'm sure it worked some time ago. I don't remember which version of php I had back then. It is possible that 6.x or even 5.x. T.B.
-
Thanks Gerry, I hope postgresql will help to hunt them all. When I created a new user as administrator, the exception of such kind was thrown, but I was not on my computer then. Now I cannot recreate this issue again. I will be trying. T.B.
-
Uncatched PDO (pgsql) exception trying send mail to user
-
php8 null access prohibited
-
Hi, here you can find the second part of the patch I promised. The patch is simple - adding class="noprint" to some elements, which, in my opinion, shouldn't appear in the printouts. T.B.
-
In the previous post, the function is oddly formatted. Here I attach the whole file. The 577 line is commented out and an alternative calculation is placed in the next line (also in 587). These alternatives ensures that vertical lines touch the horizontal ones even in a case when something strange happens with formatting of personal box or between them (as in the issue with BOM mark). T.B. btw. could you remove svn:eol-style=native from the whole project? I have the project both in windows and in...
-
In the previous post, the function is oddly formatted. Here I attach the whole file. The 577 line is commented out and an alternative calculation is placed in the next line (also in 587). These alternatives ensures that vertical lines touch the horizontal ones even in a case when something strange happens with formatting of personal box or between them (as in the issue with BOM mark). T.B.
-
hourglass diagram formatting in Polish
-
Gerry, it works like charm.
-
Look also, please at 74th line of printlog.php. Couldn't it be get_id_from_gedcom called instead of get_gedcom_from_id? The rest of userGedcomAdmin calls looks correct. T.
-
Hi, I've found that the 36 line of edit_privacy.php file puts $ged instead of $ged_id, probably causing the problem. It is strange for me that mysql ignores it but postgresql always was more orthodox. The mysql emits: Warning: #1292 Truncated incorrect DOUBLE value and returns empty result, causing the portal defaults to be used. I've corrected this and it just works at both servers :) I'm not sure whether ged_id is always valid at this place. Maybe get_id_from_gedcom should be called before. T....
-
Sorry, mistake, not this select. It happens after it. The function "get_user_gedcom_setting" gets as gedcom_id the name of it instead of the id. Why? PGV_GED_ID wrong?
-
Uncatched PDO exception trying edit gedcom privacy file
-
boost_chrono library added to solution. Updated names of libraries in boost. (solution compilable but runtime exceptions occure)
-
unique_ptr auto_ptr shated_ptr - cleanup (still not finished)
-
unique_ptr and shared_ptr modernize
-
boost/bind - final upgrade (all projects)
-
global boost placeholders deprecation (all projects but MapEdit++)
-
parę drobiazgów (PngExporter.cpp/Importer)
-
upgrade to 143 toolset version (VS2022)
-
upgrade expat version 2.4.4 to 2.4.6
-
some minor improvements due to lua version
-
some modernizations applied to code (obsoleted headers, aut_ptr, ...)
-
resolved conflicts
-
changed version of compiling tools to 142
-
The last version able to be compiled by VS2010 (but nothing more up to date)
-
Yes, Gerry, you're right. Formally it is all correct. But I will still dislike situations where globals are declared in functions. The present script, the REQUIRE and INCLUDE are the "natural" places where we can find declarations. If they are hidden in functions, I feel a smell. Of course, variables can be filled in inside functions even without parameters or return values but for declarations (in PHP, actually first assignment), I feel uncomfortable. Usually there is a bunch of functions called...
-
The reason is that the form has the "previous state" named "display" in the URL (action field in the form) and doubled in _POST, but the second, only if the checkbox is checked. Therefore - ones checked cannot by unchecked (effectively). My proposition is as follow: file: modules/googlemap/places.php line 584: from: echo ">\n<input type=\"submit\" value=\"", $pgv_lang["view"], "\" >"; to: echo ">\n<input type=\"submit\" value=\"", $pgv_lang["view"], "\""; echo " onclick=\"inactivePlacesSubmit()\"...
-
Gerry, yes, you are right, it works also in PHP 8.0.10. But it seems unpleasant to me a bit. All variables initialized in global scope (no, not declared as global but simply used outside any function) are global. So, what's the point of using global outside of functions? Maybe I'm wrong but I treated this keyword like extern in C - "the variable is defined in another file (not included) but I want to use it also here". The point is also that I like to see declarations (at least as a kind of includes)....
-
This Stationery was correct, sorry, checked without context.
-
PHP 8.1.1 deprecations - Take 6
-
I have no time today to check the database. Tomorrow. but say, do you remember what was the reason of deprecation in 2308 line of the reportbase file: `function PGVRRepeatTagSHandler($attrs) { /** * @deprecated Today is 2021-01-29. Remove this if not causing problems * global $repeats, $repeatsStack, $gedrec, $repeatBytes, $parser, $parserStack, $processRepeats, $currentElement, $fact, $desc; */ global $repeats, $repeatsStack, $gedrec, $repeatBytes, $parser, $processRepeats, $fact, $desc; ` the currentElement...
-
I have no time today to check the database. Tomorrow. but say, do you remember what was the reason of deprecation in 2308 line of the reportbase file: function PGVRRepeatTagSHandler($attrs) { /** * @deprecated Today is 2021-01-29. Remove this if not causing problems * global $repeats, $repeatsStack, $gedrec, $repeatBytes, $parser, $parserStack, $processRepeats, $currentElement, $fact, $desc; */ global $repeats, $repeatsStack, $gedrec, $repeatBytes, $parser, $processRepeats, $fact, $desc; the currentElement...
-
Eh, what to say you with my only 40 years programming practise ;) I used punched cards but for fortran, not cobol. In fact I've never seen program in cobol although I know some cobol programmers. So which form of reporting corrections do you prefer? zip with corrected files?
-
Gerry, really??? Are you patching the code manually? Indeed, it is painful. If you don't want commits, pull requests (if SVN allows them) nor patch files, so how to give you changes? One line, some lines but in many files? I suppose you don't want my current 828 lines long patch with missing globals and some typos corrections?
-
254 /aproxiamte/approximate/ 256 /Stationary/Stationery/ 708 /alignement/alignment/ 715 /carachter/character/ I will put them in my patch
-
The SQL mentioned by @GaryT is parsed and run correctly in mysql (mariaDB) but in postgreSQL generates ERROR: for SELECT DISTINCT, ORDER BY expressions must appear in select list Adding filter1.d_julianday1 to the list of columns solves the issue at the database level but I have no idea where in code to correct it (maybe ab. 3262 line in reportbase) and more, what the side effects will appear
-
but with "''", not just '' (the string containing two apostrophes, not the empty string)
-
but with "''", not just '' (the string containing two apostrophes, not the empty string)
-
Still not SQL error but: the line 2862 of class_reportbase.php should be: if (empty($value)) $value = "''"; // PHP 8.1.1 doesn't like NULL because str_replace converts empty string into nothing and $condition becomes (!='') That is why I also replaced is_null with empty.
-
I will look at this SQL error on evening but I'm afraid it may (or not) be data or DB specific. I have mariaDB at home and postgreSQL at work so I'll try to check both.
-
PHP is strange now. It seems that missed global declaration is not actually an error. The interpreter finds correctly the proper variable. But php goes to become stricter more and more, so I'm afraid that in the near future this error will be the real error. I tried to hunt such errors in the whole project but after run the inspection in PhpStorm (enabling only this one error) I gave up. 1571 errors and 1411 warnings (var declared but e.g. in conditional expression). I will return to the subject...
-
Gary, Gerry, the message suggests that the $condition contains '!=' with nothing left or right to it. It would be interesting what was in the $attrs["condition"]; array just before the error has been triggered. please also attach the following patch with - some typos corrected, - added some missing global definition - escaped XML special characters in documenting comments (only in class_reportbase.php)
-
Well ;) the highlights at the php.net page helped much. In fact it is a good idea that fatal errors cannot be ignored, at lest so easily. But we teach students again and again that api must not be even touched after a release of a program was put into community and they never learn it.
-
printing notes for global facts
-
The first incompatibility with php8.0
-
Well, on the page: https://gedcom.io/specs/ the gedcom 7.0.3 specification is available. In this version the ASSO is permitted also at the greater than 1st level... BTW. There is also CEME tag used in PGV and in my ged files which is obsoleted by the 5.5 version of the GEDCOM. Why, why, why the versions are not back compatible so much?!
-
The previous text sounds good. But I'm not sure wether this additional clarification will clarify the case or rather will obscure it.
-
Yes, it is good news that the code is correct. Point me to the appropriate help texts, I'd like to translate it into Polish. My gedcom contains ASSO in that incorrect way but only 7 times. Not so bad ;)
-
Gerry, it is not correct. Due to the Gedcom5.5.5 specification (p. 65): The person's relation or association is the person being pointed to. The association or relationship is stated by the value on the subordinate RELA line. For example: 0 @I1@ INDI 1 NAME Fred /Jones/ 1 ASSO @I2@ 2 RELA Godfather This GEDCOM fragment states that @I2@ is Fred's godfather.
-
I've found that there is assotiated tag _ASSO which can be used instead of ASSO in such cases. But as with all non standard tags - it may or may not be used in software.
-
Due to my knowledge of this tag, the ASSO should be used at the first level only. It is tag for person or family but not for BIRT or so. The fragment with ASSOs should be: 1 ASSO @I1413@ 2 RELA godfather 1 ASSO @I1415@ 2 RELA godmother Tomasz
-
Hi Paul, did you have database with root account and your web host have allowed this? Really?? If not or you are unsure then probably you have changed the config.php file in the index directory. Root is the default db user. Probably you had the different user for the db. Tom
-
Isn't it fixed in the 7268 revision from the 7 Jan 2021? Try to update PGV from SVN to the current version as it seams you have not up-to-date version, although not so old as Gerry suggested. :)
-
I was not sure whether to fix call or the function itself :) Thanx
-
divByZero if empty DB password
-
Hay, @Gary and @canajun2eh, wait! Yet we have support to google maps api v3 since 7143 revision from 22.10.2016. But still the code needs to be refactorized and still support to alternative map service is welcomed. I have it on the list...
-
it was duplicate of the next post...
-
@Gary 1. new API keys issue is a very likely reason 2. UMP definitely is not Worldwide, even not Europewide, it is a Polish map. More, the main purpose of the project is navigation, not presentation. Although my heart and hands are with this project, I must to say that OSM is a better candidate. 3. There are publicly available OSM servers. We needn't to install one more and it is easy to find at least one working. 4. Main problem with migrating API in PGV it that the code is not clean. There are...
-
Hi Gerry, I'm happy user of old (legacy?) api key for google map service. It still works without any card. How long else, I don't know... Generally I like google tools but not their policy. I think about an alternative to google maps. I'd prefer UMP (I participate in making it) but it is mainly Polish map and has not handy API. Maybe OSM, although they are rivals of us? BTW. I believe that goggle maps will be free, otherwise they would be less attractive to advertisers. But the APIs can become commercial...
-
It is sad to hear this, it is really soon. But now, the grayed out map with watermark "for development purposes only" is not because the API is obsoleted but that it is not connected to a card. We, at (https://mapa.ump.waw.pl), have the same problem. The service was connected to a private card but after some months appeared that the amount of the free data is not so big as we thought and that the card is charged. Then it was disconnected and the result is ready to admire in the page cited above (if...
-
It is sad to hear this, it is really soon. But now, the grayed map with watermark "it is for development purposes only" is not because the API is obsoleted but that it is not connected to a card. We, at (https://mapa.ump.waw.pl), have the same problem. The service was connected to a private card but after some months appeared that the amount of the free data is not so big as we thought and that the card is charged. Then it was disconnected and the result is ready to admire in the page cited above...
-
It looks like a bug in tables creation. Could you drop a ticket about it? I have no time to deal with it now and afraid that I will not remember when I will upgrade the API (v2->v3) in the undefinable future.
-
Maybe this patch will be better. It is generated ignoring white spaces and contains only important changes. The rest in the previous one is just the indentation matter.
-
report error when DB connection failed
-
show/hide controls in map panel
-
Some multimedia fixes
-
defaultconfig: - fix address to obtain a key to googlemaps v3 - fix typo in comment...
-
correct polish tradition names in batch_update
-
I've added some additional patches to the place_edit file: - converting -lat to S...
-
If you install dltk 3 from Indigo update site, the ANTLR IDE works in Juno, Kepler,...
1