Simon Urli

Hi Scott, thanks for your answer. So then what are the next steps and how can we plan such a move to Github? I see two options there: 1. you do the move, you're still owner and it's an official migration and we contribute through pull requests at least at first 2. you keep HtmlCleaner here and we create a fork on Github that we maintain there personally I don't like option 2 and I'd really prefer to go towards option 1, but it depends on you. Simon

Hello, I recently started trying to contribute directly to the code of HtmlCleaner for fixing a bug I reported, and I discovered that it wasn't that easy to contribute and get feedbacks on sourceforge. At least, not as easy as it can be on Github (or Gitlab). And I'm wondering if moving the project couldn't help get more contributions and have bug fixed more quickly. To give a bit of context, I'm one of the core committer of XWiki (https://www.xwiki.org) whose code in available on Github (https://github.com/xwiki)....

I tried to work on that issue, I think I actually made too much changes: in particular I saw that XmlSerializer#dontEscape is used both for knowing if the content needs to be escaped and to know if CDATA should be added, which is a problem here as we still don't want to escape the content even without a CDATA. So I think same problem might apply to DomSerializer, in which case my code is probably wrong and I might miss adding a unit test somewhere.

CDATA added for any kind of scripts even for application/json ones

Various tags incorrectly not marked as phrasing content in HTML5

@scottwilson it seems you forgot to close that one: I can see a commit related to it before release 2.28, see https://sourceforge.net/p/htmlcleaner/code/595/

@scottwilson sorry I attached this to the wrong version, and looks like I cannot edit the ticket. I obtained the bug with HtmlCleaner 2.24

Div element wrongly filtered out from dl children when using HTML 5