Activity for Hrotkó Gábor
-
Hrotkó Gábor posted a comment on ticket #617
Yes, just checked it. Without this patch, the untitled buffer will be silently deleted!
-
Please, an admin accept this patch! Thanx!
-
I could not reproduce with current trunk. Can you please try it with a clean profil?
-
untitled buffer issue when started with -background
-
I fixed the isUntitled stuff. After changing the restore property, the path of the untitled buffer will change. I could not fix that, and I think this usecase is not really occurs often.
-
Sorry, but I cannot reproduce in any way I tried. This patch is only about saving perspective.xml.
-
Hi! I have a patch for this. My modification is about to save the untitled buffer to the perspective.xml regardless the settings of the 'Autosave untitled buffers' setting. Please test! Roti
-
I am glad that this feature will appear in the next release. Your guidance was very helpfull. I think I will ask Andrew for a post on webup8 once the debs are available.
-
I made changes, according to your comments. Please review.
-
Thanx for the $JEDIT_SETTINGS commit, after that I could create my patch to modify the behaviour to match the desired. I also removed the methods that we do need to handle untitled autsaves separately. I think changing the bacup/autosave dir while running is an important thing, because it can lead to data loss. So I also added the feature to move the autosaves to the correct location, when the user change the bacup/autosave dir. Please test the attached patch.
-
Thanx for the $JEDIT_SETTINGS commit, after that I could create my patch to modify the behaviour to match the desired. I also removed the methods that we do need to handle untitled autsaves separately. Please test the attached patch.
-
I tested your requirement, and the full behavior is only possible with my patch: saveUntitled_24718.patch. I tried to prepare another patch with less code modifications, but there is a problem: if you change the backup/autosave while creating untitled buffers, you cannot get the right paths back without storing it into the perspective. Please try to create an untitled buffer, then restart, then change the backup/autosave path, then create another untitled buffer, then restart ... That is why I created...
-
I think, now the code in trunk, restores the correct path. I tested it now. We can forget my feature request.
-
Ok, from your perspective, what is left to be done for this feature to be accepted?
-
I had some misunderstanding of your wording lastly, but now I understand all requirements, and created the patch for that. The only "big" change is that if no autosave/backup directory specified, the backup dir will be: jedit settings dir + backup, to separate those files. Please test this patch.
-
I created a patch for "Project Viewer opens an empty buffer". For some reason, I modified BufferSet.addBufferAt, but it can be reverted, and cured this problem. For untitled backup: "when an autosave untitled is restored from backup", I need a little clarification. I do not see that any backup is saved for untitled buffers. Should we have backups also for untitled buffers? And last: me: if the backup, autosave dir set: new untitled buffers will be saved to that location you: I don't want that setting...
-
I created a patch, that works exactly as you described: if the backup, autosave dir set: new untitled buffers will be saved to that location newly opened files will be autosaved to that dir, prefixed with their path if the backup, autosave dir is NOT set: new untitled buffers will be saved to the currently opened buffer's dir or for the very first start: to jedit's dir newly opened files will be autosaved next to the original Note: The autosave path will be set when a buffer is created/opened. When...
-
I think, the untitled buffers should all go into one directory by default, even if we do not set the autosave/backup dir explicitly. For example in this way one can easily find them after a long time, even without using jEdit. Imagine by the default behaviour, that if one would have many untitled buffers lying around the filesystem. Attached a small patch to make it work again, it fixes the following problem: when I edited a real file without saving, and have untitled buffers, the close question...
-
Are you testing it with a clean new settings dir? I tested with new settings dir, and it works. I think it should work like this, because this feature is not released yet.
-
I added a simple solution for this: When you have more than one view opened, and close a view with untitled buffers: all of it's untitled buffers will be moved to the first or last opened view's active editpane's bufferset. Works fine, no untitled buffer will be lost. Also for EditPane and View scopes. I think the help also should be updated with these infos.
-
This is against 24674, and I tested it also.
-
Hi Alan, can you review my patch? I could promote jedit with more success by this feature. By the way, I use the version with this path for months without any issue. Thanx!
-
Please find the updated patch against rev. 24670 attached.
-
patch #596 create for this https://sourceforge.net/p/jedit/patches/596/
-
#501 Auto-save untitled buffers - patch
1