Activity for P.Rouleau
-
P.Rouleau modified ticket #4
partclone_imageinfo detects anomalies with image format 0002
-
Yes. Exactly.
-
I was forgetting to point out one point: I am not sure if the modification to src/Makefile.am. I didn't play with makefile for a long time and I am still unfamiliar with Makefile.am features. I tried to define a line like libchecksum_a_SOURCES = libchecksum.c and adding libchecksum.a to a few places but the linker was giving errors. So I ended up adding libchecksum.c to libpartclone_a_SOURCES. I wonder if there is a better solution.
-
Support image format 0002 in partclone_imageinfo
-
imagemount v0.4.2 does not work for all NTFS, many ext4 filesystems
-
imagemount puts the cache file at the root (/) when the path is not absolute
-
verify the integrity of the image
-
Request: partclone_imageinfo should checks if the last sector is missing
-
partclone_imageinfo detects anomalies with image format 0002
-
I should create a few tickets too. I found a few issues with partclone_imageinfo and I found a few fixes. One of them may affect imagemount and I need to do more tests. I'm playing the the code to better understand it. I have a wip/ branch where I experiment many things. I will split it into many goal focused branches later.
-
OK. All the tabs should be gone now. I finally saw the buttons on the MR above. The "Refresh" button updates the commits to the most recent ones. SourceForge does not seem to do it automatically. And sorry again for my hesitation to go straight to spaces.
-
Sorry, in [1], I proposed to use only spaces for indentation and you agreed and suggested to use a formatting that was close to what is used in partclone itself. Turns out partclone use the mixed indentation too (but not consistent). Unless I did not give priority to the right files? The main reason for me to propose to use only spaces is because I could not configure my editors to follow the mixed rule. However, now that I have found clang, it is possible to configure VS Code with an extension to...
-
Improve formatting by using clang-format
-
At the risk of "bikeshedding" I just want to note that days ago partclone project updated its README to no longer considers its master branch as unstable , after an issue you opened. Indeed, but he did not delete the release branch itself. So when we look at the existing branches, we see 'master' and 'release' are at different commits, and when we dig deeper, we see that 'release' is related to v0.2.x instead of v0.3.x. So I will do a follow up on that. I think it is best to work with the latest...
-
At the risk of "bikeshedding" I just want to note that days ago partclone project updated its README to no longer considers its master branch as unstable , after an issue you opened. Indeed, but he did not delete the release branch itself. So when we look at the existing branches, we see 'master' and 'release' are at different commits, and when we dig deeper, we see that 'release' is related to v0.2.x instead of v0.3.x. So I will do a follow up on that. I think it is best to work we the latest tag...
-
(Looks like my reply from gmail did not get here, so here it is) In this case, there is the ambition to merge partclone-utils into the partclone itself, so I suggest we imitate partclone's coding style as closely as possible. Partclone uses 4 spaces for indentation (but it not consistent with its use of newline before curly brackets in function implementations). I think it is a good idea to match partclone's coding style. From what I found, .editorconfig's support in Atom and VS Code is pretty limited...
-
(Looks like my reply from gmail did get here, so here it is) In this case, there is the ambition to merge partclone-utils into the partclone itself, so I suggest we imitate partclone's coding style as closely as possible. Partclone uses 4 spaces for indentation (but it not consistent with its use of newline before curly brackets in function implementations). I think it is a good idea to match partclone's coding style. From what I found, .editorconfig's support in Atom and VS Code is pretty limited...
-
On Fri, Feb 19, 2021 at 9:33 PM Rescuezilla rescuezilla@users.sourceforge.net wrote: P.Rouleau wrote https://sourceforge.net/p/partclone-utils/git/merge-requests/8/#f6d4 a comment relevant to this issue on Merge Request #8: One thing I want to try to handle in partclone-utils is to implement a workaround for the missing last sector in NTFS image made by partclone. I still have to play more with the tool to clarify if it is a blocker or just an annoying warning. My response: I don't believe the missing...
-
On Fri, Feb 19, 2021 at 9:33 PM Rescuezilla rescuezilla@users.sourceforge.net wrote: P.Rouleau wrote https://sourceforge.net/p/partclone-utils/git/merge-requests/8/#f6d4 a comment relevant to this issue on Merge Request #8: One thing I want to try to handle in partclone-utils is to implement a workaround for the missing last sector in NTFS image made by partclone. I still have to play more with the tool to clarify if it is a blocker or just an annoying warning. My response: I don't believe the missing...
-
You took me by surprise. I will try to do my part, but I did not expect that honor. 😅 One thing I want to try to handle in partclone-utils is to implement a workaround for the missing last sector in NTFS image made by partclone. I still have to play more with the tool to clarify if it is a blocker or just an annoying warning. One question: how do you feel about the code formatting in partclone-utils? I tried to configure Atom and VS Code to handle the "indent by 4 chars, but tabs are 8 chars", but...
-
Fix a division by zero with partclone v2 image
-
Hummm, I made this pull request a while ago, 🙄 https://github.com/Thomas-Tsai/partclone/pull/54 I have messaged the Thomas to try to get it merged in the current partclone code.
1
