I'll follow this up with a commit that runs dos2unix on all the files and clang-format, including a clang-format configuration file.
Fix an incorrect function prototype
Fix another incorrect function prototype.
This shit is no less fucked, but you don't get a warning in the C++ build anymore.
Enable command-line processing for Linux.
Fix some string literal const warnings for C++ build.
Fix signedness mismatch.
Fix using integer abs with float value warning.
Remove unsued variables.
Removed unused variable blocked.
Run clang-format-14.
Fix single line to get it to compile as c++ with -fpermissive.
dos2unix
Let me open a PR for what I have so far. You can take a look and then we can go from there.
I'd like to do some further modernization work on the code base. Starting with running it through an autoformatter like clang-format. Would you accept that big of a change?
Forward declarations missing for rename_area and remove_area
0.9.0 is the latest tarball I see on sourceforge, from 2013. Is there a more recent official release? -Pete On Thu, 5 Jan 2023 at 16:54, Markus Hoenicka mhoenicka@users.sourceforge.net wrote: What version of unit.c are you referring to? Looks like this issue has been fixed by Jan Engelhard in 2017, see this commit: https://sourceforge.net/p/libdbi-drivers/libdbi-drivers/ci/470b58e15dc6f406899b1695aec7fc98986b8f14/ [bugs:#27] https://sourceforge.net/p/libdbi-drivers/bugs/27/ Test missing include of...
Fix autoconf check to be C99 compliant.
The commit you reference is 100% the same as my fix so I'm happy for you to close this as already fixed. On Thu, 5 Jan 2023 at 22:22, Peter Fordham peter.fordham@gmail.com wrote: 0.9.0 is the latest tarball I see on sourceforge, from 2013. Is there a more recent official release? -Pete On Thu, 5 Jan 2023 at 16:54, Markus Hoenicka mhoenicka@users.sourceforge.net wrote: What version of unit.c are you referring to? Looks like this issue has been fixed by Jan Engelhard in 2017, see this commit: https://sourceforge.net/p/libdbi-drivers/libdbi-drivers/ci/470b58e15dc6f406899b1695aec7fc98986b8f14/...
Test missing include of sys/wait.h tests/cgreen/src/unit.c
Opened as part of this effort: https://fedoraproject.org/wiki/Toolchain/PortingToModernC
Add a missing int to particle_ai.h sprint_number param. c99
Bug opened as part of this effort: https://fedoraproject.org/wiki/Toolchain/PortingToModernC
configure.ac conaints a not C99 compliant check.
Add missing header to fix C99 conformance in blockmode.c
Fix C99 conformance issues in autotools.
Bug opened as part of this effort: https://fedoraproject.org/wiki/Toolchain/PortingToModernC
config/ag_macros.m4 has a couple of bugs