Maarten

As an alternative, I've attached an alternative patch that changes all SIZEOF_OFF_T to MPG123_SIZEOF_OFF_T. This patch was created by @sezero, another member of the SDL project.

SIZEOF_OFF_T assertion error with cmake, mingw32, and mpg123 as a subproject

Trunk works :)

You suggested using __ANDROID__ there. __ANDROID__ is a built-in macro, whereas ANDROID is added by the CMake toolchain file. Reading the verbose build log, -DANDROID is correctly passed when compiling C sources, but not when assembling S sources.

You suggested using __ANDROID__ there. __ANDROID__ is a built-in macro, whereas ANDROID is added by the CMake toolchain file. Reading the build log, Reading the verbose build log, -DANDROID is correctly passed when compiling C sources, but not when assembling S sources.

Unrelated to the error, but would this patch make sense? diff --git a/src/libmpg123/tabinit_mmx.S b/src/libmpg123/tabinit_mmx.S index 077e19e7..332bcd22 100644 --- a/src/libmpg123/tabinit_mmx.S +++ b/src/libmpg123/tabinit_mmx.S @@ -10,7 +10,11 @@ #include "mangle.h" -.data +#ifndef __APPLE__ + .section .rodata +#else + .data +#endif ALIGN32 .globl ASM_NAME(INT123_costab_mmxsse) ASM_NAME(INT123_costab_mmxsse):

Building mpg123 using non-legacy CMake toolchain fails

(not to self: read the chat history before posting) Apologies about the noise