User Activity

  • Posted a comment on merge request #61 on MComix

    Why, thank you, this is a great addition. I also like your branch name! Also agreed about the annotation import, this really helps for type annotations.

  • Merged merge request #61 on Git on MComix

    PDFMulti: Call a pymupdf a pymupdf

  • Modified ticket #161 on MComix

    PDF support broken

  • Committed [e02b1e] on Git

    fix: Restore multiprocessing freeze_support in win32 executable

  • Modified a comment on ticket #161 on MComix

    Yes, that's exactly what I was talking about. This code should be somewhere in the code path that is taken when MComix is run on Windows while frozen by Pyinstaller. From what I can see, PyInstaller is set up to run mcomixstarter.py. This file calls mcomix.__main__.main(). Unfortunately, the mentioned code above is in if __name__ == '__main__', while it was in main() previously when the freeze support was supposedly still working.

  • Posted a comment on ticket #161 on MComix

    Yes, that's exactly what I was talking about. This code should be somewhere in the code path that is taken when MComix is run on Windows while frozen by Pyinstaller. From what I can see, PyInstaller is set up to run mcomixstarter.py. This file calls mcomix.main.main(). Unfortunately, the mentioned code above is in if __name__ == '__main__', while it was in main() previously when the freeze support was supposedly still working.

  • Posted a comment on ticket #161 on MComix

    Come to think of it, it seems kind of strange that we have freeze_support() in code paths that are never run on Windows and frozen environment. Maybe we should move it to mcomixstarter.py and just be done with it?

  • Posted a comment on ticket #161 on MComix

    Maybe I was mistaken - it seems that the relevant code was refactored out in a4092eb4f2927ce5d600444d0b10c308148ca34d and is no no longer called when running mcomixstarter.py, which happens when MComix is frozen for Windows.

View All

Personal Data

Username:
oddegamra
Joined:
2004-11-23 10:27:55
Location:
Germany / CEST
Gender:
Male

Projects

This is a list of open source software projects that Oddegamra is associated with:

  • Project Logo MComix GTK+ comic book viewer. Last Updated:

Personal Tools