Why, thank you, this is a great addition. I also like your branch name! Also agreed about the annotation import, this really helps for type annotations.
PDFMulti: Call a pymupdf a pymupdf
PDF support broken
fix: Restore multiprocessing freeze_support in win32 executable
Yes, that's exactly what I was talking about. This code should be somewhere in the code path that is taken when MComix is run on Windows while frozen by Pyinstaller. From what I can see, PyInstaller is set up to run mcomixstarter.py. This file calls mcomix.__main__.main(). Unfortunately, the mentioned code above is in if __name__ == '__main__', while it was in main() previously when the freeze support was supposedly still working.
Yes, that's exactly what I was talking about. This code should be somewhere in the code path that is taken when MComix is run on Windows while frozen by Pyinstaller. From what I can see, PyInstaller is set up to run mcomixstarter.py. This file calls mcomix.main.main(). Unfortunately, the mentioned code above is in if __name__ == '__main__', while it was in main() previously when the freeze support was supposedly still working.
Come to think of it, it seems kind of strange that we have freeze_support() in code paths that are never run on Windows and frozen environment. Maybe we should move it to mcomixstarter.py and just be done with it?
Maybe I was mistaken - it seems that the relevant code was refactored out in a4092eb4f2927ce5d600444d0b10c308148ca34d and is no no longer called when running mcomixstarter.py, which happens when MComix is frozen for Windows.